248129 – sci-geosciences/merkaartor fails if nls is not set

Bug 248129 - sci-geosciences/merkaartor fails if nls is not set

Summary: sci-geosciences/merkaartor fails if nls is not set

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Unspecified (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Hanno Böck

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2008-11-22 09:44 UTC by Boris
Modified:	2008-11-24 17:49 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
merkaartor-nls.patch (merkaartor-nls.patch,981 bytes, patch) 2008-11-22 09:45 UTC, Boris	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Boris 2008-11-22 09:44:06 UTC

The merkaartor-ebuilds both (0.11 and 9999) fails if the nls-use-flag is not set.

This is because the line
 use nls && lrelease Merkaartor.pro || die "lrelease failed"
evaluates to die without calling lrelease at all.

Reproducible: Always

Steps to Reproduce:
1. Don't set the nls-use-flag
2. Try to install sci-geosciences/merkaartor
Actual Results:  
>>> Starting src_compile

!!! ERROR in sci-geosciences/merkaartor-0.11:
!!! In src_compile at line 3801
!!! lrelease failed

Expected Results:  
Start compiling :-)

Comment 1 Boris 2008-11-22 09:45:04 UTC

Created attachment 172812 [details, diff]
merkaartor-nls.patch

A possible patch

Comment 2 Ingo Bormuth 2008-11-23 18:39:48 UTC

Same here. Please fix, a quick one-liner is sufficient. Thanks.

 src_compile() {
-	use nls && lrelease Merkaartor.pro || die "lrelease failed"
+	use nls && ( lrelease Merkaartor.pro || die "lrelease failed" )

Comment 3 Hanno Böck gentoo-dev

2008-11-24 17:49:57 UTC

done, thanks for the note