Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 247023 - dev-util/cvs2svn-2.1.1 fails multiple tests but still installs
Summary: dev-util/cvs2svn-2.1.1 fails multiple tests but still installs
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Hans de Graaff
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-16 07:44 UTC by Hans de Graaff
Modified: 2009-05-27 22:56 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
cvs2svn-2.2.0.ebuild (cvs2svn-2.2.0.ebuild,984 bytes, text/plain)
2008-11-25 13:51 UTC, Sven
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Hans de Graaff gentoo-dev Security 2008-11-16 07:44:12 UTC
cvs2svn-2.1.1 fails multiple tests but in the end still installs its files. If the tests are run and something goes wrong I'd expect the build to stop, not to proceed silently.


PASS:  run-tests.py 142: add a file on a branch using newer CVS
EXCEPTION: Failure: Repository not created: '/var/tmp/portage/dev-util/cvs2svn-2.1.1/work/cvs2svn-2.1.1/cvs2svn-tmp/main--options=cvs2svn-git.options-svnrepos'
Traceback (most recent call last):
  File "/var/tmp/portage/dev-util/cvs2svn-2.1.1/work/cvs2svn-2.1.1/svntest/main.py", line 1074, in run
    rc = apply(self.pred.run, (), kw)
  File "/var/tmp/portage/dev-util/cvs2svn-2.1.1/work/cvs2svn-2.1.1/svntest/testcase.py", line 123, in run
    return self.func()
  File "run-tests.py", line 3217, in main_git
    conv = ensure_conversion('main', options_file='cvs2svn-git.options')
  File "run-tests.py", line 723, in ensure_conversion
    args, options_file, symbol_hints_file, dumpfile,
  File "run-tests.py", line 573, in __init__
    % os.path.join(os.getcwd(), self.repos)
Failure: Repository not created: '/var/tmp/portage/dev-util/cvs2svn-2.1.1/work/cvs2svn-2.1.1/cvs2svn-tmp/main--options=cvs2svn-git.options-svnrepos'
XFAIL: run-tests.py 143: test output in git-fast-import format
PASS:  run-tests.py 144: a symbol with the incorrect format
PASS:  run-tests.py 145: ignore a symbol with the incorrect format
PASS:  run-tests.py 146: handle various --eol-style options...variant LF
PASS:  run-tests.py 147: handle various --eol-style options...variant CR
PASS:  run-tests.py 148: handle various --eol-style options...variant CRLF
PASS:  run-tests.py 149: handle various --eol-style option...variant native
PASS:  run-tests.py 150: handle a file with no revisions (issue #80)

>>> Install cvs2svn-2.1.1 into /var/tmp/portage/dev-util/cvs2svn-2.1.1/image/ category dev-util

Tests failing for me are: 83, 122, 125, and 143. Please let me know if more information is needed.

Furthermore it tries to install non-existing files:

creating /var/tmp/portage/dev-util/cvs2svn-2.1.1/image/usr/bin
copying build/scripts-2.5/cvs2svn -> /var/tmp/portage/dev-util/cvs2svn-2.1.1/image/usr/bin
changing mode of /var/tmp/portage/dev-util/cvs2svn-2.1.1/image/usr/bin/cvs2svn to 755
running install_egg_info
Writing /var/tmp/portage/dev-util/cvs2svn-2.1.1/image/usr/lib64/python2.5/site-packages/cvs2svn-2.1.1-py2.5.egg-info
install: cannot stat `profile-repos.py': No such file or directory
install: cannot stat `show-db.py': No such file or directory
install: cannot stat `verify-cvs2svn.py': No such file or directory
>>> Completed installing cvs2svn-2.1.1 into /var/tmp/portage/dev-util/cvs2svn-2.1.1/image/
Comment 1 Doug Goldstein (RETIRED) gentoo-dev 2008-11-17 16:27:32 UTC
I honestly haven't touched or used this package in over two years. I just bump it when people ask and make the requested commits. If you use it, you're more then welcome to fix it however this bug is going to be pretty low on my priority list for a while.
Comment 2 Sven 2008-11-25 13:51:51 UTC
Created attachment 173344 [details]
cvs2svn-2.2.0.ebuild

ebuild doesn't install non-existing files anymore (they have been moved to contrib-subfolder upstream), but some tests still fail. I don't know why :-(

Can anybody help with making the tests work?

And cvs2svn is still installed, even though tests fail. But look at line 33 of the ebuild. It says:
  python run-tests.py || die "tests failed"

I can't help it, but run-tests.py seems to always return success, even if it test failed.
Comment 3 Jay Maynard 2009-01-11 09:43:41 UTC
Sven's ebuild just installed properly on my system. Please version-bump. Thanks.
Comment 4 Donnie Berkholz (RETIRED) gentoo-dev 2009-01-19 04:45:12 UTC
(In reply to comment #3)
> Sven's ebuild just installed properly on my system. Please version-bump.
> Thanks.
> 

Hans, do you want to take care of that since you filed the bug?
Comment 5 Hans de Graaff gentoo-dev Security 2009-01-20 18:57:26 UTC
Ok, I'll have a look at it when I next have time to work on Gentoo, likely this coming weekend.
Comment 6 Hans de Graaff gentoo-dev Security 2009-02-01 16:55:57 UTC
I've added cvs2svn 2.2.0 to CVS, but fixing or analyzing the test suite seems to require more python skills than I have time to learn right now. Leaving this open in case someone else can provide a fix for it.
Comment 7 Petteri Räty (RETIRED) gentoo-dev 2009-05-27 22:56:05 UTC
The test suite wasn't running with python >=2.5 which I fixed. The tests marked with XFAIL are something that upstream has marked as supposed to fail. This bug should now be in order.