Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 24700 - new version of mad splits distribution
Summary: new version of mad splits distribution
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-17 16:34 UTC by Hod McWuff
Modified: 2003-07-19 15:58 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuilds for new version of mad (mad-0.15.0b-ebuilds.tar.bz2,3.19 KB, application/octet-stream)
2003-07-17 16:35 UTC, Hod McWuff
Details
ebuilds for new version of mad (mad-0.15.0b-ebuilds.tar.bz2,3.19 KB, application/octet-stream)
2003-07-17 16:35 UTC, Hod McWuff
Details
ebuilds for new version of mad (mad-0.15.0b-ebuilds.tar.bz2,3.19 KB, application/octet-stream)
2003-07-17 16:36 UTC, Hod McWuff
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Hod McWuff 2003-07-17 16:34:44 UTC
mad-0.15.0b is now three packages:
libid3tag-0.15.0b.tar.gz
libmad-0.15.0b.tar.gz
madplay-0.15.0b.tar.gz

these are separate ebuilds for those packages. madplay DEPEND's on the same
version of the other two, and PROVIDE's media-sound/mad... is that an error?

additionally there is a bug in alsa playback in madplay, patch provided
Comment 1 Hod McWuff 2003-07-17 16:35:45 UTC
Created attachment 14639 [details]
ebuilds for new version of mad
Comment 2 Hod McWuff 2003-07-17 16:35:58 UTC
Created attachment 14640 [details]
ebuilds for new version of mad
Comment 3 Hod McWuff 2003-07-17 16:36:01 UTC
Created attachment 14641 [details]
ebuilds for new version of mad
Comment 4 Nick Hadaway 2003-07-19 01:06:51 UTC
media-sound/mad-0.15.0b is now in portage and is a metapackage for libmad, libid3tag, and madplay.  Most packages will only depend on the libraries...
So ebuilds should still depend specifically on libmad and libid3tag instead of the more general media-sound/mad...
Comment 5 Hod McWuff 2003-07-19 02:32:35 UTC
Some issues:

econf, emake, and einstall should not be have the '|| die', as per the docs in 'man 5 ebuild' they each do their own failure checking

should not madplay explicitly $DEPEND on libmad and libid3tag, as opposed to relying on the user installing via the metabuild?

--with-gnu-ld tells configure to /assume/ a GNU ld; will it not detect its presence correctly if allowed to test it? Isn't that one of those "if it ain't broke don't fix it" things?

--with-experimental in libmad should probably be avoided; probably contact R. Leslie if you really think it ought to be deployed that way to make sure it won't do anything /too/ wacky

--enable-accuracy should probably be turned on in libmad; it a very efficient decoder anyway, I doubt anyone is listening to MP3's on a 386 these days. Better yet, is there some detection mechanism that "knows" whether it's running on a fast machine or on an antique?

--with-esd in madplay really needs to be switched by the USE variable

--with-alsa in madplay PROBABLY WON'T WORK without the patch I provided. I wrote the alsa support in madplay myself, originally against 0.14.0 if memory serves. Robert didn't test it. It didn't work on my own boxen until I located and patched some problems. IMO it's unlikely to work on anyone else's either, unless kernel 2.5.75 has major mmap bugs that i didn't bother reading about.

Comment 6 Hod McWuff 2003-07-19 15:58:05 UTC
--with-alsa and --with-esd cannot be turned on at the same time. recommend:

USE="alsa" && myconf="$myconf --with-alsa" \
           || USE="esd" && myconf="$myconf --with-esd"