Bug 246439 – pax-utils-0.1.18 fails on Gentoo/FreeBSD -- no alloca.h

• Status: RESOLVED FIXED
• Product: Gentoo/Alt

[Description Javier Villavicencio (RETIRED) 2008-11-11 22:32:53 UTC]

FreeBSD has no alloca.h which is included from porting.h. BSD's libc defines alloca() on stdlib.h. (also, glibc's stdlib.h already includes alloca.h, which is already included from porting.h fwiw)

Can it be moved down to the #if defined(__linux__) ? 

@@ -33,11 +33,11 @@
 #include <pwd.h>
 #include <fnmatch.h>
 #include <regex.h>
-#include <alloca.h>
 
 #include <sys/mman.h>
 #include "elf.h"
 #if defined(__linux__)
+# include <alloca.h>
 # include <endian.h>
 # include <byteswap.h>
 #elif defined(__FreeBSD__)

[Comment 1 SpanKY 2008-11-16 12:15:01 UTC]

looks fine ... committed, thanks

[Comment 2 Fabian Groffen 2008-11-16 20:35:51 UTC]

Please add it back for Solaris, Darwin, AIX, ...  BSD is not the only thing in this world.

[Comment 3 SpanKY 2008-11-16 20:54:55 UTC]

changed it to include for everyone but freebsd

[Comment 4 Javier Villavicencio (RETIRED) 2008-11-25 20:33:12 UTC]

*** Bug 248735 has been marked as a duplicate of this bug. ***

[Comment 5 Javier Villavicencio (RETIRED) 2008-11-25 20:52:17 UTC]

Alexis: the fix is on cvs, we may just remove the keyword for this version and wait for the next bump.

[Comment 6 Fabian Groffen 2008-11-25 20:54:25 UTC]

or grab the two revisions and apply as patch in the ebuild?

[Comment 7 Javier Villavicencio (RETIRED) 2008-11-25 21:02:51 UTC]

(In reply to comment #6)
> or grab the two revisions and apply as patch in the ebuild?
> 

Up to the maintainers. (I thought they did that o_o)

[Comment 8 SpanKY 2008-11-27 17:54:36 UTC]

ive put out a new version