Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 246138 - xchat-2.8.6 uses internal copy of sexy-spell-entry
Summary: xchat-2.8.6 uses internal copy of sexy-spell-entry
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Packages in net-irc
URL: http://bugzilla.gnome.org/show_bug.cg...
Whiteboard:
Keywords:
Depends on:
Blocks: 259442
  Show dependency tree
 
Reported: 2008-11-09 09:32 UTC by Serkan Kaba (RETIRED)
Modified: 2009-07-21 02:59 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch against 2.8.6-r1 ebuild to use external libsexy (xchat-external-libsexy.patch,944 bytes, patch)
2008-11-10 20:14 UTC, Serkan Kaba (RETIRED)
Details | Diff
Patch against 2.8.6-r1 ebuild to use external gtkspell (xchat-gtkspell.patch,946 bytes, patch)
2008-11-10 20:20 UTC, Serkan Kaba (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Serkan Kaba (RETIRED) gentoo-dev 2008-11-09 09:32:18 UTC
Xchat sources have internal copy of sexy-spell-entry.{c,h} which is part of libsexy. I think it should use external libsexy and link against it.
Comment 1 Serkan Kaba (RETIRED) gentoo-dev 2008-11-10 20:14:26 UTC
Created attachment 171353 [details, diff]
Patch against 2.8.6-r1 ebuild to use external libsexy

xchat actually has a configure option to do so, here I'm attaching a diff against 2.8.6-r1 which uses this option.
Comment 2 Serkan Kaba (RETIRED) gentoo-dev 2008-11-10 20:20:32 UTC
Created attachment 171358 [details, diff]
Patch against 2.8.6-r1 ebuild to use external gtkspell

Here's another patch that builds against gtkspell. I would perefer that since SexySpellEdit has a bug in Turkish locale.

See: http://bugzilla.gnome.org/show_bug.cgi?id=559982
Comment 3 Raúl Porcel (RETIRED) gentoo-dev 2008-11-27 20:49:46 UTC
Done on -r2, thanks.
Comment 4 Albert W. Hopkins 2008-11-28 14:50:18 UTC
The gtkspell version leaves a significant amount of vertical space below the text in the entry box (using Monospace font).  This doesn't happen with the buit-in version.  Is there any way to prevent this?
Comment 5 reisio 2008-12-13 11:02:25 UTC
(In reply to comment #4)
> The gtkspell version leaves a significant amount of vertical space below the
> text in the entry box (using Monospace font).  This doesn't happen with the
> buit-in version.  Is there any way to prevent this?
> 

Indeed, it looks FUBAR.  I downgraded to -r1.
Comment 6 reisio 2009-02-25 04:16:12 UTC
^ Still broken ^
Comment 7 Hans de Graaff gentoo-dev Security 2009-04-08 05:47:29 UTC
I'm seeing this as well, would be nice to get this regression fixed.
Comment 8 Serkan Kaba (RETIRED) gentoo-dev 2009-04-08 06:16:53 UTC
(In reply to comment #7)
> I'm seeing this as well, would be nice to get this regression fixed.
> 

Can you test  if you can reproduce the suggestion issue with any other non-ascii characters. In any case, this still depends on upstream issue to be resolved.
Comment 9 Hans de Graaff gentoo-dev Security 2009-04-08 06:34:18 UTC
(In reply to comment #8)

> Can you test  if you can reproduce the suggestion issue with any other
> non-ascii characters. In any case, this still depends on upstream issue to be
> resolved.

Sorry, I was not talking about the suggestion issue, but about the much larger input line as mentioned in comment 4.

Comment 10 Serkan Kaba (RETIRED) gentoo-dev 2009-04-08 06:42:20 UTC
(In reply to comment #9)
> Sorry, I was not talking about the suggestion issue, but about the much larger
> input line as mentioned in comment 4.
> 

But the only other option is using SexySpellEntry which is *borked* (See the upstream bug)
Comment 11 Hans de Graaff gentoo-dev Security 2009-04-13 13:37:44 UTC
(In reply to comment #10)

> But the only other option is using SexySpellEntry which is *borked* (See the
> upstream bug)

In which case it seems to me that the proper option is to fix the UI as well when using gtkspell as the preferred spelling widget.

Comment 12 Eric Womer 2009-04-27 02:09:19 UTC
Why do that, thats what breaks spell check support in xchat.

to get spell check back working in xchat build with enchant statically linked 
and have enchant built eith the aspell use flag 
Comment 13 Eric Womer 2009-04-27 02:37:05 UTC
(In reply to comment #12)
> Why do that, thats what breaks spell check support in xchat.
> 
> to get spell check back working in xchat build with enchant statically linked 
> and have enchant built eith the aspell use flag 
> 

i was wrong all you need is enchant built with aspell use flag
Comment 14 Serkan Kaba (RETIRED) gentoo-dev 2009-04-27 03:47:43 UTC
(In reply to comment #13)
> (In reply to comment #12)
> > Why do that, thats what breaks spell check support in xchat.
> > 
> > to get spell check back working in xchat build with enchant statically linked 
> > and have enchant built eith the aspell use flag 
> > 
> 
> i was wrong all you need is enchant built with aspell use flag
> 
I don't get what you mean, the problem is with the widget not enchant.
Comment 15 Serkan Kaba (RETIRED) gentoo-dev 2009-07-21 02:59:10 UTC
I don't think upstream will respond to bug in time. Resolving as UPSTREAM