Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 245749 - sys-boot/unetbootin-304 ebuild request
Summary: sys-boot/unetbootin-304 ebuild request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Jeroen Roovers (RETIRED)
URL: http://unetbootin.sourceforge.net/
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-05 20:29 UTC by Yarda
Modified: 2009-01-09 14:28 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
unetbootin-295 ebuild (unetbootin-295.ebuild,692 bytes, text/plain)
2008-11-05 20:30 UTC, Yarda
Details
unetbootin ebuild (unetbootin-295.ebuild,683 bytes, text/plain)
2008-11-05 23:28 UTC, Yarda
Details
unetbootin-301 ebuild (unetbootin-301.ebuild,910 bytes, text/plain)
2008-12-01 09:37 UTC, Markos Chandras (RETIRED)
Details
fixed unetbootin-301 ebuild (unetbootin-301.ebuild,841 bytes, text/plain)
2008-12-01 13:42 UTC, Markos Chandras (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yarda 2008-11-05 20:29:10 UTC
Universal Netboot Installer is a cross-platform utility that can create Live USB systems and can load a variety of system utilities or install various Linux distributions and other operating systems without a CD.


Reproducible: Always
Comment 1 Yarda 2008-11-05 20:30:18 UTC
Created attachment 170843 [details]
unetbootin-295 ebuild
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2008-11-05 20:37:54 UTC
Comment on attachment 170843 [details]
unetbootin-295 ebuild

>KEYWORDS="~alpha ~amd64 ~hppa ~ia64 ~ppc ~ppc64 ~sparc ~x86 ~x86-fbsd"

Only add arch keywords for arches you have tested on.

>S="${WORKDIR}"

That's the default so it shouldn't be set.

>RDEPEND=">=x11-libs/qt-4.2.0
>         sys-apps/sed
>         sys-fs/mtools"
>DEPEND="${RDEPEND}"

What is sed used for?

>src_compile() {
>	sh ./INSTALL || die "compile failed!"
>}

Ew, it uses something called INSTALL to compile? Or should this be moved to src_install()?
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2008-11-05 20:41:08 UTC
(In reply to comment #2)
> >S="${WORKDIR}"
> 
> That's the default so it shouldn't be set.

Sorry, I was wrong there.
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2008-11-05 20:42:32 UTC
(In reply to comment #2)
> >RDEPEND=">=x11-libs/qt-4.2.0

Oh, and the ebuild should probably depend on split Qt 4. :)
Comment 5 Yarda 2008-11-05 23:28:39 UTC
Created attachment 170866 [details]
unetbootin ebuild

> What is sed used for?
sed is used inside something called INSTALL :).

> Ew, it uses something called INSTALL to compile? Or should this be moved to
> src_install()?
Something called INSTALL is used only for compile - upstream logic :)  

> Oh, and the ebuild should probably depend on split Qt 4. :)
Doing my best, but still not sure, if it is enough.
Comment 6 Markos Chandras (RETIRED) gentoo-dev 2008-12-01 09:37:10 UTC
Created attachment 173940 [details]
unetbootin-301 ebuild
Comment 7 Markos Chandras (RETIRED) gentoo-dev 2008-12-01 09:38:02 UTC
I will post the ebuild for review on sunrise overlay and then commit it if possible

Thanks for this package 
Comment 8 Markos Chandras (RETIRED) gentoo-dev 2008-12-01 13:42:12 UTC
Added on sunrise overlay

Please update 

Status Whiteboard: [sunrise-overlay]
Keywords: EBUILD, InOverlay

Thanks
Comment 9 Markos Chandras (RETIRED) gentoo-dev 2008-12-01 13:42:46 UTC
Created attachment 173965 [details]
fixed unetbootin-301 ebuild
Comment 10 Jeroen Roovers (RETIRED) gentoo-dev 2009-01-08 18:12:58 UTC
304 is in the tree.