If a target file is read only patch tries to determine the presence of a version control system, such as Perforce. If it detects one, it will ask if a lock on the file should be acquired. This doesn't work very well with automated builds, both OpenOffice and cdrtools failed for me because I have Perforce installed. Reproducible: Always Steps to Reproduce: 1. Install versioning system supported by patch, according to man patch: RCS, ClearCase, Perforce and SCCS 2. Patch a read-only file 3. Actual Results: Get file something.txt from Perforce with lock? [y] n Expected Results: It might be a good idea to add the -g0 argument by default to patch, in portage. This should make patch ignore any detected versioning systems.
Created attachment 17139 [details, diff] adds flag to ignore version control system. Here is a rather trivial patch that does just that.
---------------------------------------------- -EPATCH_OPTS="" +EPATCH_OPTS="-g0" This looks like a pretty safe change to add to the eutils.eclass I'm testing here local to ensure no problems will be encounted. ---------------------------------------------- This is from the manpage for version patch-2.5.9 -g num or --get=num This option controls patch's actions when a file is under RCS or SCCS control, and does not exist or is read-only and matches the default version, or when a file is under ClearCase or Perforce con- trol and does not exist. If num is positive, patch gets (or checks out) the file from the revision control system; if zero, patch ignores RCS, ClearCase, Perforce, and SCCS and does not get the file; and if negative, patch asks the user whether to get the file. The default value of this option is given by the value of the PATCH_GET environment variable if it is set; if not, the default value is zero if patch is conforming to POSIX, negative otherwise.
I've just compiled USE="-*" emerge system from a stage2 with no problems with this patch.
committed change to eutils.eclass rev-1.55
sounds good
*** Bug 30515 has been marked as a duplicate of this bug. ***
