Bug 24561 – gs-sources-2.4.22-pre2 does not compile with thinkpad support enabled

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Mark Renouf 2003-07-15 20:06:13 UTC]

compiler errors in drivers/char/thinkpad:

drivers/char/thinkpad/rtcmosram.c
drivers/char/thinkpad/smapi_core.c
drivers/char/thinkpad/superio.c
drivers/char/thinkpad/thinkpad.c
drivers/char/thinkpad/thinkpadpm.c

Reproducible: Always
Steps to Reproduce:
1. emerge gs-sources (currently linux-2.4.22-pre2)
2. configure with thinkpad support 
  (Processor type and features/IBM Thinkpad support -- CONFIG_THINKPAD)
3. make dep && make bzImage

Actual Results:  
BUILD_BASENAME=thinkpad -c -o thinkpad.o thinkpad.c
thinkpad.c:105:41: missing binary operator before '('
make[4]: *** [thinkpad.o] Error 1

Expected Results:  
compile without errors

[Comment 1 Mark Renouf 2003-07-15 20:08:12 UTC]

Created attachment 14531 [details, diff]
patch to build cleanly

Turns out the source files listed above are all missing:
#include <linux/version.h>

Adding this include fixes the issue... this patch does that. I'm not sure if
this is a problem with the patches to the kernel tree or the original source or
both.

[Comment 2 Mark Renouf 2003-07-15 20:11:36 UTC]

set version 1.4rc4

[Comment 3 Mark Renouf 2003-07-15 20:32:23 UTC]

Comment on attachment 14531 [details, diff]
patch to build cleanly

diff -u drivers/char/thinkpad/rtcmosram.c.orig
drivers/char/thinkpad/rtcmosram.c
--- drivers/char/thinkpad/rtcmosram.c.orig	2003-07-15 18:12:25.000000000
-0400
+++ drivers/char/thinkpad/rtcmosram.c	2003-07-15 18:22:24.000000000 -0400
@@ -31,6 +31,7 @@

 #include <linux/kernel.h>
 #include <linux/module.h>
+#include <linux/version.h>
 #include <linux/init.h>
 #include <linux/ioport.h>
 #include <linux/proc_fs.h>
diff -u drivers/char/thinkpad/smapi_core.c.orig
drivers/char/thinkpad/smapi_core.c
--- drivers/char/thinkpad/smapi_core.c.orig	2003-07-15 18:12:25.000000000
-0400
+++ drivers/char/thinkpad/smapi_core.c	2003-07-15 18:17:11.000000000 -0400
@@ -31,6 +31,7 @@

 #include <linux/kernel.h>
 #include <linux/module.h>
+#include <linux/version.h>
 #include <linux/init.h>
 #include <linux/proc_fs.h>
 #include <linux/devfs_fs_kernel.h>
diff -u drivers/char/thinkpad/superio.c.orig drivers/char/thinkpad/superio.c
--- drivers/char/thinkpad/superio.c.orig	2003-07-15 18:12:25.000000000
-0400
+++ drivers/char/thinkpad/superio.c	2003-07-15 18:17:28.000000000 -0400
@@ -32,6 +32,7 @@

 #include <linux/kernel.h>
 #include <linux/module.h>
+#include <linux/version.h>
 #include <linux/init.h>
 #include <linux/ioport.h>
 #include <linux/proc_fs.h>
diff -u drivers/char/thinkpad/thinkpad.c.orig drivers/char/thinkpad/thinkpad.c
--- drivers/char/thinkpad/thinkpad.c.orig	2003-07-15 18:12:25.000000000
-0400
+++ drivers/char/thinkpad/thinkpad.c	2003-07-15 18:17:47.000000000 -0400
@@ -41,6 +41,7 @@
 #include "thinkpad_driver.h"

 #include <linux/module.h>
+#include <linux/version.h>
 #include <linux/kmod.h>
 #include <linux/kernel.h>
 #include <linux/init.h>
diff -u drivers/char/thinkpad/thinkpadpm.c.orig
drivers/char/thinkpad/thinkpadpm.c
--- drivers/char/thinkpad/thinkpadpm.c.orig	2003-07-15 18:12:25.000000000
-0400
+++ drivers/char/thinkpad/thinkpadpm.c	2003-07-15 18:18:04.000000000 -0400
@@ -32,6 +32,7 @@

 #include <linux/kernel.h>
 #include <linux/module.h>
+#include <linux/version.h>
 #include <linux/init.h>
 #include <linux/proc_fs.h>
 #include <linux/devfs_fs_kernel.h>

[Comment 4 Mark Renouf 2003-07-15 20:33:40 UTC]

argh... ignore me... I'm new at this ;-)

[Comment 5 Bob Johnson (RETIRED) 2004-01-20 16:52:38 UTC]

reopen if new sources dont fix this