Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 24472 - xmms-1.2.7-r22 Fails to build
Summary: xmms-1.2.7-r22 Fails to build
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: High blocker (vote)
Assignee: Seemant Kulleen (RETIRED)
URL:
Whiteboard:
Keywords:
: 24708 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-07-14 13:00 UTC by Lisa Seelye (RETIRED)
Modified: 2003-07-18 09:44 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
xmms-fix.diff (A patch that fixes xmms) (xmms-fix.diff,1.34 KB, patch)
2003-07-16 06:23 UTC, Paul de Vrieze (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lisa Seelye (RETIRED) gentoo-dev 2003-07-14 13:00:25 UTC
Making all in po
make[2]: Entering directory `/var/tmp/portage/xmms-1.2.7-r22/work/xmms-1.2.7/po'
PATH=../src:$PATH /usr/bin/xgettext --default-domain=xmms --directory=.. \
  --add-comments --keyword=_ --keyword=N_ \
  --files-from=./POTFILES.in \
&& test ! -f xmms.po \
   || ( rm -f ./xmms.pot \
        && mv xmms.po ./xmms.pot )
/usr/bin/xgettext: Non-ASCII string at Input/tonegen/tonegen.c:50.
Please specify the source encoding through --from-code.
mv: cannot stat `xmms.po': No such file or directory
make[2]: *** [xmms.pot] Error 1
make[2]: Leaving directory `/var/tmp/portage/xmms-1.2.7-r22/work/xmms-1.2.7/po'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/xmms-1.2.7-r22/work/xmms-1.2.7'
make: *** [all-recursive-am] Error 2

!!! ERROR: media-sound/xmms-1.2.7-r22 failed.
!!! Function src_compile, Line 126, Exitcode 2
!!! (no error message



+++++++++++

Portage 2.0.48-r1 (default-x86-1.4, gcc-3.2.3, glibc-2.3.2-r1)
=================================================================
System uname: 2.4.20-openmosix-r6 i686 AMD Athlon(tm) Processor
GENTOO_MIRRORS="http://ftp.belnet.be/mirror/rsync.gentoo.org/gentoo/ ftp://ftp.
ussg.iu.edu/pub/linux/gentoo ftp://ftp.gtlib.cc.gatech.edu/pub/gentoo http:
//adelie.polymtl.ca/ ftp://cs.ubishops.ca/pub/gentoo"
CONFIG_PROTECT="/etc /var/qmail/control /usr/share/config 
/usr/kde/2/share/config /usr/kde/3/share/config /usr/X11R6/lib/X11/xkb"
CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d"
PORTDIR="/usr/portage"
DISTDIR="/usr/portage/distfiles"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR_OVERLAY=""
USE="x86 oss apm libg++ libwww mad mikmod nls pdflib quicktime gtkhtml gdbm 
berkdb slang readline bonobo guile sdl gpm ssl python imlib motif -arts 3dnow 
aalib acl avi cdr crypt cups curl dga directfb doc dvd encode alsa -esd ethereal 
evo flash freetds gd gif gnome gphoto2 gtk ipv6 jpeg -kde -java lcms maildir 
mbox memlimit mmx mpeg -mozilla mysql ncurses oggvorbis opengl pam pda -pcmcia 
perl png qt samba sasl spell svga truetype tcpd tcltk X xml xml2 xmms xv zlib"
COMPILER="gcc3"
CHOST="i686-pc-linux-gnu"
CFLAGS="-mcpu=athlon -O3 -pipe"
CXXFLAGS="-mcpu=athlon -O3 -pipe"
ACCEPT_KEYWORDS="x86 ~x86"
MAKEOPTS="-j4"
AUTOCLEAN="yes"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
FEATURES="sandbox ccache userpriv usersandbox distcc"
Comment 1 foser (RETIRED) gentoo-dev 2003-07-14 15:40:35 UTC
not a gnome bug
Comment 2 Brad Laue (RETIRED) gentoo-dev 2003-07-15 10:27:57 UTC
Confirmed. This is happening because of gettext 0.12.x I think.
Comment 3 Alvaro Figueroa (RETIRED) gentoo-dev 2003-07-15 10:29:55 UTC
As the message says, there are a some caracters that xgettext doens't like that mutch. It happens on Input/tonegen/tonegen.c (line 50), Input/vorbis/vorbis.c (line 610) and in xmms/about.c on several ocations.

The thing is that --from-code=iso-8859-1 should be added.

I think that a --language=C would be apropiate, since I _think_ that xgettext is trying to get into C comments as well, but this las comment can be safely ignored :).
Comment 4 Alvaro Figueroa (RETIRED) gentoo-dev 2003-07-15 10:40:25 UTC
I'm so sorry. Didn't made myself clear about this :). That argument should be added to xgettext like:

PATH=../src:$PATH /usr/bin/xgettext --default-domain=xmms --directory=..   --add-comments --keyword=_ --keyword=N_   --files-from=./POTFILES.in --language=C --from-code=iso-8859-1
Comment 5 Raimar Sandner 2003-07-15 18:23:26 UTC
Doesn't help. I edited po/Makefile for xgettext to use --language=C and --from-code=iso8859-1, still the same error.

make[2]: Entering directory `/tmp/portage/xmms-1.2.7-r22/work/xmms-1.2.7/po'
PATH=../src:$PATH /usr/bin/xgettext --default-domain=xmms --directory=.. \
  --add-comments --keyword=_ --keyword=N_ \
  --files-from=./POTFILES.in --language=C --from-code=iso8859-1 \
&& test ! -f xmms.po \
   || ( rm -f ./xmms.pot \
        && mv xmms.po ./xmms.pot )
/usr/bin/xgettext: Non-ASCII string at Input/tonegen/tonegen.c:50.
Please specify the source encoding through --from-code.
mv: cannot stat `xmms.po': No such file or directory
make[2]: *** [xmms.pot] Error 1
make[2]: Leaving directory `/tmp/portage/xmms-1.2.7-r22/work/xmms-1.2.7/po'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/tmp/portage/xmms-1.2.7-r22/work/xmms-1.2.7'
make: *** [all-recursive-am] Error 2
Comment 6 Paul de Vrieze (RETIRED) gentoo-dev 2003-07-16 05:12:44 UTC
You set the input to iso8859-1 while it should be iso-8859-1 (note the extra dash)
Comment 7 Paul Slinski 2003-07-16 06:05:33 UTC
Adding --language=C and --from-code=iso-8859-1 to the po/Makefile fixes this problem.

(Quick fix for users)
tar xvzf /usr/portage/distfiles/xmms-1.2.7.tar.gz
nano xmms-1.2.7/po/Makefile.in.in

Change line 88 from:
$(XGETTEXT) --default-domain=$(PACKAGE) --directory=$(top_srcdir) \
to
 $(XGETTEXT) --default-domain=$(PACKAGE) --directory=$(top_srcdir) --language=C --from-code=iso-8859-1 \

Tar it back up:
tar cvzf xmms-1.2.7.tar.gz xmms-1.2.7/
mv xmms-1.2.7.tar.gz /usr/portage/distfiles/
ebuild /usr/portage/media-sound/xmms/xmms-1.2.7-r22.ebuild digest
emerge xmms
be happy

-P
Comment 8 Paul de Vrieze (RETIRED) gentoo-dev 2003-07-16 06:23:20 UTC
Created attachment 14540 [details, diff]
xmms-fix.diff (A patch that fixes xmms)

I've added a patch that should fix things when applied in
/usr/portage/media-sound/xmms (or the cvs location). It basic does what is
suggested here.
Comment 9 Brad Laue (RETIRED) gentoo-dev 2003-07-16 07:58:12 UTC
Isn't there an environment variable that can be set? LANG or something similar. Would that have the same effect, or is that a different case?
Comment 10 Paul de Vrieze (RETIRED) gentoo-dev 2003-07-16 08:27:29 UTC
According to the xgettext manual and info pages there is no such environment variable. This option specifies the input encoding, making it depend on the local locale might be counterproductive.
Comment 11 Seemant Kulleen (RETIRED) gentoo-dev 2003-07-18 01:00:53 UTC
*** Bug 24708 has been marked as a duplicate of this bug. ***
Comment 12 Seemant Kulleen (RETIRED) gentoo-dev 2003-07-18 01:24:05 UTC
I don't intend to offend -- it's just that I added a patch to add /usr/local/share/xmms/Skins to the skins search path and was pointed to this bug, for which pauldv provided a patch above.  Thinking to kill 2 birds with one stone, I reassigned this bug to myself, in order to close it.
Comment 13 Seemant Kulleen (RETIRED) gentoo-dev 2003-07-18 01:25:30 UTC
-r23 in portage.
Comment 14 Jan Schubert 2003-07-18 05:28:15 UTC
The bug is _not_ fixed (for me) in -r23! 
Comment 15 Seemant Kulleen (RETIRED) gentoo-dev 2003-07-18 05:39:05 UTC
initially wasn't -- rsync again and try please
Comment 16 Jan Schubert 2003-07-18 06:00:53 UTC
According to the gentoo-Netiquette i'm not allowed to rsync more than one time a day :-). 
 
So, why is it not called -r24? 
Comment 17 Seemant Kulleen (RETIRED) gentoo-dev 2003-07-18 06:11:43 UTC
why should it be called -r24?

(yeah, I know about netiquette, but please do it anyway this time)
Comment 18 Jan Schubert 2003-07-18 06:21:43 UTC
'cause you obviousally changed something (without renaming) 
Comment 19 Seemant Kulleen (RETIRED) gentoo-dev 2003-07-18 06:45:29 UTC
it wasn't a change to add anything -- it was a change to fix something  -- a fix, which affects only some of the users, not all
Comment 20 Seemant Kulleen (RETIRED) gentoo-dev 2003-07-18 07:32:28 UTC
is -r23 failing for everybody?
Comment 21 Lisa Seelye (RETIRED) gentoo-dev 2003-07-18 07:43:02 UTC
No. -r23 works for me, just fine.  I'm on ~x86.
Comment 22 Jan Schubert 2003-07-18 09:30:07 UTC
r23-r2 seems also working for me 
Comment 23 Seemant Kulleen (RETIRED) gentoo-dev 2003-07-18 09:44:51 UTC
closing again.