Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 244018 - PPC/PPC64-specific ps3 USE flag unmasked on all architectures
Summary: PPC/PPC64-specific ps3 USE flag unmasked on all architectures
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High minor (vote)
Assignee: ppc64 architecture team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-24 18:33 UTC by James Ausmus
Modified: 2009-11-10 01:41 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description James Ausmus 2008-10-24 18:33:26 UTC
The wpa_supplicant Makefile assumes that you have a 64-bit output capable compiler if you have the ps3 use flag set. If you just have a 32-bit compiler, then the build will fail, as -m64 is appended to the CFLAGS and LDFLAGS, causing a:

config.c:1: sorry, unimplemented: 64-bit mode not compiled in                                                                                                                                                 
../src/utils/common.c:1: sorry, unimplemented: 64-bit mode not compiled in                                                                                                                                    
../src/utils/wpa_debug.c:1: sorry, unimplemented: 64-bit mode not compiled in                                                                                                                                 

set of errors to be generated.

Reproducible: Always

Steps to Reproduce:
1. Build standard x86 (32-bit) Gentoo system, with no 64-bit cross-compile capability
2. USE="ps3" emerge wpa_supplicant
3. Watch the b0rkage...
Comment 1 Mike Auty (RETIRED) gentoo-dev 2008-10-25 12:50:07 UTC
The description for the ps3 USE flag is as follows (quse -D ps3):

local:ps3:net-wireless/wpa_supplicant: Add support for ps3 hypervisor driven gelic wifi

Under what circumstances would you expect that to work on an x86 machine without the ps3 hypervisor running?  If you were attempting to cross-compile for a PS3, you'd still need an appropriate compiler installed.

Given that this is the only use of the ps3 flag, I'm going to mark this as INVALID, since if the user isn't willing to read the description for a USE flag to figure out what it will do, they probably won't read any warning telling them not to set it when they're not on a PS3.

If you really want to push for a warning to be added, do please reopen this bug and we'll assign it properly...
Comment 2 James Ausmus 2008-10-27 18:35:43 UTC
Reopening, as I think that the real solution to this is a use.mask entry under the x86 profile that masks out the ps3 USE flag - since, unless you really know what you're doing (in which case you should also know how to unmask USE flags), all this does is create breakage on x86-32...
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2008-10-27 18:59:12 UTC
It doesn't "create breakage" IMO. All that happens is you setting a USE flag you shouldn't be setting and then seeing the build fail. The only thing that would be broken is your configuration. :)
Comment 4 James Ausmus 2008-10-27 19:05:24 UTC
Fair enough. :)

It would, however, make sense to use.mask ps3 out for x86 - it's established practice to do this with other use flags that don't apply to a particular platform (such as ppcsha1, aqua, coreaudio, etc.).
Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2008-10-28 17:04:15 UTC
That would be a package.mask in the base profile and an unmask in the ppc64 profiles, I reckon.
Comment 6 Ian Leonard 2008-12-16 03:52:32 UTC
(In reply to comment #5)
> That would be a package.mask in the base profile and an unmask in the ppc64
> profiles, I reckon.
> 

ppc users would need to be unmasked as well, for those running a 32bit ul. I'm not sure of the logic necessary for the ebuild to run the cross compiler.
Comment 7 Ian Leonard 2008-12-22 08:02:30 UTC
(In reply to comment #6)
> ppc users would need to be unmasked as well, for those running a 32bit ul. I'm
> not sure of the logic necessary for the ebuild to run the cross compiler.
> 

Digging deeper, the gelic wireless driver has been included in the mainline kernel since 2.6.27. Adding a note should suffice for ppc users.
Comment 8 Christian Faulhammer (RETIRED) gentoo-dev 2009-07-21 13:38:08 UTC
Is it ok to mask the ps3 USE flag so we can resolve this bug?
Comment 9 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-11-07 17:15:11 UTC
There's another ps3 USE flag with a ppc64-specific dependency in libsdl now.

Can we get this bloody USE flag masked? Thank-you, your local QA goon.
Comment 10 SpanKY gentoo-dev 2009-11-07 21:08:50 UTC
yes, i did the libsdl because i was lazy and didnt want to fix all the profiles when they should have all been fixed in the first place

then again, i also didnt do it because it's conceivable (although probably doesnt exist today) that there would be optional PS3 support in an app unrelated to the arch ...
Comment 11 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-11-07 21:12:18 UTC
That's why we got package.use.mask (which unmasks as well as mask).
Comment 12 Christian Faulhammer (RETIRED) gentoo-dev 2009-11-10 01:41:40 UTC
I masked the ps3 USE flag now in profiles/base and unmasked it in profiles/arch/powerpc/ppc64.