Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 24334 - Error on commonc++ or his patch
Summary: Error on commonc++ or his patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Low major
Assignee: Michael M Nazaroff (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-12 05:58 UTC by Andrea Cervesato
Modified: 2003-10-28 05:07 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrea Cervesato 2003-07-12 05:58:08 UTC 
# emerge -u world
Calculating world dependencies ...done!
>>> emerge (1 of 3) dev-libs/commonc++-1.9.7-r3 to /
>>> md5 src_uri ;-) commonc++-1.9.7.tar.gz
>>> md5 src_uri ;-) commonc++_1.9.7-1.diff.gz
>>> Unpacking source...
>>> Unpacking commonc++-1.9.7.tar.gz to /var/tmp/portage/commonc++-1.9.7-r3/work
>>> Unpacking commonc++_1.9.7-1.diff.gz to /var/tmp/portage/commonc++-1.9.7-r3/work
 * Applying commmonc++-0.1.patch...                                       [ ok ]

!!! ERROR: dev-libs/commonc++-1.9.7-r3 failed.
!!! Function src_unpack, Line 25, Exitcode 1
!!! patch2 failed
Comment 1 Andrea Cervesato 2003-07-12 05:58:26 UTC 
 # emerge -u world
Calculating world dependencies ...done!
>>> emerge (1 of 3) dev-libs/commonc++-1.9.7-r3 to /
>>> md5 src_uri ;-) commonc++-1.9.7.tar.gz
>>> md5 src_uri ;-) commonc++_1.9.7-1.diff.gz
>>> Unpacking source...
>>> Unpacking commonc++-1.9.7.tar.gz to /var/tmp/portage/commonc++-1.9.7-r3/work
>>> Unpacking commonc++_1.9.7-1.diff.gz to /var/tmp/portage/commonc++-1.9.7-r3/work
 * Applying commmonc++-0.1.patch...                                       [ ok ]

!!! ERROR: dev-libs/commonc++-1.9.7-r3 failed.
!!! Function src_unpack, Line 25, Exitcode 1
!!! patch2 failed
Comment 2 Arnaud Burlet 2003-07-24 17:08:41 UTC 
ebuild is bad : 
at line 25 of /usr/portage/dev-libs/commonc++/commonc++-1.9.7-r3.ebuild change 
use ppc && epatch ${DISTDIR}/commonc++_1.9.7-1.diff.gz || die "patch2 failed" 
into  
use ppc && (epatch ${DISTDIR}/commonc++_1.9.7-1.diff.gz || die "patch2 failed") 
 
watch the () ! 
 
and it'll build fine 
 
new --> confirmed and --> resolved once ebuild is fixed
Comment 3 Doug Lacy 2003-07-30 19:55:02 UTC 
The "fix" from Arnaud Burlet worked for me as well.
Comment 4 Tim Finley 2003-08-05 20:54:15 UTC 
Yup, good for me too.
Comment 5 John Davis (zhen) (RETIRED) gentoo-dev 2003-08-18 21:21:59 UTC 
wrong category
Comment 6 Brandy Westcott (RETIRED) gentoo-dev 2003-09-24 06:49:55 UTC 
I think it's better to use something like: 
 
 
  if [ `use ppc` ] ; then 
     epatch ${DISTDIR}/commonc++_1.9.7-1.diff.gz || die "patch2 failed" 
  fi 
 
 
Using "( )" is bad since it makes the die command redundant. This means 
that if the patch ever fails then emerge will not stop. 
After setting things up so the patch would fail: 
 
 
	* Applying commmonc++-0.1.patch...                      [ ok ] 
 
	* Cannot find $EPATCH_SOURCE!  Value for $EPATCH_SOURCE is: 
	* 
	*   /usr/portage/distfiles/Qcommonc++_1.9.7-1.diff.gz 
 
	!!! ERROR: dev-libs/commonc++-1.9.7-r3 failed. 
	!!! Function epatch, Line 214, Exitcode 0 
	!!! Cannot find $EPATCH_SOURCE! 
 
	>>> Source unpacked. 
	creating cache ./config.cache 
	checking host system type... i686-pc-linux-gnu 
	checking target system type... i686-pc-linux-gnu 
	.....
Comment 7 Martin Holzer (RETIRED) gentoo-dev 2003-10-28 05:07:47 UTC 
in cvs