Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 24327 - bug fix and enhancement for lambdamoo
Summary: bug fix and enhancement for lambdamoo
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-11 23:48 UTC by Simon Koch
Modified: 2003-07-12 15:29 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
removes "autoconf" to fix crypt() behavior and adds step to enable outbound connections (lambdamoo-1.8.1.patch,287 bytes, patch)
2003-07-11 23:52 UTC, Simon Koch
Details | Diff
patches the source to enable outbound connections. Belongs in files/ (enable_outbound.diff,451 bytes, text/x-diff)
2003-07-11 23:54 UTC, Simon Koch
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Koch 2003-07-11 23:48:28 UTC
The lambdamoo ebuild I authored was recently accepted into the tree.  One of the tweaks to 
the ebuild seems to have broken crypt() such that it uses cleartext instead of actually 
encrypting the string.  This is disastrous for passwords, to say the least.  Specifically, it's the 
"autoconf" in src_unpack() that is the culprit.  It compiles fine for me with it commented out, 
and crypt() then works as expected.  What is the rationale behind having the "autoconf" there? 
 
Additionally, I've added a patch that enables outgoing networks conenctions so that new players 
can be emailed their password.  This requires care in the database, though, to prevent abuse. 
 
I will attach a diff for the ebuild as well as the patch file it should apply.
Comment 1 Simon Koch 2003-07-11 23:52:16 UTC
Created attachment 14400 [details, diff]
removes "autoconf" to fix crypt() behavior and adds step to enable outbound connections
Comment 2 Simon Koch 2003-07-11 23:54:36 UTC
Created attachment 14401 [details]
patches the source to enable outbound connections.  Belongs in files/
Comment 3 Simon Koch 2003-07-11 23:55:38 UTC
By the way, the bug for the original submission of the ebuild is 14312. 
Comment 4 SpanKY gentoo-dev 2003-07-12 00:29:44 UTC
the reason for the autoconf is because the configure script was generated by a very 
*old* version of autoconf ... ive never seen this thing happen before, but my fault for 
not checking it out more 
 
added your changes to cvs, 1.8.1-r1 now exists 
Comment 5 Simon Koch 2003-07-12 11:29:28 UTC
I just tried this replacement configure.in, and it seems to work fine.  I ran autoconf on 
it and built.  crypt() works as expected.  It's old, but not quite as old as the one in the 
tarball.  Would it be better to drop this in and run autoconf before compiling? 
 
http://sourceforge.net/tracker/index.php?func=detail&aid=429134&group_id=3692&atid=303692 
Comment 6 SpanKY gentoo-dev 2003-07-12 15:29:15 UTC
the package installs to the correct locations right now so i'd say lets not worry 
about it ;) 
 
the packages works off of 1 binary (/usr/bin) and 1 database file (we tell 
lambdamoo where it is anyways) 
 
so unless it breaks on someone's box lets just leave as is, thanks for the link 
though :)