Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 24317 - [PATCH] enhancement + corner case bugfix for rc-update
Summary: [PATCH] enhancement + corner case bugfix for rc-update
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Martin Schlemmer (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-11 16:18 UTC by Antonio Dolcetta
Modified: 2003-07-16 11:30 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
rc-update patch (rc-update.diff,1.22 KB, patch)
2003-07-11 16:19 UTC, Antonio Dolcetta
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Dolcetta 2003-07-11 16:18:37 UTC
please review the attached patch

I kept getting annoyed by rc-update because I instinctivley type
"rc-update delete foo" instead of "rc-update del foo"
so i extended it to accept delete and -d as aliases for del
(i also added -a as an alias for add)
while extending I also found what looks like a bug in line 81 of the current
version.
It causes rc-update to print things like:
"failed to add default to default." when it failes to make a symlink from the
script in /etc/init.d to the runlevel directory



Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Antonio Dolcetta 2003-07-11 16:19:34 UTC
Created attachment 14396 [details, diff]
rc-update patch
Comment 2 Martin Schlemmer (RETIRED) gentoo-dev 2003-07-16 10:58:42 UTC
Looks ok.  I do not however see where your patch address the bug ?  Anyhow,
applied to cvs, thanks.
Comment 3 Antonio Dolcetta 2003-07-16 11:30:27 UTC
IIRC it's in this part here:

-			eerror "$0: failed to add $1 to ${x}."
+			eerror "$0: failed to add ${myscript} to ${x}."

when that line gets called $1 has been shifted into ${myscript} so $1 is actually = ${x}