When I restart preload I get: * Please use 'svc_stop; svc_start' and not 'stop; start' to * restart the service in its custom 'restart()' function. * Run preload without arguments for more info. * Stopping preload ... [ ok ] * Starting preload ... [ ok ] Seems that the function in init.d file is the following: restart() { ebegin "Reloading config for preload" killall -SIGHUP /usr/sbin/preload eend $? } But I don't know why this seems to be not recommended and it should look something like (I HAVEN'T TRIED IT YET): restart() { ebegin "Reloading config for preload" svc_stop svc_start eend $? } Regards Reproducible: Always
Maybe we should just remove the whole restart() function? I removed it locally and it seems to work just as well. To be honest, I don't see any errors the way it is now either. (And I don't know what svc_start/stop is)
Additionally, I can't decide if bug 242442 is blocking this one or not.
(In reply to comment #2) > Additionally, I can't decide if bug 242442 is blocking this one or not. > Bah, s/242442/241884/ Bug 241884, is the bug I meant to reference.
I get this message in all machines I have tried, seems that it comes from runscript.sh: # Simple way to try and detect if the service use svc_{start,stop} # to restart if it have a custom restart() funtion. if [[ -n $(egrep '^[[:space:]]*restart[[:space:]]*()' "/etc/init.d/${SVCNAME}") ]] ; then if [[ -z $(egrep 'svc_stop' "/etc/init.d/${SVCNAME}") || \ -z $(egrep 'svc_start' "/etc/init.d/${SVCNAME}") ]] ; then echo ewarn "Please use 'svc_stop; svc_start' and not 'stop; start' to" ewarn "restart the service in its custom 'restart()' function." ewarn "Run ${SVCNAME} without arguments for more info." echo if ! service_stopped "${SVCNAME}" ; then svc_stop || return "$?" fi svc_start else restart fi else restart fi But I have no idea about if it's blocking or not 241884, sorry (I am still using stable baselayout and I don't have openrc)
hmm, I just put init changes in for -r3 but stable portage users won't get that. So, remerge -r1 to get the changes or look here: http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-apps/preload/files/
Thanks, seems to work fine :-)