Bug 242500 – [patch] x11-plugins/wmtimer-2.92 only counts 59 seconds a minute

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Alastair Murray 2008-10-17 20:23:06 UTC]

x11-plugins/wmtimer-2.92 only counts 59 seconds a minute while in chrono or timer mode.  I've prepared a patch to fix this, it and a patch to the current ebuild to use the patch.  I will attach them to this bug shortly.

I've not forwarded this patch to upstream (there hasn't been a release in years).

Reproducible: Always

Steps to Reproduce:
1. Run wmtimer
2. Start chrono or set timer
3. The chrono/timer will increment/decrement (respectively) every second, except:
4. If the current real time is 0 seconds past the minute the the timer *doesn't* increment/decrement.

Actual Results:  
The chrono/timer only counts 59 seconds a minute.

Expected Results:  
The chrono/timer should count 60 seconds a minute.

Patch was tested on a amd64 system (gcc version 4.1.2 (Gentoo 4.1.2 p1.1)), but the change is trivial and should be entirely portable.

[Comment 1 Alastair Murray 2008-10-17 20:23:59 UTC]

Created attachment 168840 [details, diff]
Fix to count 60 seconds a minute.

[Comment 2 Alastair Murray 2008-10-17 20:24:36 UTC]

Created attachment 168842 [details, diff]
Patch to ebuild to use counter-fix patch.

[Comment 3 Wormo (RETIRED) 2008-10-18 01:14:10 UTC]

Thanks for submitting your fix, assigning to ebuild maintainers.

[Comment 4 Michele Noberasco (RETIRED) 2008-10-28 10:15:06 UTC]

Fix is in Portage as new package revision, thanks for the submission!