Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 24185 - Evolution 1.4 ebuild does not utilise the ssl flag even though it's in IUSE
Summary: Evolution 1.4 ebuild does not utilise the ssl flag even though it's in IUSE
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Alastair Tse (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-09 09:07 UTC by David Nielsen
Modified: 2003-07-12 18:22 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Nielsen 2003-07-09 09:07:03 UTC
The evolution 1.4 ebuild has ssl in IUSE, but myconf isn't being adjusted to use
ssl.

needs to depend on something like this:

ssl? ( >=dev-libs/openssl-0.9.6 )

And have 

  use ssl \
        && myconf="${myconf} --enable-openssl=yes" \
        || myconf="${myconf} --enable-openssl=no"

in src_compile()

Otherwise evolution will not support ssl as the default is not yes

Reproducible: Always
Steps to Reproduce:
Comment 1 David Nielsen 2003-07-09 09:10:13 UTC
Strike that depend item, we have 

ssl? ( mozilla? ( >=net-www/mozilla-0.9.9 ) : ( >=dev-libs/openssl-0.9.5 ) )

near the buttom that will do the trick, but we still don't decide in src_compile on enable
Comment 2 Alastair Tse (RETIRED) gentoo-dev 2003-07-09 10:52:53 UTC
emm .. just below "use kde" there's:

   # Use Mozilla NSS libs if 'mozilla' *and* 'ssl' in USE
   if [ -n "`use ssl`" -a -n "`use mozilla`" ] ; then
      myconf="${myconf} --enable-nss=yes \
         --with-nspr-includes=${MOZILLA}/include/nspr \
         --with-nspr-libs=${MOZILLA} \
         --with-nss-includes=${MOZILLA}/include/nss \
         --with-nss-libs=${MOZILLA}"
   else
      myconf="${myconf} --without-nspr-libs --without-nspr-includes \
         --without-nss-libs --without-nss-includes"
   fi
                                                                                
   # Else use OpenSSL if 'mozilla' not in USE  ...
   if [ -n "`use ssl`" -a -z "`use mozilla`" ] ; then
      myconf="${myconf} --enable-openssl=yes"
   fi


is SSL not enabled for you? i've been using both mozilla and openssl's implementation and seems to be working fine. if it is not, can you attach a build log and also output of emerge info?
Comment 3 David Nielsen 2003-07-09 12:22:07 UTC
I have both mozilla and ssl in USE, and evolution says I have no SSL support in my build.

I did notice the mozilla bit but figured it was broken "leftovers" from a previous ebuild for 1.3 maybe - because my evolution clearly reported to me that SSL wasn't in my build.

I think you need to tell the configure script to --enable-openssl=yes in all cases where the user desires ssl support, at least that seems to be the case.
Comment 4 David Nielsen 2003-07-09 12:27:58 UTC
I just remembered, I'm on Mozilla 1.4, that might matter, it a path has changed or something odd has happened, like a header file mix up.

I'll try stepping down to Mozilla 1.3-r2, but I still fail to see why we want to use the mozilla implementation wouldn't it make more sense to just use OpenSSL plain and simple, is there any special reason for doing it the other way around?
Comment 5 Alastair Tse (RETIRED) gentoo-dev 2003-07-09 12:30:21 UTC
yeah, thats not rubbish left in the ebuild. it actually works :P

anyway, you can build evolution ssl support with the mozilla nspr/nss libraries or alternatively openssl. evolution 1.0.x originally depended on the mozilla nspr/nss libraries and only since 1.2.x did they support openssl. 

i've allowed the user to build with both (default is nspr/nss simply because of the default useflags.) i've used both nspr/nss and openssl support from the current ebuild and it should be working. they are mutually exclusive. the configure flag --with-openssl will, as its name suggests, use openssl rather than the nspr/nss libraries from mozilla.

could you please provide a build log with USE="ssl mozilla" so i know why ssl support isn't turned on for your case?
Comment 6 Alastair Tse (RETIRED) gentoo-dev 2003-07-09 12:38:18 UTC
to be honest, i haven't tried with 1.4 (although i have it installed). i only compiled the openssl ver to verify some compilation problems. however, i am inclined to move away from depending on mozilla. (many people wonder why evolution depends on mozilla)

there is work being done in this bug 23730 to remove the dependency. the reasoning behind keeping nspr/nss support is historical, not technical. as far as i know, the both have the same level of support. also, ximian's rpm's actually prefer using the mozilla libs than openssl. i would guess the reasoning being nspr/nss is  more proven since mozila also uses it for their mail client.
Comment 7 David Nielsen 2003-07-09 12:53:37 UTC
Personally I wouldn't trust mozilla further than I can throw it. It's big, bloated and complex. After having looked at the ebuild I'm now convinced that no matter what I'm compiling evolution with -mozilla, I thought originally that it was for some weird integration purpose we had that flag, but for SSL is seems like use flag overkill.

I would second the request to remove the mozilla use flag from this ebuild, I see no pressing technical reasons for recompiling mozilla each time there's an ssl bug to keep my mail safe.
Comment 8 Alastair Tse (RETIRED) gentoo-dev 2003-07-09 13:14:43 UTC
well, i'm not convinced that removing it would be a wise move, given the authors themselves (ximian) package their evolution with nss/nspr rather than openssl.

the choice is yours to put -mozilla in your useflags and not have it use nss/nspr. i can't remember when was the last time mozilla had a ssl vunerability, but i can sure remember when i had to upgrade openssl. 

nevertheless, your point is rather moot since i pointed out that i'm moving to use nss/nspr as seperate libraries so by default you don't need mozilla by default.

so does that mean you are not going to show me a build log that has the ssl support fails if mozilla is in your USE flags?
Comment 9 Alastair Tse (RETIRED) gentoo-dev 2003-07-12 18:22:41 UTC
well, mozilla support will stay. 1.4.3 can optionally depend on independent nss/nspr libraries if people so wish.