Bug 241618 – media-plugins/vdr-mp3ng ebuild does not install when having imagemagick package

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description G. Náray 2008-10-12 17:02:14 UTC]

The media-plugins/vdr-mp3ng ebuild does not install when having imagemagick package. The reason is very simple, the author of vdr-mp3ng did not test it against imagemagick, and what is not tested, usually does not work.
Version 0.0.1_pre3, or 0.0.1_pre4 


Reproducible: Always

Steps to Reproduce:
1.emerge vdr-mp3ng
2.
3.

Actual Results:  
while compiling bitmap.c
error: can not find Magick.h++

Expected Results:  
It should be compiled without error, and the package should be installed

Here is my solution, as a patch file, that could be used as last epatch line in ebuild file (after patching with vdr-mp3ng-0.0.1_pre4-1.3.37.diff):

--- mp3ng-0.9.13-MKIV-pre4-orig/Makefile	2008-10-12 18:37:52.000000000 +0200
+++ mp3ng-0.9.13-MKIV-pre4/Makefile	2008-10-12 18:39:38.000000000 +0200
@@ -60,6 +60,7 @@
 VDRINCDIR = /usr/include
 LIBDIR = ../../lib
 TMPDIR = /tmp
+IMAGEMAGICKINCDIR = /usr/include/ImageMagick
 
 ### Allow user defined options to overwrite defaults:
 
@@ -103,6 +104,9 @@
 
 INCLUDES += -I$(VDRINCDIR) 
 DEFINES  += -D_GNU_SOURCE -DVDRVERSNUM=$(VDRVERSNUM)
+ifdef HAVE_MAGICK
+INCLUDES += -I$(IMAGEMAGICKINCDIR)
+endif
 
 ### The object files (add further files here):
 
@@ -122,7 +126,7 @@
 
 ifdef HAVE_MAGICK
   DEFINES += -DHAVE_MAGICK
-  LIBS += -lMagick -lMagick++
+  LIBS += -lMagick++
 endif
 
 ifdef HAVE_XPM

[Comment 1 Wormo (RETIRED) 2008-10-13 06:59:57 UTC]

Thanks for the report and example patch, assigning to maintainers

[Comment 2 Joerg Bornkessel (RETIRED) 2008-10-25 11:23:51 UTC]

Thanks for pointing this,

i am fixed in my local tree any time ago, forgot to commit :(

anyway, its fixed now.

Thanks again