Ebuild should install icons used in Designer.desktop and Linguist.desktop tools/designer/src/designer/designer.ico tools/linguist/linguist/linguist.ico Reproducible: Always
Notes: - applies to x11-libs/qt-assistant-4.4.2 as well - .ico files are for Windows, for Linux icons .png is used
Created attachment 177191 [details] qt-gui-4.4.2-r1 ebuild proposal
Created attachment 177192 [details] qt-assistant-4.4.2-r1 ebuild proposal
A few more words about the new ebuilds: - The needed icons are not installed by Qt itself so the ebuild does that - Having "assistant.png" for the icon location in a .desktop file seems to result in loading of a a different icon. Switching to an sbsolute filename (/usr/share/pixmaps/aissistant.png) solved this. Same for the designer icon. - The "Qt Designer" icon now just says "Designer". I felt this to be more consistent to "Linguist" and "Assistant". Please change it back if needed. - Previous ebuilds used the .desktop file from the "files" directory. As I needed to change the icon location in there, I took the occasion to consider if maybe using make_desktop_entry would be a better thing to do, also because that allows to modify behavior per ebuild and not for several Qt ebuilds at once. The interesting part of the qt-gui ebuild (speaking of one, applies to both) is this section of the install stage: ================================================================ cd "${S}" || die "cd failed" dodir /usr/share/pixmaps/ || die "dodir failed" insinto /usr/share/pixmaps/ || die "insinto failed" doins tools/linguist/linguist/images/icons/linguist-128-32.png \ tools/designer/src/designer/images/designer.png || die "doins failed" make_desktop_entry /usr/bin/linguist Linguist \ /usr/share/pixmaps/linguist-128-32.png \ 'Qt;Development;GUIDesigner' \ || die "make_desktop_entry failed" make_desktop_entry /usr/bin/designer Designer \ /usr/share/pixmaps/designer.png \ 'Qt;Development;GUIDesigner' \ || die "make_desktop_entry failed" ================================================================
Thanks! Committed.
qt-gui-4.5.0 is still affected by this one, should I open a new bug or reopen this? Thanks!
Is that so? Ben, Alex can you verify this issue with qt-4.5.0 ?
Confirm that issue is still there with qt-gui-4.5.0
Unless anyone confirms that the problem also exists in 4.4.2-r3 I suppose this rather indicates a change upstream and a new bug.
4.2.2-r3 has a different code for desktop menu creation The thing is that I do have linguist and Designer Icons and I use qt-gui-4.5.0 :\ I ll digg into this tomorrow :)
(In reply to comment #7) > Ben, Alex can you verify this issue with qt-4.5.0 ? Yes, I can verify
I just commited qt-assistant-4.5.0-r1 and qt-gui-4.5.0-r1 Thanks again for reporting this :)
Thanks a lot for the fast fix, I will test it as soon as I am able :-)
Confirm fixed with qt-gui-4.5.0-r1
(In reply to comment #12) > I just commited qt-assistant-4.5.0-r1 and qt-gui-4.5.0-r1 > > Thanks again for reporting this :) > Works perfectly for me :D. But I had to run kbuildsyscoa4 afterwards for KDE4
