Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 24107 - inconsistent NOCOLOR usage in init.d/functions.sh vs. make.globals
Summary: inconsistent NOCOLOR usage in init.d/functions.sh vs. make.globals
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High normal
Assignee: Martin Schlemmer (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-08 08:50 UTC by splite
Modified: 2003-07-16 12:16 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description splite 2003-07-08 08:50:17 UTC
make.globals says to set NOCOLOR to "true" to disable color use, but
init.d/functions.sh tests for the value "yes".  Easiest fix is to change the
comment in make.globals, as portage accepts either.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Martin Schlemmer (RETIRED) gentoo-dev 2003-07-16 12:16:17 UTC
Changed it to this:

-------------------------------------
Index: sbin/functions.sh
===================================================================
RCS file: /home/cvsroot/gentoo-src/rc-scripts/sbin/functions.sh,v
retrieving revision 1.37
diff -u -r1.37 functions.sh
--- sbin/functions.sh	21 May 2003 08:00:55 -0000	1.37
+++ sbin/functions.sh	16 Jul 2003 19:13:15 -0000
@@ -63,6 +63,8 @@
 	# Check user pref in portage
     RC_NOCOLOR="$(python -c 'import portage; print portage.settings["NOCOLOR"]' 2> /dev/null)"
 
+	[ "${RC_NOCOLOR}" = "true" ] && RC_NOCOLOR="yes"
+
 elif [ -n "${EBUILD}" ] && [ "${*/depend}" != "$*" ]
 then
 	# We do not want colors or stty to run during emerge depend