Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 240403 - media-libs/x264-0.0.20080819: git-rev-list: command not found in version.sh
Summary: media-libs/x264-0.0.20080819: git-rev-list: command not found in version.sh
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-07 17:29 UTC by Matthias Schwarzott
Modified: 2013-03-09 17:17 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Schwarzott gentoo-dev 2008-10-07 17:29:47 UTC
media-libs/x264-0.0.20080819 does try to call git-rev-list.

First: The symlinks to the git subcommands do no longer exist so this should be changed to "git rev-list".

Second: I don't know what version.sh exactly does, but according to yngwin (in #gentoo-dev) the ebuild should be changed to not use it any more.
Comment 1 Alexis Ballier gentoo-dev 2008-10-08 11:44:38 UTC
Frankly, I don't really care about this.

As it is now, it gives me a config.h with something like:
#define X264_VERSION ""
#define X264_POINTVER "0.65.x"

having it "fixed" I get:
#define X264_VERSION " r0+999 cc51047"
#define X264_POINTVER "0.65.0+999 cc51047"

moreover it seems broken the way it is exported, I get this running ./version.sh:
fatal: ambiguous argument 'origin/master': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions

fixing it again gives me:
#define X264_VERSION " r999M cc51047"
#define X264_POINTVER "0.65.999M cc51047"

this only serves the x264 -V option and the version output in the library...
However, it is needed because used unconditionnaly so version.sh has to stay but i'm not going to make patches for this and esp. not port them to each new snapshot.
Comment 2 Ben de Groot (RETIRED) gentoo-dev 2008-10-08 22:31:47 UTC
I'll have a look at this.
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2009-09-09 09:27:10 UTC
I don't see this problem with latest snapshot. Reopen, if it's still a issue.

ssuominen@unique ~ $ x264 -V
x264 0.75.1251M e553a4c
built on Sep  9 2009, gcc: 4.4.1

ssuominen@unique ~ $ qlist -CIv x264
media-libs/x264-0.0.20090908
media-video/x264-encoder-0.0.20090908
Comment 4 Roman Žilka 2013-03-09 17:17:17 UTC
Please, re-open. On my amd64 machine, the install phase of media-libs/x264-0.0.20111220 does this:

----
command not found:

        ./version.sh: line 2: git: command not found
----

It's the git rev-list.

This calls for either adding git to DEPEND or removing the git call completely. Personally, I vote for the latter - x264 runs just fine for me even without the git call, and I don't want to have to merge git just for x264.