240132 – app-text/hnb: CFLAGS are ignored, other QA issues and missing dependencies

Bug 240132 - app-text/hnb: CFLAGS are ignored, other QA issues and missing dependencies

Summary: app-text/hnb: CFLAGS are ignored, other QA issues and missing dependencies

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	High normal
Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it

URL:
Whiteboard:
Keywords:

Duplicates (1):	270991 (view as bug list)
Depends on:
Blocks:

Reported:	2008-10-05 20:49 UTC by Diego Elio Pettenò (RETIRED)
Modified:	2009-10-23 12:49 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Move includes out of CFLAGS, and respect LDFLAGS (src_makefile.patch,647 bytes, patch) 2009-05-23 21:27 UTC, Espen Hustad	Details \| Diff
Respect CFLAGS and LDFLAGS (libcli_makefile.patch,598 bytes, patch) 2009-05-23 21:28 UTC, Espen Hustad	Details \| Diff
Fix qa warning about implicit stclen declaration (fix_implicit_string.patch,267 bytes, patch) 2009-05-23 21:29 UTC, Espen Hustad	Details \| Diff
Respect CC, CFLAGS, LDFLAGS. Add unstated depend (hnb-1.9.18_ebuild.patch,1.62 KB, patch) 2009-05-23 21:34 UTC, Espen Hustad	Details \| Diff
Move includes out of CFLAGS, and respect LDFLAGS (src_makefile.patch,669 bytes, patch) 2009-05-24 00:42 UTC, Espen Hustad	Details \| Diff
Respect CC, CFLAGS, LDFLAGS. Add unstated depend. (hnb-1.9.18_ebuild.patch,1.51 KB, patch) 2009-05-24 12:52 UTC, Espen Hustad	Details \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2008-10-05 20:49:42 UTC

I don't know the build system for this program (and this is a generic bug template so I cannot tell you which program exactly is), but my tests shows that it's not respecting CFLAGS properly.

Please look into it, since it's important to respect user CFLAGS.

Thanks,
Diego

Comment 1 Espen Hustad 2009-05-23 21:27:53 UTC

Created attachment 192231 [details, diff]
Move includes out of CFLAGS, and respect LDFLAGS

Comment 2 Espen Hustad 2009-05-23 21:28:37 UTC

Created attachment 192232 [details, diff]
Respect CFLAGS and LDFLAGS

Comment 3 Espen Hustad 2009-05-23 21:29:50 UTC

Created attachment 192233 [details, diff]
Fix qa warning about implicit stclen declaration

Comment 4 Espen Hustad 2009-05-23 21:34:24 UTC

Created attachment 192235 [details, diff]
Respect CC, CFLAGS, LDFLAGS. Add unstated depend

This also fixes bug #243730 and bug #270991. Also added a patch to fix QA warning about implicit strlen declaration.

Comment 5 Espen Hustad 2009-05-24 00:42:37 UTC

Created attachment 192251 [details, diff]
Move includes out of CFLAGS, and respect LDFLAGS

Comment 6 Sebastian Luther (few) 2009-05-24 08:16:44 UTC

*** Bug 270991 has been marked as a duplicate of this bug. ***

Comment 7 Espen Hustad 2009-05-24 12:52:45 UTC

Created attachment 192296 [details, diff]
Respect CC, CFLAGS, LDFLAGS. Add unstated depend.

This also fixes bug #243730 and bug #270991. Also added a patch to fix QA
warning about implicit strlen declaration.

Comment 8 Jeroen Roovers (RETIRED) gentoo-dev

2009-10-23 12:49:16 UTC

Fixed in 1.9.18-r1. I wrote my own Makefile patch, btw, which inherits the flags properly and also magically makes it build better in parallel.

In CVS revision 1.2 of that ebuild, I also apply the include patch.