Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 240124 - app-shells/sash: CFLAGS are ignored
Summary: app-shells/sash: CFLAGS are ignored
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-05 20:43 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2008-10-26 05:31 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-10-05 20:43:00 UTC
I don't know the build system for this program (and this is a generic bug template so I cannot tell you which program exactly is), but my tests shows that it's not respecting CFLAGS properly.

Please look into it, since it's important to respect user CFLAGS.

Thanks,
Diego
Comment 1 SpanKY gentoo-dev 2008-10-05 21:34:17 UTC
post information on why you think it isnt respecting flags.  looks like it
works to me and it's been that way for a long time.

if you're just writing a script, you need to review the output to avoid a shit ton of false positives which just wastes other people's time.
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2008-10-05 22:10:07 UTC
Hrm, I found the problem: my script assumes that CFLAGS gets set during src_compile, while here they are hardset during src_unpack().

I'd debate that I'm still correct here since after an ebuild $foo unpack I wouldt expect my CFLAGS to be respected again, but I admit it's semantic at this point.
Comment 3 SpanKY gentoo-dev 2008-10-26 05:31:02 UTC
no, flag setting in src_unpack is valid and fully supported

if you do it in src_compile, then you cannot repeat the step with the same result if something like "append-flags" were used ... you'd keep appending the value over and over