Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 239929 - app-editors/jove: CFLAGS are ignored
Summary: app-editors/jove: CFLAGS are ignored
Status: RESOLVED WORKSFORME
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Emacs project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-05 11:36 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2008-10-21 21:53 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-10-05 11:36:11 UTC
I don't know the build system for this program (and this is a generic bug template so I cannot tell you which program exactly is), but my tests shows that it's not respecting CFLAGS properly.

Please look into it, since it's important to respect user CFLAGS.

Thanks,
Diego
Comment 1 Ulrich Müller gentoo-dev 2008-10-05 11:44:18 UTC
Great, I just committed a new version as fix for bug 239869 one minute ago. :-(

Couldn't you have reported these two build system issues in one single bug, to avoid duplicate work for package maintainers?
Comment 2 Ulrich Müller gentoo-dev 2008-10-05 11:45:22 UTC
Patches are welcome. :p
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2008-10-05 11:46:58 UTC
I was going through the whole list of app-editors/*, but since I grep the logs for one condition first and the other after, they get reported separately... sorry but you're the _only_ person who ever responded to a bug I've been reporting so quickly...
Comment 4 Ulrich Müller gentoo-dev 2008-10-05 11:58:10 UTC
Hm, src_unpack does:
    sed -i -e "s:^OPTFLAGS =.*:OPTFLAGS = ${CFLAGS}:" Makefile

And my CFLAGS are respected during compilation:
>>> Compiling source in /var/tmp/portage/app-editors/jove-4.16.0.70.3/work/jove4.16.0.70 ...
gcc -O -march=pentium-m -O2 -pipe -fomit-frame-pointer -DBSDPOSIX_STDC   -c -o commands.o commands.c
gcc -O -march=pentium-m -O2 -pipe -fomit-frame-pointer -DBSDPOSIX_STDC   -c setmaps.c
[...]

So what exactly is the issue?
Comment 5 Ulrich Müller gentoo-dev 2008-10-21 21:53:34 UTC
Closing (as discussed on IRC). Maybe the ebuild is not using the most elegant solution, but CFLAGS are respected.