Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 23849 - games.eclass
Summary: games.eclass
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: High major (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-01 21:32 UTC by Amiel Martin
Modified: 2003-07-02 17:49 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Amiel Martin 2003-07-01 21:32:49 UTC
in games_pkg_setup()
$Header: /home/cvsroot/gentoo-x86/eclass/games.eclass,v 1.32 2003/07/01 19:13:18
vapier Exp $
the line
use dedicated && enewuser ...
returns false if USE="-dedicated"
which means that the functions returns false
which makes everything fail...

Reproducible: Always
Steps to Reproduce:
1. USE="-dedicated" emerge xbomb


Actual Results:  
<snip>
 * Adding user 'games' to your system ...
 * games already exists on your system :)

!!! ERROR: app-games/xbomb-2.1-r1 failed.
!!! Function dyn_setup, Line 436, Exitcode 1
!!! pkg_setup function failed; exiting.



Expected Results:  
the problem can be fixed by
adding return 0; at the end of games_pkg_setup()
like this:

games_pkg_setup() {
    enewgroup ${GAMES_GROUP} 35
    enewuser ${GAMES_USER} 35 /bin/false /usr/games ${GAMES_GROUP}
    use dedicated && enewuser ${GAMES_USER_DED} 36 /bin/false /usr/games
${GAMES_GROUP}
    return 0;
} 


amiel@hobbes amiel $ emerge info
Portage 2.0.48-r1 (default-x86-1.4, gcc-3.2.2, glibc-2.3.1-r4)
=================================================================
System uname: 2.4.20-gentoo-r5 i686 AMD Duron(tm) processor
GENTOO_MIRRORS="http://gentoo.oregonstate.edu
http://distro.ibiblio.org/pub/Linux/distributions/gentoo"
CONFIG_PROTECT="/etc /var/qmail/control /usr/kde/2/share/config
/usr/kde/3/share/config /usr/X11R6/lib/X11/
xkb /usr/kde/3.1/share/config /usr/share/config"
CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d"
PORTDIR="/usr/portage"
DISTDIR="/usr/portage/distfiles"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR_OVERLAY="/usr/local/portage"
USE="x86 oss 3dnow apm avi crypt cups encode gif jpeg libg++ mikmod mmx mpeg nls
pdflib png quicktime spell
 truetype xml2 xmms xv zlib gtkhtml gdbm berkdb slang readline arts bonobo svga
tcltk java guile X sdl gpm 
tcpd pam libwww ssl perl python esd imlib oggvorbis gnome gtk qt kde motif
opengl mozilla cdr gtk2 aalib nc
urses 3dfx vim-with-x -alsa mozcalendar mozinterfaceinfo mozp3p pgd flash mysql
imap ldap odbc oracle oci8 
gd tiff xml"
COMPILER="gcc3"
CHOST="i686-pc-linux-gnu"
CFLAGS="-march=athlon-tbird -O3 -pipe -fomit-frame-pointer"
CXXFLAGS="-march=athlon-tbird -O3 -pipe -fomit-frame-pointer"
ACCEPT_KEYWORDS="x86"
MAKEOPTS="-j4"
AUTOCLEAN="yes"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
FEATURES="ccache sandbox"
Comment 1 SpanKY gentoo-dev 2003-07-02 09:49:10 UTC
i already added this to the eclass after a friend pointed it out via im 
 
my bad :) 
Comment 2 Amiel Martin 2003-07-02 17:49:00 UTC
thanks,
and maybe this should be mentioned in developer docs?