Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 238378 - kde-base/kdemultimedia-kioslaves-3.5.10 does not compile with media-sound/cdparanoia-3.10.2
Summary: kde-base/kdemultimedia-kioslaves-3.5.10 does not compile with media-sound/cdp...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
: 238375 238835 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-09-22 12:01 UTC by Matthias Liebig
Modified: 2008-09-27 22:31 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,53.76 KB, text/plain)
2008-09-22 12:03 UTC, Matthias Liebig
Details
Ebuild Patch (cdparanoia-3.10.ebuild.patch,705 bytes, patch)
2008-09-24 20:13 UTC, Kent Fredric (IRC: kent\n) (RETIRED)
Details | Diff
cdparanoia-3.10.2.ebuild (cdparanoia-3.10.2.ebuild,1.49 KB, text/plain)
2008-09-24 23:43 UTC, Kent Fredric (IRC: kent\n) (RETIRED)
Details
Rename member 'private' in cdda_interface.h (cdparanoia-3.10.2-gcc43.patch,21.38 KB, patch)
2008-09-24 23:48 UTC, Ian Abbott
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Liebig 2008-09-22 12:01:38 UTC
After updating to media-sound/cdparanoia-3.10.2 I was not able to install kde-base/kdemultimedia-kioslaves (required e.g. for kde-base/kaudiocreator-3.5.10). It works fine with the previous version of cdparanoia: media-sound/cdparanoia-3.10.0 .

Reproducible: Always

Steps to Reproduce:
1. emerge -av1 =media-sound/cdparanoia-3.10.2
2. emerge -av1 kde-base/kdemultimedia-kioslaves-3.5.10


Actual Results:  
In file included from encodercda.cpp:45:
/usr/include/cdda_interface.h:87: error: expected unqualified-id before 'private'
/usr/include/cdda_interface.h:87: error: expected ';' before 'private'
make[5]: *** [encodercda.lo] Fehler 1
make[5]: Leaving directory `/var/tmp/portage/kde-base/kdemultimedia-kioslaves-3.5.10/work/kdemultimedia-kioslaves-3.5.10/kioslave/audiocd/plugins/wav'
make[4]: *** [all-recursive] Fehler 1
make[4]: Leaving directory `/var/tmp/portage/kde-base/kdemultimedia-kioslaves-3.5.10/work/kdemultimedia-kioslaves-3.5.10/kioslave/audiocd/plugins'
make[3]: *** [all-recursive] Fehler 1
make[3]: Leaving directory `/var/tmp/portage/kde-base/kdemultimedia-kioslaves-3.5.10/work/kdemultimedia-kioslaves-3.5.10/kioslave/audiocd'
make[2]: *** [all-recursive] Fehler 1
make[2]: Leaving directory `/var/tmp/portage/kde-base/kdemultimedia-kioslaves-3.5.10/work/kdemultimedia-kioslaves-3.5.10/kioslave'
make[1]: *** [all-recursive] Fehler 1
make[1]: Leaving directory `/var/tmp/portage/kde-base/kdemultimedia-kioslaves-3.5.10/work/kdemultimedia-kioslaves-3.5.10'
make: *** [all] Fehler 2



My emerge --info:

Portage 2.2_rc9 (default/linux/x86/2008.0/desktop, gcc-4.3.1, glibc-2.8_p20080602-r0, 2.6.24-gentoo-r5 i686)
=================================================================
System uname: Linux-2.6.24-gentoo-r5-i686-Genuine_Intel-R-_CPU_T2500_@_2.00GHz-with-glibc2.0
Timestamp of tree: Mon, 22 Sep 2008 09:45:01 +0000
app-shells/bash:     3.2_p39
dev-java/java-config: 1.3.7, 2.1.6-r1
dev-lang/python:     2.4.4-r15, 2.5.2-r8
dev-python/pycrypto: 2.0.1-r6
sys-apps/baselayout: 2.0.0
sys-apps/openrc:     0.2.5
sys-apps/sandbox:    1.2.18.1-r3
sys-devel/autoconf:  2.13, 2.63
sys-devel/automake:  1.5, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.1-r1
sys-devel/binutils:  2.18-r3
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   2.2.6a
virtual/os-headers:  2.6.26
ACCEPT_KEYWORDS="x86 ~x86"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-march=prescott -O2 -pipe -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/config"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/terminfo /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-march=prescott -O2 -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="distlocks parallel-fetch preserve-libs protect-owned sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="http://mirrors.sec.informatik.tu-darmstadt.de/gentoo/ http://ftp-stud.fht-esslingen.de/pub/Mirrors/gentoo/ http://ftp.rz.tu-bs.de/pub/mirror/ftp.gentoo.org/gentoo/"
LANG="de_DE.utf8"
LC_ALL="de_DE.utf8"
LDFLAGS="-Wl,-O1"
LINGUAS="de"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage/layman/voip /usr/local/portage/layman/iptego /usr/local/portage/layman/sunrise"
SYNC="rsync://pirate/gentoo-portage"
USE="X a52 aac acl acpi aim alsa apm arts aspell bash-completion berkdb bluetooth branding bzip2 cairo cdr cli cluster cracklib crypt cups curl dbus divx dri dvd dvdr dvdread emboss encode ethereal evo expat ffmpeg flac foomaticdb fortran gcrypt gdbm gif gnutls gpm gtk hal iconv icq imagemagick imap imlib ipv6 isdnlog java java5 jpeg jpeg2k kde libwww mad matroska mdnsresponder-compat midi mikmod mime mmx motif mp2 mp3 mp4 mpeg msn mudflap musepack mysql ncurses nls nptl nptlonly nsplugin ogg opengl openmp oss pam pcmcia pcntl pcre pdf perl png posix pppd python qt3 qt3support qt4 quicktime readline real realmedia reflection sdl session soap spell spl sse sse2 ssl startup-notification svg svga sysfs tcpd tetex theora tiff truetype unicode usb userlocales vcd vorbis wifi win32codecs wma wmf wmp wxwindows x86 xine xinerama xml xmlrpc xorg xulrunner xv xvid zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic auth_digest authn_anon authn_dbd authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock dbd deflate dir disk_cache env expires ext_filter file_cache filter headers ident imagemap include info log_config logio mem_cache mime mime_magic negotiation proxy proxy_ajp proxy_balancer proxy_connect proxy_http rewrite setenvif so speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="de" USERLAND="GNU" VIDEO_CARDS="fglrx radeon vesa"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Matthias Liebig 2008-09-22 12:03:13 UTC
Created attachment 166085 [details]
build.log
Comment 2 Reinhard Biegel 2008-09-23 18:22:13 UTC
in cdda_interface.h we find:
45: typedef struct cdda_private_data cdda_private_data_t;
87: cdda_private_data_t *private;

struct cdda_private_data is defined in low_interface.h of the source tarball, but it seems not to be installed (and not even included from the cdda_interface.h).
Comment 3 Matthias Liebig 2008-09-23 19:20:23 UTC
(In reply to comment #2)
> struct cdda_private_data is defined in low_interface.h of the source tarball,
> but it seems not to be installed (and not even included from the
> cdda_interface.h).

No, that's not the problem. cdda_interface.h is used from a C++ file (encodercda.cpp). In C++ "private" has a special meaning (keyword?), so the field name within the struct should be changed. I'll send a mail to the author of cdparanoia.
Comment 4 Matthias Liebig 2008-09-24 00:13:20 UTC
It's now fixed in the svn (r15338):

  'private' as a reserved keyword now being enforced by GCC 4.3, causes a build failure (patched in SVN)
Comment 5 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2008-09-24 20:13:37 UTC
Created attachment 166305 [details, diff]
Ebuild Patch

I compared the upstream SVN copy with the current branch and made a nice sed line that will apply the same fix for those whom want a "now" fix. 

Works for me :)
Comment 6 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2008-09-24 21:56:26 UTC
In case it wasn't obvious ( theres already been one missunderstanding ), the .patch ( file 166305 ) may not be friendly enough to just "snap in". 

Read it and apply as needed to your own .ebuild file. ;) 

Its diffing 2 files in 2 different locations, so .. yeah. read code before applying :) 
Comment 7 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2008-09-24 23:43:59 UTC
Created attachment 166334 [details]
cdparanoia-3.10.2.ebuild

Seeing people get confused really easy ( *rolls eyes* ) here is a patched ebuild for your amusement.
Comment 8 Ian Abbott 2008-09-24 23:48:16 UTC
Created attachment 166336 [details, diff]
Rename member 'private' in cdda_interface.h

Using 'sed' in the ebuild is too fugly for me, so here's a patch for the cdparanoia 3.10.2 source - cdparanoia-3.10.2-gcc43.patch

The existing epatch in the ebuild could be extended to apply this patch.
Comment 9 Ian Abbott 2008-09-24 23:55:17 UTC
(In reply to comment #8)
> The existing epatch in the ebuild could be extended to apply this patch.

Like this:

    epatch \
        "${FILESDIR}"/${PN}-3.10.2-use-destdir.patch \
        "${FILESDIR}"/${PN}-3.10.2-Makefile.in.patch \
        "${FILESDIR}"/${PN}-3.10.2-gcc43.patch


Comment 10 Jorge Manuel B. S. Vicetto (RETIRED) Gentoo Infrastructure gentoo-dev 2008-09-26 04:33:01 UTC
*** Bug 238375 has been marked as a duplicate of this bug. ***
Comment 11 Jorge Manuel B. S. Vicetto (RETIRED) Gentoo Infrastructure gentoo-dev 2008-09-26 04:37:12 UTC
@media-sound: Can we get a patch for cdparanoia or an updated version?
Comment 12 Peter Alfredsen (RETIRED) gentoo-dev 2008-09-26 07:14:00 UTC
Why, certainly.

+*cdparanoia-3.10.2-r1 (26 Sep 2008)
+
+  26 Sep 2008; Peter Alfredsen <loki_val@gentoo.org>
+  +files/cdparanoia-3.10.2-gcc43.patch, -cdparanoia-3.10.2.ebuild,
+  +cdparanoia-3.10.2-r1.ebuild:
+  Fix bug 238378. Thanks to Matthias Liebig <pqGungnir@gmx.de> and Ian
+  Abbott <ian@abbott.org>.
+
Comment 13 James L. Hammons 2008-09-27 22:31:47 UTC
*** Bug 238835 has been marked as a duplicate of this bug. ***