Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 238311 - sys-devel/patch-2.5.9-r1 stable request
Summary: sys-devel/patch-2.5.9-r1 stable request
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-21 18:56 UTC by Alexis Ballier
Modified: 2008-10-26 05:56 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Ballier gentoo-dev 2008-09-21 18:56:33 UTC
I'm tired of seeing patches failing to apply on a stable system because of dos line endings. Please cc arches if ok, thanks.
Comment 1 SpanKY gentoo-dev 2008-09-22 15:23:19 UTC
fix your patches
Comment 2 Alexis Ballier gentoo-dev 2008-09-22 17:03:54 UTC
(In reply to comment #1)
> fix your patches

Yes; I cannot agree more, but then if I run ~arch I wont see any problem with so-called broken patches but will get hard to understand bug reports about failing patches. Even worse, if some arch dev happens to have ~arch patch and marks something stable, it'll break. And yes, I know, it has nothing to do with 'patch' and is people's fault, but keeping things as they are make it very prone to such errors.

Imho the current situation is annoying and confusing; if -r1 is a no go for stable, then please remove it.
Comment 3 SpanKY gentoo-dev 2008-10-26 05:56:04 UTC
each patch is dysfunctional in its own way.  only using the -r0 would allow a different class of broken patches to proliferate.  only by having both -r0 and -r1 available are we able to catch both classes of broken patches.

if you feel like fixing patch itself, g'luck ... i tried digging into the source a while ago and it's a nightmare.