Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 238302 - sci-chemistry/rasmol version bump to 2.7.5
Summary: sci-chemistry/rasmol version bump to 2.7.5
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement with 1 vote (vote)
Assignee: Gentoo Chemistry-Related Packages
URL: http://www.bernstein-plus-sons.com/so...
Whiteboard: [SCI overlay]
Keywords: EBUILD, InVCS
Depends on:
Blocks:
 
Reported: 2008-09-21 17:38 UTC by Justin Lecher (RETIRED)
Modified: 2010-02-03 22:36 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
rasmol.ebuild.diff (rasmol.ebuild.diff,1.94 KB, patch)
2008-09-21 17:39 UTC, Justin Lecher (RETIRED)
Details | Diff
cbflib.patch (cbflib.patch,1.18 KB, text/plain)
2008-09-22 07:55 UTC, Justin Lecher (RETIRED)
Details
rasmol.ebuild.diff w/ support for 8 and 16bit (rasmol_1.diff,3.01 KB, text/plain)
2008-09-24 08:49 UTC, Justin Lecher (RETIRED)
Details
rasmol.ebuild.diff w/o support for 8 and 16bit (rasmol_2.diff,2.44 KB, text/plain)
2008-09-24 08:54 UTC, Justin Lecher (RETIRED)
Details
build.log (build.log,47.61 KB, text/plain)
2009-03-02 18:41 UTC, Martin Mokrejš
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Lecher (RETIRED) gentoo-dev 2008-09-21 17:38:54 UTC
There is an update of rasmol.

There is a long list of changes, but the most important is the possibility the show maps. For this reason a new library is needed. I added the ebuild in bug #238300.
So far no big changes have to be introduced to the existing version in portage.
Comment 1 Justin Lecher (RETIRED) gentoo-dev 2008-09-21 17:39:21 UTC
Created attachment 166011 [details, diff]
rasmol.ebuild.diff
Comment 2 Justin Lecher (RETIRED) gentoo-dev 2008-09-21 18:21:26 UTC
Although I added ~amd ~ppc I only test on x86. So this has to be tested carefully.
Comment 3 Jouni Kosonen 2008-09-21 20:05:23 UTC
Was there supposed to be a cbflib.patch as well to prevent the build from downloading it on its own?
Comment 4 Justin Lecher (RETIRED) gentoo-dev 2008-09-22 07:53:55 UTC
(In reply to comment #3)
> Was there supposed to be a cbflib.patch as well to prevent the build from
> downloading it on its own?
> 

Sure, I forgot to post the patch.
Comment 5 Justin Lecher (RETIRED) gentoo-dev 2008-09-22 07:55:19 UTC
Created attachment 166067 [details]
cbflib.patch
Comment 6 Donnie Berkholz (RETIRED) gentoo-dev 2008-09-22 18:12:18 UTC
It also has an option to build a GTK frontend instead of that ugly one. Here's how I added that:

- Add gtk to IUSE
- RDEPEND has gtk? ( x11-libs/gtk+:2 )"
- src_compile() has `use gtk && myconf="${myconf} -DGTKWIN"`
Comment 7 Justin Lecher (RETIRED) gentoo-dev 2008-09-22 19:06:04 UTC
(In reply to comment #6)
> It also has an option to build a GTK frontend instead of that ugly one. Here's
> how I added that:
> 
> - Add gtk to IUSE
> - RDEPEND has gtk? ( x11-libs/gtk+:2 )"
> - src_compile() has `use gtk && myconf="${myconf} -DGTKWIN"`
> 

How did you find out how to manage that? 
Comment 8 Donnie Berkholz (RETIRED) gentoo-dev 2008-09-22 19:17:34 UTC
Pretty sure it was in the release announcement on the ccp4 list.
Comment 9 Justin Lecher (RETIRED) gentoo-dev 2008-09-22 19:34:55 UTC
(In reply to comment #6)
> It also has an option to build a GTK frontend instead of that ugly one. Here's
> how I added that:
> 
> - Add gtk to IUSE
> - RDEPEND has gtk? ( x11-libs/gtk+:2 )"
> - src_compile() has `use gtk && myconf="${myconf} -DGTKWIN"`
> 
For me it takes this more:
-        xmkmf || die "xmkmf failed"
+        xmkmf ${myconf} || die "xmkmf failed"

but it doesn't compile:
i686-pc-linux-gnu-gcc -O2 -march=prescott -mssse3 -pipe -fomit-frame-pointer      -I/usr/include    -Dlinux -D__i386__ -D_POSIX_C_SOURCE=199309L 				-D_POSIX_SOURCE -D_XOPEN_SOURCE 				-D_BSD_SOURCE -D_SVID_SOURCE                                 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 				  				  -DFUNCPROTO=15 -DNARROWPROTO   -D_REENTRANT -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gtk-2.0 -I/usr/include/pango-1.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/directfb -I/usr/include/libpng12 -I/usr/include/pixman-1   -DGTKWIN -DRASMOLDIR=\"/usr/lib/rasmol/\" -DEIGHTBIT            -D_USE_RASMOL_H_  -I/usr/include/cbflib    -c -o gtkwin.o gtkwin.c
gtkwin.c: In function ‘AllocateColourMap’:
gtkwin.c:1161: error: ‘SwapBytes’ undeclared (first use in this function)
gtkwin.c:1161: error: (Each undeclared identifier is reported only once
gtkwin.c:1161: error: for each function it appears in.)
gtkwin.c: In function ‘OpenDisplay’:
gtkwin.c:1552: error: ‘test’ undeclared (first use in this function)
gtkwin.c:1553: error: ‘SwapBytes’ undeclared (first use in this function)
make: *** [gtkwin.o] Error 1


Donnie, what is wrong?
Comment 10 Donnie Berkholz (RETIRED) gentoo-dev 2008-09-23 06:36:10 UTC
Seems like some poorly written code. Conditionally declares a variable then unconditionally uses it later in the code. I think you noted in private email to me that it only works w/ a 32bit build. I'd say to just drop the other ones at this point, who cares?
Comment 11 Justin Lecher (RETIRED) gentoo-dev 2008-09-24 08:49:38 UTC
Created attachment 166245 [details]
rasmol.ebuild.diff w/ support for 8 and 16bit
Comment 12 Justin Lecher (RETIRED) gentoo-dev 2008-09-24 08:54:45 UTC
Created attachment 166247 [details]
rasmol.ebuild.diff w/o support for 8 and 16bit 

I created two versions of patches. The first still has support for the 8 and 16bit version in case of not using the gtk interface. The second is basicly straight what Donnie suggested.

What needs testing is the support for parallel builds I introduced using emake instead of make. On my boxes there is no issue.
Comment 13 Martin Mokrejš 2009-03-02 18:41:39 UTC
>>> Emerging (10 of 26) sci-chemistry/rasmol-2.7.4.2 from science
 * RasMol_2.7.4.2.tar.gz RMD160 SHA1 SHA256 size ;-) ...                                                                                                                                                                       [ ok ]
 * checking ebuild checksums ;-) ...                                                                                                                                                                                           [ ok ]
 * checking auxfile checksums ;-) ...                                                                                                                                                                                          [ ok ]
 * checking miscfile checksums ;-) ...                                                                                                                                                                                         [ ok ]
>>> Unpacking source...
>>> Unpacking RasMol_2.7.4.2.tar.gz to /var/tmp/portage/sci-chemistry/rasmol-2.7.4.2/work
 * Applying cbflib.patch ...                                                                                                                                                                                                    [ ok ]
>>> Source unpacked in /var/tmp/portage/sci-chemistry/rasmol-2.7.4.2/work
>>> Compiling source in /var/tmp/portage/sci-chemistry/rasmol-2.7.4.2/work/RasMol_2.7.4.2_10Apr08 ...
imake -DGTKWIN -DUseInstalled -I/usr/lib/X11/config
rm -f rasmol._man
Package vte was not found in the pkg-config search path.
Perhaps you should add the directory containing `vte.pc'
to the PKG_CONFIG_PATH environment variable
No package 'vte' found
Package vte was not found in the pkg-config search path.
Perhaps you should add the directory containing `vte.pc'
to the PKG_CONFIG_PATH environment variable
No package 'vte' found
rm -f rasmol
Package vte was not found in the pkg-config search path.
Perhaps you should add the directory containing `vte.pc'
to the PKG_CONFIG_PATH environment variable
No package 'vte' found
Package vte was not found in the pkg-config search path.
Perhaps you should add the directory containing `vte.pc'
to the PKG_CONFIG_PATH environment variable
No package 'vte' found
rm -f gtkui.h rasmol.man
Package vte was not found in the pkg-config search path.
Perhaps you should add the directory containing `vte.pc'
to the PKG_CONFIG_PATH environment variable
No package 'vte' found
Package vte was not found in the pkg-config search path.
Perhaps you should add the directory containing `vte.pc'
to the PKG_CONFIG_PATH environment variable
No package 'vte' found
rm -f *.CKP *.ln *.BAK *.bak *.o core errs ,* *~ *.a .emacs_* tags TAGS make.log MakeOut   "#"*
Package vte was not found in the pkg-config search path.
Perhaps you should add the directory containing `vte.pc'
to the PKG_CONFIG_PATH environment variable
No package 'vte' found
Package vte was not found in the pkg-config search path.
Perhaps you should add the directory containing `vte.pc'
to the PKG_CONFIG_PATH environment variable
No package 'vte' found
make DEPTHDEF=-DTHIRTYTWOBIT CC=i686-pc-linux-gnu-gcc 'CDEBUGFLAGS=-O2 -march=pentium4 -mmmx -msse -msse2 -pipe -fno-strict-aliasing -ggdb' 
Package vte was not found in the pkg-config search path.
Perhaps you should add the directory containing `vte.pc'
to the PKG_CONFIG_PATH environment variable
No package 'vte' found
i686-pc-linux-gnu-gcc -O2 -march=pentium4 -mmmx -msse -msse2 -pipe -fno-strict-aliasing -ggdb      -I/usr/include    -Dlinux -D__i386__ -D_POSIX_C_SOURCE=199309L                               -D_POSIX_SOURCE -D_XOPEN_SOURCE      -D_BSD_SOURCE -D_SVID_SOURCE                                 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64                                                            -DFUNCPROTO=15 -DNARROWPROTO    -DGTKWIN -DRASMOLDIR=\"/usr/lib/rasmol/\" -DTHIRTYTWOBIT            -D_USE_RASMOL_H_  -I/usr/include/cbflib    -c -o rasmol.o rasmol.c
Package vte was not found in the pkg-config search path.
Perhaps you should add the directory containing `vte.pc'
to the PKG_CONFIG_PATH environment variable
No package 'vte' found
Package vte was not found in the pkg-config search path.
[cut]
echo >> gtkui.h
Package vte was not found in the pkg-config search path.
Perhaps you should add the directory containing `vte.pc'
to the PKG_CONFIG_PATH environment variable
No package 'vte' found
i686-pc-linux-gnu-gcc -O2 -march=pentium4 -mmmx -msse -msse2 -pipe -fno-strict-aliasing -ggdb      -I/usr/include    -Dlinux -D__i386__ -D_POSIX_C_SOURCE=199309L                               -D_POSIX_SOURCE -D_XOPEN_SOURCE      -D_BSD_SOURCE -D_SVID_SOURCE                                 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64                                                            -DFUNCPROTO=15 -DNARROWPROTO    -DGTKWIN -DRASMOLDIR=\"/usr/lib/rasmol/\" -DTHIRTYTWOBIT            -D_USE_RASMOL_H_  -I/usr/include/cbflib    -c -o gtkwin.o gtkwin.c
Package vte was not found in the pkg-config search path.
Perhaps you should add the directory containing `vte.pc'
to the PKG_CONFIG_PATH environment variable
No package 'vte' found
Package vte was not found in the pkg-config search path.
Perhaps you should add the directory containing `vte.pc'
to the PKG_CONFIG_PATH environment variable
No package 'vte' found
gtkwin.c:80:28: error: gdk/gdkkeysyms.h: No such file or directory
gtkwin.c:81:21: error: vte/vte.h: No such file or directory
In file included from gtkwin.c:99:
gtkui.h:3: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘*’ token
gtkui.h:146: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘*’ token
gtkui.h:308: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘*’ token
In file included from gtkwin.c:100:
eggfileformatchooser.h:22:29: error: gtk/gtkexpander.h: No such file or directory
In file included from gtkwin.c:100:
eggfileformatchooser.h:33: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘typedef’
eggfileformatchooser.h:39: error: expected specifier-qualifier-list before ‘GtkExpander’
eggfileformatchooser.h:45: error: expected specifier-qualifier-list before ‘GtkExpanderClass’
[cut]
 * 
 * ERROR: sci-chemistry/rasmol-2.7.4.2 failed.
 * Call stack:
 *               ebuild.sh, line   49:  Called src_compile
 *             environment, line 2146:  Called die
 * The specific snippet of code:
 *       emake DEPTHDEF=-DTHIRTYTWOBIT CC="$(tc-getCC)" CDEBUGFLAGS="${CFLAGS}" || die "32-bit make failed"
 *  The die message:
 *   32-bit make failed

Portage 2.1.6.7 (default/linux/x86/2008.0/desktop, gcc-4.3.3, glibc-2.9_p20081201-r2, 2.6.29-rc5-git2 i686)
=================================================================
System uname: Linux-2.6.29-rc5-git2-i686-Mobile_Intel-R-_Pentium-R-_4_-_M_CPU_1.80GHz-with-glibc2.0
Timestamp of tree: Sun, 01 Mar 2009 20:45:02 +0000
distcc 3.1 i686-pc-linux-gnu [disabled]
app-shells/bash:     3.2_p48-r1
dev-java/java-config: 1.3.7-r1, 2.1.7
dev-lang/python:     2.5.4-r2
dev-python/pycrypto: 2.0.1-r7
dev-util/cmake:      2.6.2-r1
sys-apps/baselayout: 2.0.0
sys-apps/openrc:     0.4.3-r1
sys-apps/sandbox:    1.3.8
sys-devel/autoconf:  2.13, 2.63
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.2
sys-devel/binutils:  2.19.1
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   2.2.6a
virtual/os-headers:  2.6.28-r1
ACCEPT_KEYWORDS="x86 ~x86"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=pentium4 -mmmx -msse -msse2 -pipe -fno-strict-aliasing -ggdb"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /var/bind /var/qmail/alias /var/qmail/control /var/spool/torque /var/vpopmail/etc"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-O2 -march=pentium4 -mmmx -msse -msse2 -pipe -fno-strict-aliasing -ggdb"
DISTDIR="/usr/portage/distfiles"
FEATURES="distlocks fixpackages metadata-transfer nostrip parallel-fetch protect-owned sandbox sfperms splitdebug strict unmerge-orphans userfetch"
GENTOO_MIRRORS="http://gentoo.mirror.web4u.cz"
LDFLAGS="-Wl,-O1"
LINGUAS="en cs cz"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage/layman/sunrise /usr/local/portage/layman/java-overlay /usr/local/portage/layman/science /usr/local/portage /usr/local/java-experimental /usr/local/portage/layman/java-overlay"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="7zip R X Xaw3d a52 aac aalib ace acl acpi alsa amr amrnb amrwb apache2 audacious audiofile bash-completion bcmath berkdb blas bluetooth boost branding bzip2 cairo cblas cddb cdparanoia cdr clamav cli colordiff compress cpio cracklib crypt cscope css ctype cups curl curlwrappers cxx dbus dga dia directfb djbfft dri dts dv dvb dvd dvdr dvdread eds emacs emboss emf enblend encode enscript exif expat fam fame fat fbcon ffmpeg fftw firefox flac flash foomaticdb fortran fpx ftp gcj gd gdbm ggi gif gimp gimpprint glibc-compat20 glibc-omitfp glut gmp gnuplot gnutls gpgme gphoto2 gpm graphviz gs gsl gstreamer gtk gtkhtml hal hdf hdf5 hp2xx i8x0 icc iconv icu id3 ieee1394 ifc imagemagick imlib inifile innodb isdnlog ithreads jack java javascript jbig jce jikes jpeg jpeg2k kdtree kerberos lame lapack laptop lcms leim libcaca libedit libnotify libwww live lzo lzw mad maildir matroska mhash midi mikmod mime ming mjpeg mmap mmx mng mod_python modperl modplug motif mozilla moznoirc mp2 mp3 mp4 mpeg mpi mpi_njtree mpich2 mplayer mudflap mule musepack mxdatetime mysql mysqli ncurses netcdf netpbm network nls nntp nptl nptlonly nsplugin ntfs numeric ogg opengl openmp pam pango pcmcia pcntl pcre pdf perl plotutils plugin png pnm postproc postscript ppds pppd procmail pymol python qt3 qt3support qt4 quicktime rar raw readline recode reflection reiserfs rpm samba sasl scanner scp seamonkey server session sftp sift slp smime sndfile soap sockets spell spl sqlite srt sse sse2 ssl startup-notification subtitles subversion svg svgz sysfs sysvipc t1lib tcl tcpd tetex theora threads tidy tiff tk transcode truetype unicode urandom usb userlocales uuencode v4l v4l2 vcd vhook vim-syntax vim-with-x vorbis wifi win32codecs wmf wxwindows x264 x86 xanim xcf xfs xft xinetd xml xorg xpm xprint xsl xslt xulrunner xv xvid xvmc yv12 zip zlib" ALSA_CARDS="intel-8x0m" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic auth_digest authn_anon authn_dbd authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dbd deflate dir disk_cache env expires ext_filter file_cache filter headers ident imagemap include info log_config mem_cache mime mime_magic rewrite setenvif speling status unique_id userdir usertrack vhost_alias negotiation" ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en cs cz" USERLAND="GNU" VIDEO_CARDS="radeon vesa"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, LANG, LC_ALL, MAKEOPTS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

Comment 14 Martin Mokrejš 2009-03-02 18:41:56 UTC
Created attachment 183696 [details]
build.log
Comment 15 Justin Lecher (RETIRED) gentoo-dev 2009-03-07 08:39:07 UTC
vte dep is fixed in overlay.
Comment 16 Martin Mokrejš 2009-03-11 15:39:55 UTC
(In reply to comment #15)
> vte dep is fixed in overlay.
> 

Confirming. For me it compiles fine on ~x86.
Comment 17 Vytautas 2009-12-02 08:49:14 UTC
Any progress here?
Comment 18 Justin Lecher (RETIRED) gentoo-dev 2009-12-02 09:19:45 UTC
(In reply to comment #17)
> Any progress here?
> 

It's in the sci overlay.
Comment 19 Martin Mokrejš 2009-12-03 22:46:58 UTC
(In reply to comment #16)
> (In reply to comment #15)
> > vte dep is fixed in overlay.
> > 
> 
> Confirming. For me it compiles fine on ~x86.
> 

And really works for me on ~x86 (re-tested now again).