Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 237815 - [PATCH] sys-kernel/kerneloops should only depend on libnotify if USE="gtk"
Summary: [PATCH] sys-kernel/kerneloops should only depend on libnotify if USE="gtk"
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Greg Kroah-Hartman (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-16 08:19 UTC by Xake
Modified: 2009-08-24 21:33 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
pkg-config should only get for what is needed for the target (kerneloops-makefile.patch,1.36 KB, patch)
2008-09-16 08:22 UTC, Xake
Details | Diff
ebuild (kerneloops-0.12.ebuild,1.86 KB, text/plain)
2008-09-16 16:34 UTC, Toralf Förster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xake 2008-09-16 08:19:30 UTC
This is simply a follow upon bug #206653

The patch attached modifies the Makefile to add the content of `pkg-config --cflags libnotify gtk+-2.0` if target is kerneloops-applet, and the content of `pkg-config --cflags glib-2.0 dbus-glib-1` if target is kerneloops.

Tested and works for me.
Comment 1 Xake 2008-09-16 08:22:12 UTC
Created attachment 165550 [details, diff]
pkg-config should only get for what is needed for the target
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2008-09-16 08:55:15 UTC
# ChangeLog for sys-kernel/kerneloops
# Copyright 1999-2008 Gentoo Foundation; Distributed under the GPL v2
# $Header: /var/cvsroot/gentoo-x86/sys-kernel/kerneloops/ChangeLog,v 1.12 2008/09/15 22:38:48 gregkh Exp $

*kerneloops-0.12 (15 Sep 2008)

  15 Sep 2008; Greg Kroah-Hartman <gregkh@gentoo.org> metadata.xml,
  +kerneloops-0.12.ebuild:
  0.12 release. Removed -gtk option, too much of a pain to try to build
  without applet portion, so am giving up.
Comment 3 Toralf Förster gentoo-dev 2008-09-16 16:34:27 UTC
Created attachment 165568 [details]
ebuild

That ebuild works for me w/o using gtk.
Comment 4 Xake 2008-09-16 19:32:34 UTC
@gregkh

Is it clear what my patch does, or is there something apparently wrong with it?
I run this thing on a headless server, so for me it is somewhat important to not need libnotify and gtk+ as it for the deamon is not necessary and just "bloats" my install. So if there is anything that needs clarification, just shout at me.:-)


And why not use "all"/"install" and "noui"/"install-noui" when invoking make, instead of the kerneloops* targets?
Comment 5 Alois Hammer 2008-09-17 15:42:25 UTC
There appears to be a new kerneloops-0.12 ebuild with a -gtk USE flag, but attempting to build it on an X-less system triggers an unsatisfiable dependency on pango...
Comment 6 Xake 2008-09-17 16:09:28 UTC
(In reply to comment #5)
> There appears to be a new kerneloops-0.12 ebuild with a -gtk USE flag, but
> attempting to build it on an X-less system triggers an unsatisfiable dependency
> on pango...
> 

What is that version from? According to http://sources.gentoo.org there ain't a 0.12 ebuild with any optional gtk support at all. 
Comment 7 Xake 2008-09-27 18:44:05 UTC
@gregkh

If you do not have the time to look at this, will you please direct me to the current upstream maintainer or bugtracker/mailinglist so I may annoy them with patches?;)
Comment 8 Greg Kroah-Hartman (RETIRED) gentoo-dev 2008-09-29 23:07:42 UTC
upstream is at kerneloops.org
Comment 9 Xake 2008-09-30 12:04:39 UTC
Sorry but I can not see any link to a bug-reporting facility or a mailinglist or anything.
Comment 10 Peter Alfredsen (RETIRED) gentoo-dev 2008-12-10 15:40:04 UTC
(In reply to comment #9)
> Sorry but I can not see any link to a bug-reporting facility or a mailinglist
> or anything.
> 
It's my understanding that Arjan van de Ven <arjan@infradead.org> has to do with kerneloops.org. Correct me if I'm wrong.
Comment 11 Xake 2008-12-10 23:35:10 UTC
(In reply to comment #10)
> (In reply to comment #9)
> > Sorry but I can not see any link to a bug-reporting facility or a mailinglist
> > or anything.
> > 
> It's my understanding that Arjan van de Ven <arjan@infradead.org> has to do
> with kerneloops.org. Correct me if I'm wrong.
> 

I got that impresssion too. Sent him an email with the patch. Never got an answear.
Comment 12 Xake 2009-08-21 16:54:33 UTC
Got no answears, have sent mail two times. Will wait for a new release before trying anything again.
Comment 13 Greg Kroah-Hartman (RETIRED) gentoo-dev 2009-08-24 21:33:43 UTC
Ok, thanks for letting us know.

I'm going to close this out for now.