Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 237616 - Kbuild: Make KBUILD_EXTRA_SYMBOLS working
Summary: Kbuild: Make KBUILD_EXTRA_SYMBOLS working
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL: http://bugzilla.kernel.org/show_bug.c...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-14 10:22 UTC by Peter Volkov (RETIRED)
Modified: 2008-10-30 05:59 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
linux-2.6-KBUILD_EXTRA_SYMBOLS.patch (linux-2.6-KBUILD_EXTRA_SYMBOLS.patch,616 bytes, patch)
2008-09-14 10:22 UTC, Peter Volkov (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Volkov (RETIRED) gentoo-dev 2008-09-14 10:22:04 UTC
If you even define KBUILD_EXTRA_SYMBOLS in Makefile for modules it will not be expanded into command line argument for modpost.

KBUILD_EXTRA_SYMBOLS help helps to fix undefined symbols errors when CONFIG_MODVERSIONS is set and CONFIG_MODULE_FORCE_LOAD is not set.
Comment 1 Peter Volkov (RETIRED) gentoo-dev 2008-09-14 10:22:39 UTC
Created attachment 165385 [details, diff]
linux-2.6-KBUILD_EXTRA_SYMBOLS.patch

This patch fixes the problem here.
Comment 2 Daniel Drake (RETIRED) gentoo-dev 2008-10-28 23:22:29 UTC
Where did the patch come from? It does not seem to have been applied upstream.
Comment 3 Daniel Drake (RETIRED) gentoo-dev 2008-10-28 23:22:50 UTC
wrongly reassigned this one
Comment 4 Peter Volkov (RETIRED) gentoo-dev 2008-10-29 08:28:06 UTC
(In reply to comment #2)
> Where did the patch come from?

From me.

> It does not seem to have been applied upstream.

It's still not in linus tree but it was included in mm tree and although I've tried to mail this patch to linux-kernel as Andrew Morton told me to do I've seen no reaction on my mail. 25 Oct 2008 I've received mail from 
akpm AT linux-foundation.org to me, Sam Ravnborg and again akpm with this patch inside, but I have no ideas on intentions of that mail...


But that's said, I've found that although this KBUILD_EXTRA_SYMBOLS is broken it's not required for madwifi-ng. That's why I think we can wait that one day somebody finally fixes this issue UPSTREAM and that's how we'll get fixed version in Gentoo. I think currently there is no need for our kernel team to spend time on this issue. Resolving as UPSTREAM.
Comment 5 Peter Volkov (RETIRED) gentoo-dev 2008-10-30 05:59:01 UTC
And now I've received copy of mail from Sam Ravnborg to Linus Torvalds which is pull request where this patch is included. So this fix is closer to became included upstream AFAIU. The fun note is that this pull request includes two patches from Gentoo developers:

Mike Frysinger (1):
      kbuild: setlocalversion: dont include svn change count

Peter Volkov (1):
      kbuild: fix KBUILD_EXTRA_SYMBOLS

Gentoo is still working with upstream to make our distribution better:)