Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 237606 - =mail-filter/dspam-3.8.0-r13 flags for --enable-debug and --enable-verbose-debug inadequate
Summary: =mail-filter/dspam-3.8.0-r13 flags for --enable-debug and --enable-verbose-de...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Alin Năstac (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-14 07:58 UTC by calvin
Modified: 2008-10-05 08:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Updated dspam-3.8.0 ebuild with separate debug flags (dspam-3.8.0-r14.ebuild,19.34 KB, text/plain)
2008-09-14 23:51 UTC, calvin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description calvin 2008-09-14 07:58:06 UTC
The mail-filter/dspam (3.8.0-r13) ebuild has a single 'debug' USE flag that can be enabled. Selecting that USE flag results in both --enable-debug and --enable-verbose-debug being selected during configure (as well as --enable-bnr-debug).

A single debug USE flag should not enable all of these. In particular, --enable-debug is extremely useful, since the user can select what debug info is logged at runtime.  --enable-verbose-debug on the other hand is a whole lot less useful. The dspam documentation say that it should NEVER be compiled with that option for production builds because it results in so much debug stuff happening that it seriously impacts efficiency. This means that if one needs debug output in a production environment, one has to recompile dspam and reinstall it, and then after debugging the problem, recompile and reinstall it again in order to avoid the penalty of --enable-verbose-debug.

I think the "debug" flag should just enable the normal debug (--enable-debug) configure option, which is very useful to a broad audience since it allows one to tweak how much (if any) debugging occurs at runtime. 

The verbose option, on the other hand, should definitely not be included in the normal "debug" USE flag. Perhaps another flag called something like "debug-all" could be added, which would enable all other debug options, or perhaps it should just be left for people to use via EXTRA_ECONF.

Reproducible: Always
Comment 1 calvin 2008-09-14 23:51:43 UTC
Created attachment 165437 [details]
Updated dspam-3.8.0 ebuild with separate debug flags

Here is an ebuild that I bumped to r14 from r13 for this version of dspam. The only difference is that I added "debug-bnr" and "debug-verbose" USE flags. The plain "debug" flag just enables the normal debug, while "debug-bnr" enables "nbr-debug" and "debug-verbose" enables "verbose-debug".

I'm not sure what you want to do in the long term, but for anybody else who just wants to be able to install this version of dspam with normal debugging enabled and without the other (expensive) debugging enabled, this does the trick.
Comment 2 Alin Năstac (RETIRED) gentoo-dev 2008-10-05 08:41:51 UTC
Fixed in dspam-3.8.0-r15.