Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 23742 - subversion 0.24.1 - use apache instead of use apache2 in ebuild
Summary: subversion 0.24.1 - use apache instead of use apache2 in ebuild
Status: RESOLVED LATER
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Joshua Brindle (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-06-30 02:01 UTC by Michael Kefeder
Modified: 2003-07-22 07:27 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch against old ebuilds that addresses this problem (subversion.diff,3.73 KB, patch)
2003-07-20 10:36 UTC, ajs
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Kefeder 2003-06-30 02:01:01 UTC
i recently tried to install subversion server with gentoo, it worked but it 
didn't install the apache .conf file for the mod_dav_svn module - reason: in 
line 184 there's just a 'if use apache;' instead of 'if use apache2;' statement. 
i think this is a bug because the use of the apache2 flag is forced for building 
the module - if the check for the apache flag is done on purpose i want to know 
why. BTW probably wrong apache checks are also at lines 206 and 217.

i was using $Header: /home/cvsroot/gentoo-x86/dev-util/subversion/subversion-0.
24.1.ebuild,v 1.5 2003/06/26 20:17:17 pauldv Exp $


Reproducible: Always
Steps to Reproduce:
1. build subversion
2. no .conf file in /etc/apache2/conf/modules.d
Comment 1 Joshua Brindle (RETIRED) gentoo-dev 2003-07-02 08:43:34 UTC
subversion requires apache 2 for serving, so you must have apache 2 installed and set the apache2 use flag, requiring apache-2 and using the apache use flag is bad because some ebuilds use apache|apache2 for creating dependancies and you'll end up with both apache-1 and apache-2 on your system
Comment 2 Michael Kefeder 2003-07-04 23:57:13 UTC
the point of my report is that having to use the apache use flag is wrong for subversion. it should be apache2 only, but in the .ebuild there are checks for "apache" instead of "apache2" which stops the ebuild from adding the module loading code and the default config even when (or because) somebody uses USE="apache2". USE="apache2" is quite useful to install subversion to an existing apache2 server, that's why i think the checks for the apache flag are wrong - they need to check for the apache2 flag instead. IMO it is non-intuitive to set USE="apache apache2" to get configs installed to apache2 (the only server where svn works - the apache flag makes no sense).
I hope my english knowledge was able explain my point a bit clearer now ;-)
Comment 3 ajs 2003-07-20 10:36:09 UTC
Created attachment 14780 [details, diff]
Patch against old ebuilds that addresses this problem

I've attached a patch against the old ebuilds that addresses the problem
mentioned in this bug. The bug was introduced in the 0.22.2 ebuild and
persisted until the 0.24.1 ebuild. These ebuilds should either be revised or
removed; they are broken.

Also note that the ebuilds since 0.24.2 don't have the same problem.

 - Andrew
Comment 4 Paul de Vrieze (RETIRED) gentoo-dev 2003-07-22 07:27:30 UTC
I will clean up the directory with the next subversion release. Note that the subversion people recommend the use of the latest version.