Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 23689 - Unable to compile thinkpad-4.3
Summary: Unable to compile thinkpad-4.3
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-06-29 05:34 UTC by Andrea Cerrito
Modified: 2003-06-29 11:02 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrea Cerrito 2003-06-29 05:34:49 UTC
I can't compile thinkpad-4.3 (-r1?). Makefile in 2.4/drivers has wrong includes.




Reproducible: Always
Steps to Reproduce:
1. use kernel 2.4.x
2. emerge thinkpad
3.

Actual Results:  
cerrito / # emerge -U thinkpad tpctl xfree-drm
>>> --upgradeonly implies --update... adding --update to options.
Calculating dependencies ...done!
>>> emerge (1 of 3) sys-apps/thinkpad-4.3-r1 to /
>>> md5 src_uri ;-) thinkpad_4.3.tar.gz
>>> Unpacking source...
>>> Unpacking thinkpad_4.3.tar.gz to /home/portage/thinkpad-4.3-r1/work
>>> Source unpacked.
make -C drivers
make[1]: Entering directory
`/home/portage/thinkpad-4.3-r1/work/thinkpad-4.3/2.4/drivers'
make[1]: warning: jobserver unavailable: using -j1.  Add `+' to parent make rule.
gcc -I/lib/modules/2.4.21/build/include -I../include -Wall -Wcast-align
-Wstrict-prototypes -DLINUX -O2 -o thinkpad.o -c thinkpad.c
In file included from thinkpad.c:41:
../include/thinkpad_driver.h:45:31: linux/modversions.h: No such file or directory
make[1]: *** [thinkpad.o] Error 1
make[1]: Leaving directory
`/home/portage/thinkpad-4.3-r1/work/thinkpad-4.3/2.4/drivers'
make: *** [all] Error 2

Expected Results:  
Compile ok.

This is the patch.
--- Makefile    2002-08-07 03:06:52.000000000 +0200
+++ Makefile-ok 2003-06-29 14:32:14.000000000 +0200
@@ -7,7 +7,7 @@
 KSRC=$(DIR_MODULES_VER)/build
 endif
 
-CFLAGS := -I$(KSRC)/include -I../include -Wall -Wcast-align -Wstrict-prototypes
-DLINUX -O2
+CFLAGS := -I$(KSRC)/include -I/usr/src/linux/include -I../include -Wall
-Wcast-align -Wstrict-prototypes -DLINUX -O2
 
 thinkpad.o: thinkpad.c ../include/thinkpad_common.h
../include/thinkpad_driver.h ../include/thinkpad.h
        $(CC) $(CFLAGS) -o $@ -c thinkpad.c



==emerge info
cerrito drivers # emerge info
Portage 2.0.48-r1 (default-x86-1.4, gcc-3.2.3, glibc-2.3.2-r1)
=================================================================
System uname: 2.4.21 i686 Intel(R) Pentium(R) III Mobile CPU      1200MHz
GENTOO_MIRRORS="http://212.219.56.162/sites/www.ibiblio.org/gentoo/
http://194.83.57.2/sites/www.ibiblio.org/gentoo/
http://194.83.57.3/sites/www.ibiblio.org/gentoo/
http://ftp.snt.utwente.nl/pub/os/linux/gentoo
ftp://ftp.flashnet.it/mirror/12/sunsite.unc.edu/Gentoo
http://ibiblio.org/pub/Linux/ftp.edisontel.com/pub/Sunsite_Mirror
http://sunsite.cnlab-switch.ch/ftp/mirror/gentoo
ftp://sunsite.cnlab-switch.ch/mirror/gentoo
http://www.ibiblio.org/pub/Linux/distributions/gentoo
http://gentoo.oregonstate.edu "
CONFIG_PROTECT="/etc /var/qmail/control /usr/kde/2/share/config
/usr/kde/3/share/config /usr/X11R6/lib/X11/xkb /usr/kde/3.1/share/config
/usr/share/config"
CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d"
PORTDIR="/home/portdir"
DISTDIR="/home/portdir/distfiles"
PKGDIR="/home/portdir/packages"
PORTAGE_TMPDIR="/home"
PORTDIR_OVERLAY=""
USE="3dnow mikmod aalib tcltk guile sdl perl gtk qt gphoto2 x86 oss acpi acl
alsa apm avi berkdb bonobo cdr crypt cups directfb dga dvd encode gdbm gif gpm
fbcon krb4 kerberos imlib java jpeg gnome gtk2 gtkhtml libg++ libwww miknod mmx
motif mozilla mpeg ncurses nls oggvorbis opengl pam pdflib png pnp python
quicktime radeon readline samba slang spell sse ssl svga tcpd truetype usb X
xml2 xmms xv zlib kde arts -esd"
COMPILER="gcc3"
CHOST="i686-pc-linux-gnu"
CFLAGS="-march=pentium3 -mfpmath=sse -O2 -pipe -fomit-frame-pointer -mmmx -msse
-falign-functions=4 -fforce-addr"
CXXFLAGS="-march=pentium3 -mfpmath=sse -O2 -pipe -fomit-frame-pointer -mmmx
-msse -falign-functions=4 -fforce-addr"
ACCEPT_KEYWORDS="x86 ~x86"
MAKEOPTS="-j2"
AUTOCLEAN="yes"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
FEATURES="sandbox ccache"
Comment 1 Andrea Cerrito 2003-06-29 05:37:25 UTC
Sorry.
Ignore this bug report and change its status.
Comment 2 Martin Holzer (RETIRED) gentoo-dev 2003-06-29 11:02:08 UTC
cd /usr/src/linux
make dep modules