Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 236816 - Don't complain about non-bash code in /etc/portage/bashrc
Summary: Don't complain about non-bash code in /etc/portage/bashrc
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-05 22:09 UTC by Erik Hahn
Modified: 2008-09-07 16:03 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Hahn 2008-09-05 22:09:38 UTC
If you use non-bash code (e.g. sed) in /etc/portage/bashrc, emerge claims you've used it in the ebuild (QA notice). To my understanding, this shouldn't happen as there's no reason to avoid external programs in bashrc.

Reproducible: Always

Steps to Reproduce:
1.Put non-bash code in /etc/portage/bashrc
2.Emerge something


Actual Results:  
Emerge complains about  the non-bash code

Expected Results:  
No complaints.
Comment 1 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2008-09-05 22:11:59 UTC
hmm, we will need to know what portage version you are using as well. thanks.
Comment 2 Erik Hahn 2008-09-05 22:25:18 UTC
Portage version is 2.2_rc8
Comment 3 Zac Medico gentoo-dev 2008-09-07 16:03:05 UTC
If you're triggering that QA notice then it means you've called sed in global scope, which has performance implications and also suggests that you've called it at the wrong time.

If you need to call sed then the call should either be conditional on the $EBUILD_PHASE or else use one of the phase hooks that are documented in the html docs if you install portage with USE=doc enabled. For example:

if [ $EBUILD_PHASE = compile ] ; then
 sed ... 
fi

or

post_src_unpack() {
 sed ...
}