Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 23669 - net-analyzer/nagios-core should be more configurable
Summary: net-analyzer/nagios-core should be more configurable
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Michael Boman (RETIRED)
URL:
Whiteboard:
Keywords: EBUILD
: 31731 (view as bug list)
Depends on: 20617
Blocks:
  Show dependency tree
 
Reported: 2003-06-28 21:49 UTC by Michael Boman
Modified: 2004-01-27 03:51 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Added few more features (diff-nagios-core-1.1-r3.ebuild,6.29 KB, patch)
2003-07-09 17:43 UTC, Jasmine Chua
Details | Diff
patch for earlier attachment (diff-nagios-core-1.1-r3.ebuild,5.86 KB, patch)
2003-07-20 22:22 UTC, Jasmine Chua
Details | Diff
patch for earlier attachment (diff-nagios-core-1.1-r3.ebuild,5.86 KB, patch)
2003-07-20 22:22 UTC, Jasmine Chua
Details | Diff
net-analyzer/nagios-core-1.1-r3.ebuild (nagios-core-1.1-r3.ebuild,4.75 KB, text/plain)
2003-07-30 09:07 UTC, Jasmine Chua
Details
net-analyzer/nagios-core-1.1-r3.ebuild (nagios-core-1.1-r3.ebuild,4.87 KB, text/plain)
2003-08-11 06:31 UTC, Jasmine Chua
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Boman 2003-06-28 21:49:12 UTC
Local USE flags should be used to decide if you want to install the CGI's or
not. On a distributed installation you don't need or want a webserver with cgi's
on. There is already a bug against the dependency of apache, bug id 20617.
Comment 1 Michael Boman 2003-06-28 21:50:52 UTC
Graphical cgi's should only be compiled if USE="gd" is set.
Comment 2 Jasmine Chua 2003-07-09 17:43:06 UTC
Created attachment 14325 [details, diff]
Added few more features

USE="mysql -pgsql" will log data into mysql - status: tested.
USE="-mysql pgsql" needs to be confirmed - status: not yet tested.
Debugging features (debug0 - 5 ) are also available.

Ebuild can still be better improved by providing file-based performance data
routines feature, which I haven't look at it yet. Please re-confirm what I have
done and change from ~x86 to x86 once ebuild is checked. Thanks!
Comment 3 Kurt Lieber (RETIRED) gentoo-dev 2003-07-19 14:09:40 UTC
comments on Jasmine's ebuild:

s/IUSE="gd apache2 perl"/IUSE="gd apache2 perl mysql pgsql"/
s/KEYWORDS="x86 ~sparc ~ppc"/KEYWORDS="~x86 ~sparc ~ppc"

also, the ">= apache-1.3.27-r3" in the gd? section seems to conflict with apache2,  I believe because the two are slotted differently.
Comment 4 Kurt Lieber (RETIRED) gentoo-dev 2003-07-20 16:50:24 UTC
Jasmine: 

Regarding your patch, if I'm reading it correctly, you're using the gd USE flag to determine whether or not /usr/nagios/(share|sbin) should be deleted.  Is this reasonable?  Seems like there might be cases where you didn't want GD, but still wanted to have the web interface to nagios. 

If I'm misunderstanding something, please let me know.
Comment 5 Jasmine Chua 2003-07-20 22:22:29 UTC
Created attachment 14792 [details, diff]
patch for earlier attachment 

good point spotted! Thanks! apache2 does conflict with gd in the earlier
attachment. 
Current changes made:
"USE= gd" will include web interface with apache1 
"USE= gd apache2" will include web interface with apache2
Else by default no web interface.
Comment 6 Jasmine Chua 2003-07-20 22:22:36 UTC
Created attachment 14793 [details, diff]
patch for earlier attachment 

good point spotted! Thanks! apache2 does conflict with gd in the earlier
attachment. 
Current changes made:
"USE= gd" will include web interface with apache1 
"USE= gd apache2" will include web interface with apache2
Else by default no web interface.
Comment 7 Russell Smith 2003-07-22 21:08:43 UTC
Along with these patches, the source URI is not globally accessible.

SRC_URI="mirror://sourceforge/nagios/nagios-1.1.tar.gz"


and IUSE still does not have mysql or pgsql listed.

I would also find it important to tell the user that USE="gd" needs to be defined to install the web interface.  I had to read the ebuild source.  Not all that nice for all users.
Comment 8 Jasmine Chua 2003-07-30 09:07:26 UTC
Created attachment 15230 [details]
net-analyzer/nagios-core-1.1-r3.ebuild 

This is a full nagios-core ebuild. 
pgsql == postgres && IUSE is already set to "gd apache2 perl mysql postgres
debug"	in earlier attachment. 
I think SRC_URI is globally accessible and dont see the problem there too.  
Ok I have added comments to inform user to compile with USE="gd" if web
interface is required.
Comment 9 Christian Gut 2003-08-01 04:44:19 UTC
ok, that -r3 ebuild is pretty damn broken and its unmasked!

1. IUSE is not declarated correctly, pgsql and mysql are missing.
2. Changelog is missing! Nothing about the -gd thing in there
3. your are compiling the cgis and then _afterwards_ deleting it. thats even crazy i think.

klieber, i think you should have tested this before going stable. Its damn ugly to get this happening in stable.
Comment 10 Joshua Brindle (RETIRED) gentoo-dev 2003-08-03 20:51:54 UTC
Ok, i'll try to be a bit more constructive but Christian is absolutely right
IUSE is missing mysql pgsql debug[0-5]
                rm -rf ${D}/usr/nagios/{sbin,share}/*
is where i think he's saying the cgi's are being deleted, this is acceptable but it'd be way prettier to sed the Makefile and not waste processor cycles compiling something that is just going to be deleted

the real kicker though, is that debug[0-5] isn't in use.local.desc, i'm not even sure how this got into portage.. 

looks like -r4 has the same problems, only the installation is tweaked in it

it also looks like most of the above comments were ignored.. *shrug*

Comment 11 Jasmine Chua 2003-08-11 06:31:32 UTC
Created attachment 15905 [details]
net-analyzer/nagios-core-1.1-r3.ebuild

The nagios-core-1.1-r3.ebuild attached is tested and worked. Please feel free
to look at it.
Comment 12 Brian Jensen 2003-10-22 13:15:28 UTC
*** Bug 31731 has been marked as a duplicate of this bug. ***
Comment 13 Michael Boman (RETIRED) gentoo-dev 2004-01-27 03:48:15 UTC
Sorry to bark in like this, but I just had to do this. Suddenly I had a irristable itch I just _had_ to scratch. You can find nagios-1.1-r5 on the mirrors shortly. I have introduced a "noweb" local USE flag. If that flag is set no HTML/CGI will be installed.

I also added a metadata.xml to it, stating that I'll take the fame and blame for the meantime until someone else steps up to take propper care of it.
Comment 14 Michael Boman (RETIRED) gentoo-dev 2004-01-27 03:51:15 UTC
Can't take ownership and close the bug at the same time...