Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 236439 - media-video/totem: workaround for solving upstream bug causing bad hue adjustement to be used with nvidia-drivers
Summary: media-video/totem: workaround for solving upstream bug causing bad hue adjust...
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: http://www.nvnews.net/vbulletin/showp...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-02 11:55 UTC by Pacho Ramos
Modified: 2009-05-12 06:17 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
totem.ebuild.diff (totem.ebuild.diff,843 bytes, text/plain)
2008-09-02 11:59 UTC, Pacho Ramos
Details
totem-nvidia-hue-workaround.patch (totem-nvidia-hue-workaround.patch,1.47 KB, patch)
2008-09-02 12:04 UTC, Pacho Ramos
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2008-09-02 11:55:59 UTC
I suffered some problems with default hue value chosen by totem, the videos were seen turned to blue colours, I already reported it to upstream:
http://bugzilla.gnome.org/show_bug.cgi?id=550194

The problem is important, from my point of view, because totem causes other apps to also fails until I restart X.

The main bug is:
http://bugzilla.gnome.org/show_bug.cgi?id=306621

nvidia people think that this isn't their fault:
http://nvnews.net/vbulletin/showthread.php?t=114369

and they think that it's a totem one. 

I know that gentoo tries to keep as close to upstream as posible and generally would prefer fix bugs instead of simply workarounding then, but http://bugzilla.gnome.org/show_bug.cgi?id=306621 is more than three years old and I don't have enough knowledge for fixing it in totem (I don't know anything about programming), then I would want see this workarounded by default in gentoo as nvidia cards and drivers are commonly used and, even not affecting to all cards (simply because user cannot modify hue or other parameters like brightness or color) nvidia does its drivers for use 0% instead of 50% as default

Thanks a lot, I will attach a patch + ebuild I have prepared for this

Reproducible: Always
Comment 1 Pacho Ramos gentoo-dev 2008-09-02 11:59:06 UTC
Created attachment 164348 [details]
totem.ebuild.diff

The new ebuild simply adds a video_cards_nvidia USE flag. I prefer use "video_cards_nvidia" instead of simply "nvidia" because first is being already used by xorg-server ebuild for, for example, pulling nvidia-drivers dep, then, most nvidia users have "nvidia" under "VIDEO_CARDS" variable in out /etc/make.conf

Later, I apply patch when this flag is detected
Comment 2 Pacho Ramos gentoo-dev 2008-09-02 12:04:19 UTC
Created attachment 164350 [details, diff]
totem-nvidia-hue-workaround.patch

In the patch I change the following:
1. I modify totem.schemas for using "1" as default hue value instead of "32767" (50%)
2. I modify data/totem.ui in the same way (anyway I am not sure if it's fully required :-/)
3. I modify src/totem-preferences.c for making "Reset to defaults" button reset to 0 ONLY for hue level (as other levels are fine at 50%)
I can only set it to 65535/65535 (this is why I use "1" instead of "0") because if I use simply "0" or "0/1" it simply doesn't work :-(

I know that this last part can be improved as I don't know enough for making it much better, but, at least, seems to work fine :-) If you think can be done better, feel free to modify it and, if possible (if you don't have time, don't worry) explain me the changes (only for curiosity)

Thanks a lot
Comment 3 Gilles Dartiguelongue (RETIRED) gentoo-dev 2008-09-02 14:11:11 UTC
I'm pretty opposed to changing software that works right for bugs _introduced_by_ closed source softwares.
Comment 4 Arun Raghavan (RETIRED) gentoo-dev 2009-01-06 18:49:03 UTC
(In reply to comment #3)
> I'm pretty opposed to changing software that works right for bugs
> _introduced_by_ closed source softwares.

I agree (despite the fact that I use these drivers). Any objections to marking WONTFIX?
Comment 5 Pacho Ramos gentoo-dev 2009-01-06 19:25:50 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > I'm pretty opposed to changing software that works right for bugs
> > _introduced_by_ closed source softwares.
> 
> Any objections to marking
> WONTFIX?
> 
Yes, my objections. I am unsure about totem really working fine, as seems that xine or mplayer are not affected at all. But, anyway, it doesn't work fine with nvidia drivers, and both upstreams think that their software works fine... Also, will be harder to workaround this in nvidia-drivers instead of totem :-/
Comment 6 Daniel Gryniewicz (RETIRED) gentoo-dev 2009-01-07 01:50:44 UTC
No objections from me.
Comment 7 Arun Raghavan (RETIRED) gentoo-dev 2009-03-08 17:57:44 UTC
There seems to be some movement from NVidia towards fixing this:

http://www.nvnews.net/vbulletin/showthread.php?p=1913036#post1913036

Also, the patch on another upstream bug might work in a less intrusive way:

http://bugzilla.gnome.org/show_bug.cgi?id=567279

I'm not able to reproduce the problem here, but if someone is willing to confirm that this (far less obtrusive) patch does the trick, I can commit.
Comment 8 Pacho Ramos gentoo-dev 2009-03-08 18:08:24 UTC
I am also following both and will of course test again when 2.24 hits stable (sorry but I will wait for getting 2.24 stabilized)
Comment 9 Frederic LIETART 2009-03-16 11:18:23 UTC
fred@debora ~ $ nautilus network:///
Erreur : DBus error org.freedesktop.DBus.Error.NoReply: Message did not receive a reply (timeout by message bus)
Sélectionnez un autre visionneur et essayez à nouveau.
Comment 10 Pacho Ramos gentoo-dev 2009-03-19 21:38:16 UTC
(In reply to comment #7)
> Also, the patch on another upstream bug might work in a less intrusive way:
> 
> http://bugzilla.gnome.org/show_bug.cgi?id=567279
> 

This bug is related to a different issue about totem not saving user settings when they are set to maximum or minimum (maybe this is why I was needing to default to "1" instead of "0", but I haven't tried it :-/

> I'm not able to reproduce the problem here, but if someone is willing to
> confirm that this (far less obtrusive) patch does the trick, I can commit.
> 

Maybe you are not able to reproduce it because nvidia-drivers doesn't support it for your card. For example, in my case, I only suffer this with a nvidia 8400M because, in others, hue value cannot be modified at all as drivers seems to not support them for this

I have tried to apply attached patch in comment #2 and it still works ok with totem-2.24.3 :-)

Regards!
Comment 11 Pacho Ramos gentoo-dev 2009-05-12 06:17:48 UTC
nVidia has just announced that this should be solved in future 185.xx releases :-D
http://www.nvnews.net/vbulletin/showpost.php?p=2003089&postcount=9