Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 236229 - media-video/avidemux ebuild doesn't handle use-flags correctly
Summary: media-video/avidemux ebuild doesn't handle use-flags correctly
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Ben de Groot (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-30 20:27 UTC by Roberto Castagnola
Modified: 2008-09-24 19:55 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roberto Castagnola 2008-08-30 20:27:51 UTC 
In the media-video/avidemux ebuild we have:
RDEPEND=".
        .
        encode? (
                aac? ( media-libs/faac )
                lame? ( media-sound/lame )
                )
        .
        ."

and:
src_compile() {
        .
        .
        use encode || mycmakeargs="${mycmakeargs} -DNO_Lame=1 -DNO_FAAC=1"
        .
        .
}

Because of this, if media-libs/faac package is installed and USE="encode -aac", avidemux executable is anyway linked to libfaac.so.0. The same if media-sound/lame package is installed and USE="encode -lame".
IMHO this behavior is not correct.


Proposed patch:

-        use encode || mycmakeargs="${mycmakeargs} -DNO_Lame=1 -DNO_FAAC=1"
+        use encode && use aac || mycmakeargs="${mycmakeargs} -DNO_FAAC=1"
+        use encode && use lame || mycmakeargs="${mycmakeargs} -DNO_Lame=1"
Comment 1 Wormo (RETIRED) gentoo-dev 2008-08-30 22:18:50 UTC 
That suggestion makes sense, assigning to maintainers
Comment 2 Ben de Groot (RETIRED) gentoo-dev 2008-09-24 19:55:56 UTC 
Fixed in CVS. Thanks for reporting!