Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 23610 - keepdir doesn't check return status of disk io
Summary: keepdir doesn't check return status of disk io
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Unclassified (show other bugs)
Hardware: All Linux
: High normal
Assignee: Nicholas Jones (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-06-27 11:52 UTC by Mr. Bones. (RETIRED)
Modified: 2011-10-30 22:17 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mr. Bones. (RETIRED) gentoo-dev 2003-06-27 11:52:34 UTC 
keepdir in ebuild.sh calls both dodir and touch without checking the
return values.  *Every* disk operation should be checked to make sure that it
succeeds.

Reproducible: Always
Steps to Reproduce:
1. vi /usr/lib/portage/bin/ebuild.sh

Actual Results:  
See that keepdir can silently fail.

Expected Results:  
See that keepdir will die if the disk operations don't succeed.

Portage 2.0.48-r1 (default-x86-1.4, gcc-3.2.2, glibc-2.3.1-r4)
=================================================================
System uname: 2.4.20-gentoo-r5 i686 Celeron (Covington)
GENTOO_MIRRORS="http://gentoo.oregonstate.edu
http://distro.ibiblio.org/pub/Linux/distributions/gentoo"
CONFIG_PROTECT="/etc /var/qmail/control /usr/share/config
/usr/kde/2/share/config /usr/kde/3/share/config /usr/X11R6/lib/X11/xkb"
CONFIG_PROTECT_MASK="/etc/fonts /usr/X11R6/lib/X11/xkb /etc/X11/serverconfig
/etc/X11/app-defaults /etc/X11/starthere /etc/ssmtp /etc/sound/events
/etc/X11/rstart /etc/X11/xdm /etc/pango /etc/gconf /etc/env.d"
PORTDIR="/home/msterret/gentoo-x86"
DISTDIR="/usr/portage/distfiles"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR_OVERLAY=""
USE="x86 oss 3dnow apm avi crypt cups encode gif jpeg libg++ libwww mikmod mmx
mpeg ncurses pdflib png quicktime slang spell truetype xml2 xmms xv zlib gdbm
berkdb readline java X sdl tcpd pam ssl perl python esd oggvorbis gnome gtk
opengl -svga -doc -dvd -motif -nls -imlib -kde -qt -arts gpm mozilla gtk2 pcmcia"
COMPILER="gcc3"
CHOST="i586-pc-linux-gnu"
CFLAGS="-O3 -mcpu=i586 -pipe"
CXXFLAGS="-O3 -mcpu=i586 -pipe"
ACCEPT_KEYWORDS="x86"
MAKEOPTS="-j2"
AUTOCLEAN="yes"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
FEATURES="sandbox ccache cvs"
Comment 1 Mr. Bones. (RETIRED) gentoo-dev 2003-10-18 00:00:42 UTC 
Looks like the touch is checked now and that should be good enough since
we will fail to create a .keep file if the directory creation failed.

I consider this bug fixed.