236069 – app-emulation/xen-tools-3.3 leaks

Bug 236069 - app-emulation/xen-tools-3.3 leaks

Summary: app-emulation/xen-tools-3.3 leaks

Status:	RESOLVED TEST-REQUEST

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Core system (show other bugs)
Hardware:	All Linux

Importance:	High enhancement (vote)
Assignee:	Gentoo Xen Devs

URL:
Whiteboard:
Keywords:	Inclusion

Depends on:
Blocks:

Reported:	2008-08-28 21:04 UTC by Stefan de Konink
Modified:	2009-04-26 13:22 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Stefan de Konink 2008-08-28 21:04:22 UTC

Signed-off-by: Jim Fehlig <jfehlig@novell.com>


diff -r bd97e45e073a tools/python/xen/xend/XendDomainInfo.py
--- a/tools/python/xen/xend/XendDomainInfo.py	Tue Jul 08 09:28:50 2008 +0100
+++ b/tools/python/xen/xend/XendDomainInfo.py	Thu Jul 10 15:16:57 2008 -0600
@@ -2607,6 +2607,7 @@ class XendDomainInfo:
     def _cleanupVm(self):
         """Cleanup VM resources.  Idempotent.  Nothrow guarantee."""
 
+        self.metrics.destroy()
         self._unwatchVm()
 
         try:



Reproducible: Always

Steps to Reproduce:

Comment 1 Stefan de Konink 2008-08-28 21:43:27 UTC

There is still a problem... with this when I'm looking the output of libvirt.

Comment 2 Stefan de Konink 2008-09-04 01:04:43 UTC

Please apply the above patch to xen-tools-3.3. Annoying memory leaks in python should be fixed. (If the dependency python it self cannot be removed yet ;)

Comment 3 Robert Buchholz (RETIRED) gentoo-dev

2008-09-04 18:55:31 UTC

(In reply to comment #1)
> There is still a problem... with this when I'm looking the output of libvirt.

Can you elaborate please? What is the problem?

Comment 4 Stefan de Konink 2008-09-04 19:03:47 UTC

(In reply to comment #3)
> (In reply to comment #1)
> > There is still a problem... with this when I'm looking the output of libvirt.
> 
> Can you elaborate please? What is the problem?

Ignore, I applied the patch on 3.2. That broke stuff. It was written for 3.3.

This patch doesn't fix everything it is still leaking other stuff. But this is a good measure to actually get it to work longer...

Comment 5 Wolfram Schlich (RETIRED) gentoo-dev

2008-10-10 16:14:34 UTC

after upgrading xen + xen-tools from 3.2.1 to 3.3.0, all
udev rule files are installed and working fine.

Comment 6 Daniel Robbins 2009-04-26 00:34:58 UTC

This appears to be addressed in xen-tools-3.3.1

Comment 7 Patrick Lauer gentoo-dev

2009-04-26 13:22:37 UTC

(In reply to comment #6)
> This appears to be addressed in xen-tools-3.3.1
> 
Please test and reopen if it's still an issue with 3.3.1