235629 – the x-modular eclass doesn't die if make install fails

Bug 235629 - the x-modular eclass doesn't die if make install fails

Summary: the x-modular eclass doesn't die if make install fails

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Donnie Berkholz (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2008-08-24 20:10 UTC by Damien Thébault
Modified:	2008-08-25 17:11 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Patch to fix this problem. (x-modular-eclass-install.patch,413 bytes, patch) 2008-08-24 20:10 UTC, Damien Thébault	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Damien Thébault 2008-08-24 20:10:07 UTC

in src_install, the x-modular eclass doesn't check if make install was successfull or not.

Reproducible: Always

Steps to Reproduce:
1. emerge a package using x-modular and failing make install
Actual Results:  
The install continues, and only a part of the package is installed.

Expected Results:  
Everything should stop.

Comment 1 Damien Thébault 2008-08-24 20:10:50 UTC

Created attachment 163724 [details, diff]
Patch to fix this problem.

Comment 2 Donnie Berkholz (RETIRED) gentoo-dev

2008-08-25 17:11:24 UTC

Fixed, thanks for the report. There's no longer any need for obvious die messages like that because portage has code to automatically show tracebacks.