Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 235496 - dev-lang/icc-10.1.017-r1 - Failed Patch: icc-add-amd64-preprocessor-directives.patch
Summary: dev-lang/icc-10.1.017-r1 - Failed Patch: icc-add-amd64-preprocessor-directive...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Sébastien Fabbro (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-23 03:28 UTC by Erik Zeek
Modified: 2008-08-23 11:45 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge_info.txt,8.95 KB, text/plain)
2008-08-23 03:28 UTC, Erik Zeek
Details
emerge log (dev-lang:icc-10.1.017-r1:20080823-032353.log,1.85 KB, text/plain)
2008-08-23 03:29 UTC, Erik Zeek
Details
epatch ouput (icc-add-amd64-preprocessor-directives.patch-31754.out,3.23 KB, text/plain)
2008-08-23 03:29 UTC, Erik Zeek
Details
icc.diff (icc.diff,668 bytes, patch)
2008-08-23 10:09 UTC, Harald van Dijk (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Zeek 2008-08-23 03:28:01 UTC
The icc-add-amd64-preprocessor-directives.patch fails to apply on my machine.

>>> Emerging (1 of 5) dev-lang/icc-10.1.017-r1
 * l_cc_p_10.1.017_ia32.tar.gz RMD160 SHA1 SHA256 size ;-) ...                                                                                                              [ ok ]
 * checking ebuild checksums ;-) ...                                                                                                                                        [ ok ]
 * checking auxfile checksums ;-) ...                                                                                                                                       [ ok ]
 * checking miscfile checksums ;-) ...                                                                                                                                      [ ok ]
 * Checking for at least 512MBytes RAM ...                                                                                                                                   [ ok ]
 * Checking for at least 300MBytes disk space at ${T} ...                                                                                                                    [ ok ]
>>> Unpacking source...
>>> Unpacking l_cc_p_10.1.017_ia32.tar.gz to /gentoo/tmp/portage/dev-lang/icc-10.1.017-r1/work
 * Extracting intel-icc101017-10.1.017-1.i386.rpm...
 * Extracting intel-isubh101017-10.1.017-1.i386.rpm...
 * Applying icc-add-amd64-preprocessor-directives.patch ...

 * Failed Patch: icc-add-amd64-preprocessor-directives.patch !
 *  ( /gentoo/portage/dev-lang/icc/files/icc-add-amd64-preprocessor-directives.patch )
 *
 * Include in your bugreport the contents of:
 *
 *   /gentoo/tmp/portage/dev-lang/icc-10.1.017-r1/temp/icc-add-amd64-preprocessor-directives.patch-31754.out

 *
 * ERROR: dev-lang/icc-10.1.017-r1 failed.
 * Call stack:
 *               ebuild.sh, line   49:  Called src_unpack
 *             environment, line 2280:  Called epatch '/gentoo/portage/dev-lang/icc/files/icc-add-amd64-preprocessor-directives.patch'
 *             environment, line 1252:  Called die
 * The specific snippet of code:
 *                   die "Failed Patch: ${patchname}!";
 *  The die message:
 *   Failed Patch: icc-add-amd64-preprocessor-directives.patch!
 *
 * If you need support, post the topmost build error, and the call stack if relevant.
 * A complete build log is located at '/var/log/portage/dev-lang:icc-10.1.017-r1:20080823-032353.log'.
 * The ebuild environment file is located at '/gentoo/tmp/portage/dev-lang/icc-10.1.017-r1/temp/environment'.
 *
Comment 1 Erik Zeek 2008-08-23 03:28:34 UTC
Created attachment 163593 [details]
emerge --info
Comment 2 Erik Zeek 2008-08-23 03:29:01 UTC
Created attachment 163594 [details]
emerge log
Comment 3 Erik Zeek 2008-08-23 03:29:30 UTC
Created attachment 163596 [details]
epatch ouput
Comment 4 Harald van Dijk (RETIRED) gentoo-dev 2008-08-23 10:05:46 UTC
Well, aside from the fact that the patch just doesn't work right now, the patch is the wrong approach anyway. Defining __amd64 in a header file means

#if defined(__amd64__)
#define HAVE_64BIT
#endif

#include <header a>
#if HAVE_64BIT
#include <header b>
#endif

cannot possibly work, because __amd64__ isn't defined yet. It should be defined in icc.cfg/icpc.cfg, as suggested on <http://softwarecommunity.intel.com/isn/Community/en-US/forums/thread/30251206.aspx> (from #233739, no less)

I'll attach a patch shortly.
Comment 5 Harald van Dijk (RETIRED) gentoo-dev 2008-08-23 10:09:47 UTC
Created attachment 163608 [details, diff]
icc.diff

This patch makes __amd64__ conditional on use amd64, and defines it in the configuration files instead of a header.
Comment 6 Sébastien Fabbro (RETIRED) gentoo-dev 2008-08-23 11:45:20 UTC
Fixed in cvs. Thanks!