I've verified this against 9999/upstream-svn-rev361 and it's working fine here. It should apply cleanly to 0.132-r3 and 0.133 (when bumped, bug #234563) as well. The patch adds a text-box to the group properties dialog for spell-check language, so users can set different languages for different groups. As mentioned on the bug and noted in comments in the patch, the "right" way in terms of UI would be to make it a drop-down box, but gtkspell v2 alone apparently doesn't offer a list of available languages. gtkspell v3 will, and adding enchant as a dependency it could do it, but... So we're left with the text-box option, which isn't ideal but it's better than forcing a single spellcheck language for all groups as is now the case. (If the user supplied language doesn't match anything, it defaults back to the normal one, no harm done.) I'd really like to get this in at least 9999/live right away, hopefully providing at least a bit of testing for upstream. A bump to 0.133, dropping the previous patches (now upstream) and adding this one would be nice for testing, but I'm honestly not sure it's quite ready for that yet as I think it's only the two of us (the patch creator and I) that have tried it yet, and while it doesn't seem to break anything, I do only English anyway so I can't really properly test whether it actually works or not. See URL for upstream bug with patch, courtesy of Rui Maciel. @ eva: This is exactly the sort of thing I'd hoped to facilitate. =:^) Thanks again for the in-tree 9999. Duncan
Reassigning to correct maintainers. GNOME team serves as backup only on this package. One should assign to the first maintainer listed in metadata.xml and CC the rest, imho.
Thanks. I'd hoped someone with the authority to do so would note the eva@ cc and assign accordingly, since that's who has been handling many of the pan bugs, but I didn't realize the gnome component assignment would (apparently) assign it there. I based the component choice on some of the previous bugs, but they were likely before the auto-assign voodoo that seems to be operational now. Next time I guess I just use apps, since it's just a gtk app, not requiring full gnome. So thanks for the reassign. Duncan
could you kick upstream a bit so that they at least review the patch ?
We will track changes in upstream report directly.
