Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 234790 - media-libs/xine-lib: check for possible removal of hppa specific stuff in xine-libs's ebuilds
Summary: media-libs/xine-lib: check for possible removal of hppa specific stuff in xin...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: HPPA Porters
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-15 07:16 UTC by Alexis Ballier
Modified: 2008-08-15 17:04 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Ballier gentoo-dev 2008-08-15 07:16:48 UTC 
Currently there is that in xine-lib's ebuild:
    # The default CFLAGS (-O) is the only thing working on hppa.
    use hppa && unset CFLAGS

Which was apparently added a good bunch of time ago:
http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-libs/xine-lib/xine-lib-1_rc4-r1.ebuild?hideattic=0&r1=1.4&r2=1.5


One thing I hate with such code is that it tends to stay forever. I think it could be worth checking again if it is safe to remove it. If it isn't it'll still probably be better to use strip-flags or something like that instead of completely unsetting the CFLAGS.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2008-08-15 15:54:23 UTC 
I'll test it soon with something better than -O.
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2008-08-15 17:04:55 UTC 
It simply works. I don't know since which version, but I tested the latest stable version 1.1.15 and it simply works.