When using gtk+-2.13.x, XChat build fails at fe-gtk/fe-gtk.c. This file includes xtext.h which declares a function on line 273 with the type GtkType. This is deprecated in the development gtk+ and should be replaced with GType. Reproducible: Always Steps to Reproduce: 1. Install gtk+-2.13.x 2. Attempt to compile XChat
Please, have some common sense when filing a bug. As you said yourself, 2.13 is a development version and as such, nearly all of the bugs against it are invalid and definitely none are critical. At most, this is only a warning, that XChat will have to get a patch removing GTK_DISABLE_DEPRECATED from its cflags. Other than that, bug upstream about it.
something to add to a future tracker.
let's close this as LATER for now. @net-irc, if you happen to bump a version fixing that, please notify us by closing this bug as fixed, thanks in advance.
Created attachment 164726 [details] xchat-2.8.6-gtk+-2.13.patch Hi, I took this patch from http://sourceforge.net/tracker/index.php?func=detail&aid=2070689&group_id=239&atid=100239 and it solves the issues with >=gtk+-2.13 The patch works with older gtk as well as I already checked with my stable x86 machine and gtk+-2.12.10-r1. So I think this fix does not have to wait for gtk+-2.14 landing in portage. Cheers Poly-C
Reopening
@net-irc, this is your call. The proposed patch is trivial enough :) Thanks
It also happens with 2.14.2, which will get in portage soon anyway. Can we have an ebuild including this patch?
GTK_DISABLE_DEPRECATED, G_DISABLE_DEPRECATED and co MUST NOT be used in a released package such as a xchat release tarball. It is only OK in SVN developer builds. In addition to patching it to not use deprecated stuff, please also filter out that DISABLE_DEPRECATED macro usage if there is any, or I'll have to do it myself (I probably will soon anyhow, I'm working on adding gtk+-2.14 to tree today/tomorrow)
Created attachment 166162 [details] New ebuild with patch This is modification of xchat-2.8.6-r1 ebuild with supplied patch. Works for me.
*** Bug 238740 has been marked as a duplicate of this bug. ***
I have made it sed out the #define GTK_DISABLE_DEPRECATED lines from src/fe-gtk/*.c files. This is what makes it not break out of the blue in the face of usual deprecations in new versions of gtk+ and therefore makes it forwards compatible as sane tarball releases SHOULD be out of the box. I don't care about the patch, as that only fixes it for gtk+-2.14, with the GTK_DISABLE_DEPRECATED in place it will quite likely break with gtk+-2.16 again while the patch just stops using things deprecated in gtk+-2.14 and is necessary in the way of making it compatible with a future gtk3. The maintainers can decide on if to include the patch or not; I don't need it for unmasking gtk+-2.14; leaving bug open for that decision.
Removing blocker as stable version is fixed and this bug doesn't need to be tracked for upcoming (in a month) gtk+-2.14 stabilizing concerns
removing us from CC since there is enough information on this bug for net-irc to finish this off. Please add us back if you need anything else.
Well, Mart fixed it, so closing
