Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 234366 - gnome-base/gvfs 0.2.5-r1 has automagic dep on libarchive
Summary: gnome-base/gvfs 0.2.5-r1 has automagic dep on libarchive
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-10 10:10 UTC by Olliver Schinagl
Modified: 2008-09-07 22:46 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Olliver Schinagl 2008-08-10 10:10:43 UTC
The change in gvfs back in March '08 (http://mail.gnome.org/archives/svn-commits-list/2008-March/msg04753.html) introduced this little snipped:
+  switch (archive_entry_filetype (entry))
+    {
+      case AE_IFREG:
+	type = G_FILE_TYPE_REGULAR;
+	break;
+      case AE_IFLNK:
+	g_file_info_set_symlink_target (info,
+	                                archive_entry_symlink (entry));
+	type = G_FILE_TYPE_SYMBOLIC_LINK;
+	break;
+      case AE_IFDIR:
+	type = G_FILE_TYPE_DIRECTORY;
+	break;
+      case AE_IFCHR:
+      case AE_IFBLK:
+      case AE_IFIFO:
+	type = G_FILE_TYPE_SPECIAL;
+	break;
+      default:
+	g_warning ("unknown file type %u", archive_entry_filetype (entry));
+	type = G_FILE_TYPE_SPECIAL;
+	break;
+    }

However those AE_ defines aren't installed on my system. Turns out they go in libarchive, which gvfs doesn't depend on. I tried to emerge with USE="-*" and all useflags, it always uses those defines, making it that gvfs won't build.

Reproducible: Always

Steps to Reproduce:
Comment 1 Daniel Gryniewicz (RETIRED) gentoo-dev 2008-08-12 14:12:16 UTC
gvfs builds fine here without libarchive, and those symbols are not defined anywhere on my system.

archive is checked for in configure, and that code is protected, so it should all work fine, unless configure gets confused.  The only issue here is the automagic dep.
Comment 2 Rémi Cardona (RETIRED) gentoo-dev 2008-08-21 11:38:31 UTC
I can't reproduce here either and Daniel is right about the code being properly protected. Please provide a full build.log as suggested by portage so that we can further help you.

Thanks
Comment 3 Rémi Cardona (RETIRED) gentoo-dev 2008-08-21 12:16:42 UTC
The package still needs a USE flags, Automagic Deps Are Bad (tm)
Comment 4 Olliver Schinagl 2008-08-21 16:56:04 UTC
I found my problem.

Ages ago, i manually built libarchive (to add rar support, works too submitted patch to upstream, anyhow) and it was installed into /usr/local/lib and /usr/local/include (manual copy, just the so and it's 2 headers).

The configure script did find this extremly old version (which lacked support for those symbols) and thus the code just assumed i had the right version installed.

At the moment gvfs gets configured with libarchive support if the configure script finds it, no matter what version. since libarchive isn't installed (by portage) it shouldn't check for it.
Comment 5 Daniel Gryniewicz (RETIRED) gentoo-dev 2008-08-21 20:11:41 UTC
Good, that explains the build failure.  We still need to fix the automagic dep.
Comment 6 Gilles Dartiguelongue (RETIRED) gentoo-dev 2008-09-07 22:46:36 UTC
since nobody fixed it while it was time, I unilateraly decided libarchive won't be supported with gvfs-0.2 series. Fixed in tree without a bump. If you want libarchive support, you'll get it with 0.99/1.0 when 2.24 hits the tree.