Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 234084 - app-misc/lcdproc - ntp-client init.d script should run before LCDd/lcdproc
Summary: app-misc/lcdproc - ntp-client init.d script should run before LCDd/lcdproc
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Robert Buchholz (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-06 13:04 UTC by Yousef Shajrawi
Modified: 2008-09-12 17:07 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
new init script fixing the problem (ntp-client,838 bytes, patch)
2008-08-06 13:06 UTC, Yousef Shajrawi
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yousef Shajrawi 2008-08-06 13:04:10 UTC
the VFD display shown by lcdproc hangs when ntp-client starts if ntp changed the time.

Reproducible: Always

Steps to Reproduce:
1.rc-update add LCDd default
2.rc-update add lcdproc default
3.rc-update add ntp-client default

Actual Results:  
LCDd/lcdproc starts before ntp-client no matter what order they are added, resulting in them hanging when ntp-client starts
Comment 1 Yousef Shajrawi 2008-08-06 13:06:26 UTC
Created attachment 162358 [details, diff]
new init script fixing the problem

updated the depend() section of ntp-client to fix the problem
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2008-08-07 00:46:17 UTC
Could you please argue why the ntp-client script should be changed instead of the LCDd script? It's obvious to me that lcdproc has a problem (which I assume to be app-misc/lcdproc) and not net-misc/ntp... Besides that, it's also obvious that lcdproc shouldn't ever hang when time is adjusted and that any init script changes are mere workarounds for a more fundamental problem. Assigning to app-misc/lcdproc maintainers...
Comment 3 Yousef Shajrawi 2008-08-07 11:07:01 UTC
(In reply to comment #2)
> Could you please argue why the ntp-client script should be changed instead of
> the LCDd script? 
I didn't claim that, The two solutions (be it before() in one script or after() in the other) are identical be it correctness-wise or design-wise, I arbitrarily chosen to provide a fixed init script for one of them, my claim was that the *end result* should be ntp-client running before LCDd/lcdproc
>it's also obvious that lcdproc shouldn't ever hang when time is adjusted and >that any init script changes are mere workarounds for a more fundamental >problem.
I agree with you 100%, the best/ideal solution would be fixing-up the LCDd/lcdproc source code, changing the init scripts is just a simple/quick-hack alternative since all effected packages are marked stable, patching the source code is the ideal long term solution.
Comment 4 Robert Buchholz (RETIRED) gentoo-dev 2008-09-12 17:07:38 UTC
+*lcdproc-0.5.2-r2 (12 Sep 2008)
+
+  12 Sep 2008; Robert Buchholz <rbu@gentoo.org>
+  +files/0.5.2-r2-lcdproc.initd, lcdproc-0.5.1-r4.ebuild,
+  lcdproc-0.5.2-r1.ebuild, +lcdproc-0.5.2-r2.ebuild:
+  Add imonlcd to support Antec iMON LCD modules (bug #232328), lcdproc init
+  script should start after ntp-client (bug #234084), fix quoting.
+

I'll commit this later tonight once the new patchset hits the mirros.