The attached patch fixes building with --as-needed in LDFLAGS. Upstream probably didn't know how to properly use automake, the libraries were passed through LDFLAGS that is not correct. Thanks, Diego
Created attachment 161193 [details, diff] swfdec-gnome-2.22.2-asneeded.patch
I'm being retired now. Gnome herd should take care of this, or you commit yourself.
I can see that's wrong, but it builds fine for me with --as-needed. What's up with that?
libtool reorders the parameter so by default you won't see the failure. I'm testing with a slightly more aggressive setup and it fails :)
The patch looks obviously correct on its own merit. Makes it follow what automake manual says is supposed to be done
Hum... seeing how Bastien (Nocera) is involved with swfdec-gnome, I suggest you (Diego) open a bug on Gnome's bugzilla to explain directly to them why this patch is a good thing. I would, of course, commit it in a heart beat as it does the Right Thing (tm) but upstream might need some convincing :)
As it is the right thing, would you please commit it in the mean time while we wait from upstream? Otherwise I have to keep it modified locally which is boring. Thanks. At any rate I opened the bug upstream, as I couldn't find Bastien's email at hand.
we've been too slow doing anything with this bug but it's in >=2.24 so I guess we can close it now.