Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 232632 - net-misc/dropbear savedconfig messes up version string
Summary: net-misc/dropbear savedconfig messes up version string
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Daniel Black (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-22 09:40 UTC by Christoph Gysin
Modified: 2008-11-12 17:35 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Gysin 2008-07-22 09:40:37 UTC
The savedconfig useflags makes it possible to use a custom options.h and allows to change some #defines regarding dropbear configuration.

Unfortunately, options.h also contains (among other things) the version string DROPBEAR_VERSION. So if one uses savedconfig, the version string will never be updated.

Reproducible: Always

Steps to Reproduce:
1. USE=savedconfig emerge =net-misc/dropbear-0.50*
2. mv /etc/portage/savedconfig/net-misc/dropbear{-0.50,}
3. USE=savedconfig emerge =net-misc/dropbear-0.51*
4. dropbear -h

Actual Results:  

output:
Dropbear sshd v0.50
...



Expected Results:  

output:
Dropbear sshd v0.51
...



In options.h there is a line that says:
" * You shouldn't edit below here unless you know you need to."

Everything below is lowlevel configuration stuff, and should not be taken from savedconfig. This is a bit messy, and requires an ugly hack with sed & co. Should we try to get the dropbear guys to split options.h, or can is be done in a somehow acceptable manner?

TIA
Comment 1 solar (RETIRED) gentoo-dev 2008-07-30 04:21:20 UTC
dragonheart, Maybe some sed logic-love after the config.h is populated?
Comment 2 Daniel Black (RETIRED) gentoo-dev 2008-07-30 10:11:58 UTC
(In reply to comment #1)
> dragonheart, Maybe some sed logic-love after the config.h is populated?
> 

Sure. I've just emailed the upstream author for his opinion and plans.

Thanks Christoph for highlighting these deficiencies.
Comment 3 SpanKY gentoo-dev 2008-11-12 17:35:27 UTC
this is fixed with 0.52 ... upstream moved these options into sysoptions.h