Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 231974 - xine-lib-1.1.13 and .14 crash apps when mp3 file has comment tag containing only seperator chars
Summary: xine-lib-1.1.13 and .14 crash apps when mp3 file has comment tag containing o...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal with 1 vote (vote)
Assignee: Ben de Groot (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-16 15:27 UTC by Kevin R André
Modified: 2008-08-07 07:13 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
backtrace (amarok_backtrace.txt.gz,6.75 KB, application/octet-stream)
2008-07-16 15:36 UTC, Kevin R André
Details
It crashed again. (amarok_backtrace_hang2.txt.gz,3.79 KB, application/octet-stream)
2008-07-18 19:15 UTC, Kevin R André
Details
Disable setting meta info for tags containing only separator chars (xine-lib-1.1.14-meta_info.patch,821 bytes, patch)
2008-07-26 13:57 UTC, enkil
Details | Diff
Fix a logic error which can cause misidentification as DV. (xine-lib-1.1.14-misidentification.patch,406 bytes, patch)
2008-08-07 07:13 UTC, enkil
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin R André 2008-07-16 15:27:54 UTC
I have Amarok hanging or crashing often lately. Most of the times it just hangs and I have to kill it, but sometimes it crashes and runs KMail to send a backtrace report.

$ emerge --info
Portage 2.1.4.4 (default/linux/x86/2008.0/desktop, gcc-4.1.2, glibc-2.6.1-r0, 2.6.25-gentoo-r6 i686)
=================================================================
System uname: 2.6.25-gentoo-r6 i686 AMD Turion(tm) 64 X2 Mobile Technology TL-60
Timestamp of tree: Tue, 15 Jul 2008 16:04:01 +0000
ccache version 2.4 [enabled]
app-shells/bash:     3.2_p33
dev-java/java-config: 1.3.7, 2.1.6
dev-lang/python:     2.4.4-r13
dev-python/pycrypto: 2.0.1-r6
dev-util/ccache:     2.4-r7
sys-apps/baselayout: 1.12.11.1
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.13, 2.61-r2
sys-devel/automake:  1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.1-r1
sys-devel/binutils:  2.18-r3
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   1.5.26
virtual/os-headers:  2.6.23-r3
ACCEPT_KEYWORDS="x86"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=k8 -msse3 -pipe -ggdb"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/config /var/lib/hsqldb"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/revdep-rebuild /etc/terminfo /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-O2 -march=k8 -msse3 -pipe -ggdb"
DISTDIR="/usr/portage/distfiles"
FEATURES="ccache collision-protect distlocks metadata-transfer parallel-fetch sandbox sfperms splitdebug strict strip unmerge-orphans userfetch"
GENTOO_MIRRORS="http://linux.rz.ruhr-uni-bochum.de/download/gentoo-mirror/ ftp://ftp.snt.utwente.nl/pub/os/linux/gentoo"
LANG="en_US.UTF8"
LDFLAGS="-Wl,-O1"
LINGUAS="en nl"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/portage/local/layman/sunrise /usr/portage/local/layman/kde /usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X acl acpi alsa avahi berkdb bluetooth branding bzip2 cairo cdr cli cracklib crypt cups dbus dri dvd dvdr dvdread eds emboss encode esd evo fam firefox fortran gdbm gif gpm gstreamer gtk hal iconv ipv6 isdnlog jpeg kde kerberos ldap libnotify lm_sensors mad midi mikmod mp3 mpeg mudflap ncurses nforce2 nls nptl nptlonly nsplugin nvidia ogg opengl openmp pam pcre pdf perl pmu png ppds pppd python qt qt3 qt3support qt4 quicktime readline reflection samba sdl session spell spl ssl startup-notification svg tcpd tiff truetype type1 unicode vorbis win32codecs wma x86 xcomposite xine xml xorg xv zeroconf zlib" ALSA_CARDS="hda-intel usb-audio" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en nl" USERLAND="GNU" VIDEO_CARDS="nvidia vesa fbdev"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

I'll put the backtrace in an attachment.
Comment 1 Kevin R André 2008-07-16 15:36:00 UTC
Created attachment 160576 [details]
backtrace

This is the backtrace from the latest crash. I could also attach the one from the first crash, but I'm not sure that would be useful.
Comment 2 Kevin R André 2008-07-18 17:31:15 UTC
Now I got a backtrace from when it hangs, because I ran amarokapp in a terminal. When it froze I saw the following output:

*** glibc detected *** amarokapp: free(): invalid pointer: 0x08477a50 ***
======= Backtrace: =========
/lib/libc.so.6[0xb5c78a00]
/lib/libc.so.6(cfree+0x89)[0xb5c7a6f9]
/usr/lib/libxine.so.1[0xb3a9b94f]
/usr/lib/libxine.so.1(_x_meta_info_reset+0x37)[0xb3a9ba47]
/usr/lib/libxine.so.1[0xb3a77f54]
/usr/lib/libxine.so.1(xine_close+0x50)[0xb3a78070]
/usr/lib/kde3/libamarok_xine-engine.so(_ZN10XineEngine4loadERK4KURLb+0x3e0)[0xb3acf8e0]
/usr/lib/libamarok.so.0(_ZN16EngineController4playERK10MetaBundlej+0x4f2)[0xb7c5b472]
/usr/lib/libamarok.so.0(_ZN8Playlist8activateEP13QListViewItem+0x1af)[0xb7d062df]
/usr/lib/libamarok.so.0(_ZN8Playlist13playNextTrackEb+0x225)[0xb7d0b5b5]
/usr/lib/libamarok.so.0(_ZN8Playlist9qt_invokeEiP8QUObject+0x1a1)[0xb7d0c991]
/usr/qt/3/lib/libqt-mt.so.3(_ZN7QObject15activate_signalEP15QConnectionListP8QUObject+0x169)[0xb65e77e9]
/usr/qt/3/lib/libqt-mt.so.3(_ZN7QObject20activate_signal_boolEib+0x145)[0xb65e7ec5]
/usr/lib/libamarok.so.0(_ZN16EngineController9orderNextEb+0x3e)[0xb7c5792e]
/usr/lib/libamarok.so.0(_ZN16EngineController4nextEb+0x4e)[0xb7c5798e]
/usr/lib/libamarok.so.0(_ZN16EngineController9qt_invokeEiP8QUObject+0x8e)[0xb7c5c3be]
/usr/kde/3.5/lib/libkdecore.so.4(_ZN19KGlobalAccelPrivate8activateEP12KAccelActionRK12KKeySequence+0x46b)[0xb6c5a30b]
/usr/kde/3.5/lib/libkdecore.so.4(_ZN19KGlobalAccelPrivate11x11KeyPressEPK7_XEvent+0x335)[0xb6c5a835]
/usr/kde/3.5/lib/libkdecore.so.4(_ZN19KGlobalAccelPrivate8x11EventEP7_XEvent+0x54)[0xb6c5aa24]
/usr/kde/3.5/lib/libkdecore.so.4(_ZN12KApplication14x11EventFilterEP7_XEvent+0x83)[0xb6bd79c3]
/usr/qt/3/lib/libqt-mt.so.3[0xb6518e04]
/usr/qt/3/lib/libqt-mt.so.3(_ZN12QApplication15x11ProcessEventEP7_XEvent+0x228)[0xb65286f8]
/usr/qt/3/lib/libqt-mt.so.3(_ZN10QEventLoop13processEventsEj+0x4c1)[0xb6539851]
/usr/qt/3/lib/libqt-mt.so.3(_ZN10QEventLoop9enterLoopEv+0x50)[0xb659f6b0]
/usr/qt/3/lib/libqt-mt.so.3(_ZN10QEventLoop4execEv+0x26)[0xb659f536]
/usr/qt/3/lib/libqt-mt.so.3(_ZN12QApplication4execEv+0x1f)[0xb6588a9f]
amarokapp[0x804c647]
/lib/libc.so.6(__libc_start_main+0xdc)[0xb5c28fdc]
amarokapp(_ZN6QGListD0Ev+0x8d)[0x804bca1]
======= Memory map: ========
08048000-0806c000 r-xp 00000000 08:03 17073539   /usr/bin/amarokapp
0806c000-0806d000 r--p 00024000 08:03 17073539   /usr/bin/amarokapp
0806d000-0806e000 rw-p 00025000 08:03 17073539   /usr/bin/amarokapp
0806e000-09749000 rw-p 0806e000 00:00 0          [heap]
afcab000-afcac000 ---p afcab000 00:00 0
afcac000-b04ac000 rwxp afcac000 00:00 0
b04ac000-b04bc000 r--p 00000000 08:03 15647810   /usr/share/fonts/ttf-bitstream-vera/VeraBI.ttf
b04bc000-b04cc000 r--p 00000000 08:03 15647811   /usr/share/fonts/ttf-bitstream-vera/VeraIt.ttf
b04cc000-b0510000 r--p 00000000 08:03 15778266   /usr/share/fonts/corefonts/arial.ttf
b0510000-b0520000 rw-s 00000000 00:08 851973     /SYSV0056a4d6 (deleted)
b0520000-b0535000 r-xp 00000000 08:03 15549687   /usr/lib/libmad.so.0.2.1
b0535000-b0536000 r--p 00015000 08:03 15549687   /usr/lib/libmad.so.0.2.1
b0536000-b0537000 rw-p 00016000 08:03 15549687   /usr/lib/libmad.so.0.2.1
b0542000-b0552000 rw-s 00000000 00:0e 1184       /dev/snd/pcmC0D0p
b0552000-b0554000 r-xp 00000000 08:03 15679717   /usr/lib/xine/plugins/1.22/xineplug_decode_mad.so
b0554000-b0555000 r--p 00001000 08:03 15679717   /usr/lib/xine/plugins/1.22/xineplug_decode_mad.so
b0555000-b0556000 rw-p 00002000 08:03 15679717   /usr/lib/xine/plugins/1.22/xineplug_decode_mad.so
b0556000-b055d000 r--s 00000000 08:03 10862926   /usr/lib/gconv/gconv-modules.cache
b055d000-b0562000 r-xp 00000000 08:03 15679734   /usr/lib/xine/plugins/1.22/xineplug_inp_pnm.so
b0562000-b0563000 r--p 00004000 08:03 15679734   /usr/lib/xine/plugins/1.22/xineplug_inp_pnm.so
b0563000-b0564000 rw-p 00005000 08:03 15679734   /usr/lib/xine/plugins/1.22/xineplug_inp_pnm.so
b0564000-b0570000 r-xp 00000000 08:03 15679699   /usr/lib/xine/plugins/1.22/xineplug_inp_rtsp.so
b0570000-b0571000 r--p 0000b000 08:03 15679699   /usr/lib/xine/plugins/1.22/xineplug_inp_rtsp.so
b0571000-b0572000 rw-p 0000c000 08:03 156
^C
Comment 3 Kevin R André 2008-07-18 19:15:44 UTC
Created attachment 160751 [details]
It crashed again.
Comment 4 enkil 2008-07-21 11:20:49 UTC
Same problem here with amarok-1.4.9.1-r1. Happens when it changes tracks, but it seems to be random. Sometimes it runs for hours without crashing, sometimes it runs only for a couple of minutes.

emerge --info
Portage 2.2_rc1 (default/linux/x86/2008.0, gcc-4.3.1, glibc-2.7-r2, 2.6.26 i686)
=================================================================
System uname: Linux-2.6.26-i686-Intel-R-_Core-TM-2_Duo_CPU_E8200_@_2.66GHz-with-glibc2.0
Timestamp of tree: Mon, 21 Jul 2008 08:45:04 +0000
app-shells/bash:     3.2_p39
dev-java/java-config: 1.3.7, 2.1.6-r1
dev-lang/python:     2.4.4-r6, 2.5.2-r5
dev-python/pycrypto: 2.0.1-r6
sys-apps/baselayout: 2.0.0
sys-apps/openrc:     0.2.5
sys-apps/sandbox:    1.2.18.1-r3
sys-devel/autoconf:  2.13, 2.62-r1
sys-devel/automake:  1.5, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.1-r1
sys-devel/binutils:  2.18-r3
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   2.2.4
virtual/os-headers:  2.6.25-r4
ACCEPT_KEYWORDS="x86 ~x86"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=core2 -pipe -fomit-frame-pointer -msse4.1"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /opt/glftpd/etc /opt/glftpd/ftp-data /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/config /var/lib/hsqldb"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/terminfo /etc/udev/rules.d"
CXXFLAGS="-O2 -march=core2 -pipe -fomit-frame-pointer -msse4.1 -fvisibility-inlines-hidden"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--alphabetical"
FEATURES="distlocks parallel-fetch preserve-libs sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="http://linux.rz.ruhr-uni-bochum.de/download/gentoo-mirror/ http://gentoo.chem.wisc.edu/gentoo/ http://gentoo.osuosl.org/"
LC_ALL="en_US.iso885915"
LDFLAGS="-Wl,-O1"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_EXTRA_OPTS="--progress"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/
packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="X a52 aac aalib acl acpi akode alsa bash-completion berkdb bzip2 cairo cdr cli cracklib crypt cups dba dbus dga dri dts dvd dvdr dvdread ffmpeg foomaticdb fortran ftp gd gdbm g
if gpm gtk gtk2 hal iconv icq ipv6 isdnlog java jpeg kde kdehiddenvisibility lirc midi mjpeg mmx mp3 mp4 mpeg mplayer mudflap musepack musicbrainz ncurses nfs nls no-old-linux nptl 
nptlonly nsplugin nvidia oggvorbis opengl openmp oss pam pcre pdf pdflib perl png ppds pppd python qt qt3 qt4 readline reflection session smp spl sse sse2 ssl svg svga tcpd threads 
tiff truetype unicode usb v4l v4l2 win32codecs wmf x264 x86 xine xorg xulrunner xv xvid zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x en
s1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop emp
ty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon a
uthn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ex
t_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC
="glibc" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIRC_DEVICES="hauppauge" USERLAND="G
NU" VIDEO_CARDS="nvidia vesa v4l"
Unset:  CPPFLAGS, CTARGET, INSTALL_MASK, LANG, LINGUAS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS
Comment 5 Kevin R André 2008-07-21 16:29:39 UTC
(In reply to comment #4)
> Same problem here with amarok-1.4.9.1-r1. Happens when it changes tracks, but
> it seems to be random. Sometimes it runs for hours without crashing, sometimes
> it runs only for a couple of minutes.

Yup. That's my experience as well.
Comment 6 brho 2008-07-22 00:54:44 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > Same problem here with amarok-1.4.9.1-r1. Happens when it changes tracks, but
> > it seems to be random. Sometimes it runs for hours without crashing, sometimes
> > it runs only for a couple of minutes.
> 
> Yup. That's my experience as well.
> 

Same here - only on song changes.  I downgraded to 1.4.8 and the problem remained.  Considering how the backtrace said it tried to free an invalid pointer through the xine functions, I upgraded xine-lib from 1.1.13 to 1.1.14.  Unfortunately, that didn't work either.
Comment 7 Tim Bowers 2008-07-24 14:33:47 UTC
Same problem here - Randomly appeared and really annoying.

Amarok itsself stops responding, always appears to die on track change. Infact I can reproduce it by playing some tracks which cause it to crash, but I can't work out whats special about those tracks...
Comment 8 enkil 2008-07-24 18:14:12 UTC
(In reply to comment #7)
> Same problem here - Randomly appeared and really annoying.
> 
> Amarok itsself stops responding, always appears to die on track change. Infact
> I can reproduce it by playing some tracks which cause it to crash, but I can't
> work out whats special about those tracks...
> 
Would you mind sharing one of those tracks? I have problems reproducing the error. I might compile amarok with another engine to see if that changes anything.

There is a topic in the amarok forums, but they didn't find a solution either:
http://amarok.kde.org/forum/index.php?topic=15545.0

Are you using random mode or can you reproduce the error by just trying to play the tracks you mentioned?
Comment 9 Tim Bowers 2008-07-24 18:27:18 UTC
I know for sure that one track tht was causing me problems was a Bob Sinclair track off a recent minestry of sound album.

I deleted the track right away - Nope, dont have the original CD either sadly. But before i deleted it I checked various parts of the file info to see if i could notice anything strange.

There were no weird letters in the track name its self, but in the "assoicated" tracks - it did list a artist something like - "de lacy" but in the space, was a question mark, like "de?lacy".

I tried restarting with the same play list - everytime it crashed (*Also the track it was coming FROM had ( ) in it, *track was killing time - (HeD) P.E.*.

I reordered the playlist randomly, removed the bob sinclair track, then re-added it after a different song - Tried playing the song - On track change - crashed again.

Sorry this isn't "much" infomation to go on but I acted on impulse and didn't really expect it to work! However, amarok has now been playing from when I first filed my comment (few hours ago) and its not hiccuped yet.

If you need anymore infomation feel free to ask, and I'll attempt to provide it!.
Sorry I can't provide more hel
Comment 10 brho 2008-07-24 19:26:13 UTC
> Would you mind sharing one of those tracks? I have problems
> reproducing the error. I might compile amarok with another engine to
> see if that changes anything.

The tracks that crash when they are loading do so every time.  For me,
all tracks in an album crash (I didn't notice since they were randomly
selected).  It turns out that the problem is in the id3tags.  All of my
culprits have and empty comment tag:

=== COMM (Comments): ()[XXX]:  

If I put in a dummy string in the comment tag ("None"), then it no
longer crashes amarok.  I needed to put in the comment for both v1 and
v2.  If only v2 had text, then it would still crash.

Here's a track that crashes: (Be careful, this one crashed firefox too)
http://www.cs.berkeley.edu/~brho/emperor_01_intro-crash.mp3

Here's the same track with changed id3info that doesn't crash:
http://www.cs.berkeley.edu/~brho/emperor_01_intro-no_crash.mp3

It's a little interesting that firefox crashed while trying to verify my crash.mp3 link.

Anyway, for my tests, I grabbed 1.4.9.1, compiled with --enable-debug=full, and am running it in gdb.  Incidentally, gdb's backtrace isn't giving me much to work with.
Comment 11 brho 2008-07-24 20:02:42 UTC
> It's a little interesting that firefox crashed while trying to verify my
> crash.mp3 link.

Well, thanks to that little bit, I tried playing the files directly in xine.  It turns out that xine-lib-1.1.13 and 1.1.14 both crash for the above file.  1.1.8 does not crash.  Downgrading and restarting amarok stops the crashing.
Comment 12 Tim Bowers 2008-07-25 08:39:09 UTC
I have no idea whats causing the problem, but is it possible someone write a small script which will fix the broken ID3 Tags? As unless I track when each and ever track plays, I wont know which ones have broken !

Comment 13 enkil 2008-07-25 14:43:07 UTC
(In reply to comment #10)
> > Would you mind sharing one of those tracks? I have problems
> > reproducing the error. I might compile amarok with another engine to
> > see if that changes anything.
> 
> The tracks that crash when they are loading do so every time.  For me,
> all tracks in an album crash (I didn't notice since they were randomly
> selected).  It turns out that the problem is in the id3tags.  All of my
> culprits have and empty comment tag:
> 
> === COMM (Comments): ()[XXX]:  

Thanks for investigating. There is an entry on the xine-bugtracker that seems to adress the same issue: http://bugs.xine-project.org/show_bug.cgi?id=130

As I posted there already, the problem seems to be with comment tags that contain only seperator chars. Trailing separator chars are getting removed by xine (in meta_info_chomp in xine-engine/info_helper.c).
If you remove the call to meta_info_chomp in meta_info_set_unlocked_utf8, the file you posted plays fine.
Comment 14 enkil 2008-07-26 13:57:39 UTC
Created attachment 161418 [details, diff]
Disable setting meta info for tags containing only separator chars

You can try this patch until the issue is fixed by the xine-devs.

This patch checks for tags that only contain separator chars, and if it finds such a tag, it's going to discard it (most code is taken from meta_info_chomp).
With that patch, the previously posted mp3s don't crash xine anymore.

Please note that this isn't a proper solution for the problem but a dirty hack to (hopefully) avoid the crash. I don't know enough about the xine-code to figure out which part of xine reads the chomped tags and makes it crash because the tag only contains null chars (which is being done by meta_info_chomp).

If amarok still crashes, there might be another issue with tags that I didn't figure out.
Comment 15 Ben de Groot (RETIRED) gentoo-dev 2008-08-01 11:50:06 UTC
I can confirm that amarok freezes (in my case) with the provided test file. From the upstream bug report -- http://bugs.xine-project.org/show_bug.cgi?id=130 -- it is clear that this is a xine-lib issue. The patch looks good to me, so I'll look into applying that to 1.1.14. 

People who want to stay with stable are recommended to mask xine-lib-1.1.13 and downgrade to 1.1.8, which is reported to work in the upstream bug report.
Comment 16 Ben de Groot (RETIRED) gentoo-dev 2008-08-01 12:13:07 UTC
With the patch, Amarok starts playing the track, but then crashes a little later. So I will not be applying the patch to xine-lib-1.1.14. Waiting for a better solution.
Comment 17 Diego Elio Pettenò (RETIRED) gentoo-dev 2008-08-05 07:40:21 UTC
Reassigning amarok bugs to Ben as I won't be around for a while (leaving soon for the hospital -- either they hospitalise me or I get to convalescence). Ben feel free to update metadata if you wish, Amarok better have a new maintainer for the future.
Comment 18 enkil 2008-08-06 23:00:56 UTC
Upstream sais that these are two bugs. One bug with metadata-handling (only on x86) which is fixed through this patch:

http://hg.debian.org/hg/xine-lib/xine-lib?cmd=changeset;node=60ab5d2bdd82f00b10205f816a545337c9363134;style=raw

the second issue was that some files had been misidentified as DV, fixed with this patch:

http://hg.debian.org/hg/xine-lib/xine-lib?cmd=changeset;node=7628777305de04d9fcd4255c8e08781cc5f116b8;style=raw
Comment 19 Ben de Groot (RETIRED) gentoo-dev 2008-08-06 23:32:48 UTC
Upstream patch applied to 1.1.14-r1. If no issues are reported in the next few days, I will request this version to be marked stable.
Comment 20 enkil 2008-08-07 07:11:59 UTC
(In reply to comment #19)
> Upstream patch applied to 1.1.14-r1. If no issues are reported in the next few
> days, I will request this version to be marked stable.
> 
Thank you. Would you mind applying the second patch that fixes the problem with dv misidentification as well? I've attached a modified version of the patch to reflect a diff between 1.1.14 and current hg, the patch I posted earlier won't apply to 1.1.14.
Comment 21 enkil 2008-08-07 07:13:11 UTC
Created attachment 162413 [details, diff]
Fix a logic error which can cause misidentification as DV. 

Fixes the DV misidentification bug, patch for xine-lib-1.1.14