The ebuild does not compile when Linux kernel 2.6.26 is installed (currently, only the vanilla kernel 2.6.26 is available, but the gentoo variant will follow soon). Reproducible: Always Steps to Reproduce: 1. Have Linux kernel 2.6.26 installed. 2. emerge pcfclock Actual Results: Compilation fails because Linux kernel 2.6.26 changed the device API again: [...] make[3]: Entering directory `/usr/src/linux-2.6.26' CC [M] /var/tmp/portage/sys-apps/pcfclock-0.44-r3/work/pcfclock-0.44/linux/pcfclock.o /var/tmp/portage/sys-apps/pcfclock-0.44-r3/work/pcfclock-0.44/linux/pcfclock.c: In function 'pcfclock_register': /var/tmp/portage/sys-apps/pcfclock-0.44-r3/work/pcfclock-0.44/linux/pcfclock.c:474: error: implicit declaration of function 'class_device_create' /var/tmp/portage/sys-apps/pcfclock-0.44-r3/work/pcfclock-0.44/linux/pcfclock.c: In function 'pcfclock_cleanup_module': /var/tmp/portage/sys-apps/pcfclock-0.44-r3/work/pcfclock-0.44/linux/pcfclock.c:601: error: implicit declaration of function 'class_device_destroy' make[4]: *** [/var/tmp/portage/sys-apps/pcfclock-0.44-r3/work/pcfclock-0.44/linux/pcfclock.o] Error 1 make[3]: *** [_module_/var/tmp/portage/sys-apps/pcfclock-0.44-r3/work/pcfclock-0.44/linux] Error 2 make[3]: Leaving directory `/usr/src/linux-2.6.26' make[2]: *** [pcfclock.ko] Error 2 make[2]: Leaving directory `/var/tmp/portage/sys-apps/pcfclock-0.44-r3/work/pcfclock-0.44/linux' make[1]: *** [all-recursive] Error 1 [...] Expected Results: emerge should succeed. Linux kernel 2.6.26 changed the device API again: class_device_* have been removed.
Created attachment 160386 [details, diff] Patch for kernel 2.6.26 Attaching a proposed patch to make the ebuild compile against kernel 2.6.26. This should be applied on top of "pcfclock-0.44-kernel-2.6.18.diff" in the ebuild (but you may also combine both).
patch looks sane to me. But I will combine it, so we have only one patch.
patch included in pcfclock-0.44-r4
