Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 231675 - dev-python/twisted{,-words,-web]-8.1.0: Req. for stable-marking
Summary: dev-python/twisted{,-words,-web]-8.1.0: Req. for stable-marking
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: High enhancement
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords: STABLEREQ
Depends on:
Blocks: 206043 234765
  Show dependency tree
 
Reported: 2008-07-13 11:27 UTC by Hanno Böck
Modified: 2009-02-20 18:12 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hanno Böck gentoo-dev 2008-07-13 11:27:47 UTC
I'd like to request stable marking of twisted-8.1.0 (and -web, -words, probably others). I know it fails in src_test, but that's no regression, old versions also do.

python-team, please comment on it and cc archs if you're ok with that.
Comment 1 Hanno Böck gentoo-dev 2008-08-04 21:56:55 UTC
archs please go ahead
Comment 2 Ferris McCormick (RETIRED) gentoo-dev 2008-08-05 12:38:51 UTC
Sparc done for twisted{-words,-web}-8.1.0  --- I'll leave us on CC in case you add to the list of requested packages.
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2008-08-08 03:12:41 UTC
Stable for HPPA.
Comment 4 Markus Rothe (RETIRED) gentoo-dev 2008-08-08 18:41:21 UTC
ppc64 stable
Comment 5 Raúl Porcel (RETIRED) gentoo-dev 2008-08-08 19:18:39 UTC
alpha/ia64/x86 stable
Comment 6 Santiago M. Mola (RETIRED) gentoo-dev 2008-08-09 18:16:29 UTC
@Python: What about -mail, -names, -news, -lore and -runner?
Comment 7 Dirkjan Ochtman (RETIRED) gentoo-dev 2008-08-11 07:44:47 UTC
Yeah, this is a problem. twisted-mail's stable version 0.3.0 is now only available for use with twisted-2.4.0, and recent buildbot seems to require twisted-mail, so all buildbot users cannot upgrade at this point. Please fix this.
Comment 8 Mike Nerone 2008-08-11 16:07:00 UTC
dev-python/twisted-8.1.0 generates the following error during the first merge:

============================
 * Byte compiling python modules for python-2.5 .. ...                                                                                                                          [ ok ]
 * Regenerating plugin cache
Traceback (most recent call last):
  File "<string>", line 1, in <module>

  File "/usr/lib/python2.5/site-packages/twisted/plugin.py", line 200, in getPlugins
    allDropins = getCache(package)
--- <exception caught here> ---
  File "/usr/lib/python2.5/site-packages/twisted/plugin.py", line 165, in getCache
    provider = pluginModule.load()
  File "/usr/lib/python2.5/site-packages/twisted/python/modules.py", line 380, in load
    return self.pathEntry.pythonPath.moduleLoader(self.name)
  File "/usr/lib/python2.5/site-packages/twisted/python/modules.py", line 618, in moduleLoader
    return self._moduleLoader(modname)
  File "/usr/lib/python2.5/site-packages/twisted/python/reflect.py", line 426, in namedAny
    topLevelPackage = _importAndCheckStack(trialname)
  File "/usr/lib/python2.5/site-packages/twisted/plugins/testplugin.py", line 12, in <module>
    from twisted.plugin import IPlugin, ITestPlugin, ITestPlugin2
exceptions.ImportError: cannot import name ITestPlugin
================================

After the error, the installation is actually successful, but I'm not sure it's trustworthy. Merging a second time resolves the problem (I assume because ITestPlugin is now available - I didn't actually look).
Comment 9 Mike Nerone 2008-08-11 16:11:24 UTC
And yes, the stable tree is broken. If you have any dependency on twisted-names, which has a dep on "=dev-python/twisted-2.4*", then portage will try to pull in both dev-python/twisted-2.4.0 and dev-python/twisted-8.1.0, which are in the same slot, so produce a conflict.
Comment 10 Mike Nerone 2008-08-11 16:12:27 UTC
Sorry, I meant to point out that the current stable twisted-names, dev-python/twisted-names-0.3.0, has that "=dev-python/twisted-2.4*" dependency.
Comment 11 Hanno Böck gentoo-dev 2008-08-11 16:33:04 UTC
For the test failures, this is known, though it also appears in the current stable ones, so it's not a regression.

Beside -web and -words, the following have hard deps on 2.4, so should probably be stable marked in sync:
-xish
-runner
-pair
-news
-names
-mail
-lore
-flow
-conch
Comment 12 Santiago M. Mola (RETIRED) gentoo-dev 2008-08-11 17:01:22 UTC
After some testing, it seems to me that these are ready to go stable:
twisted-8.1.0
twisted-web-8.1.0
twisted-words-8.1.0
twisted-conch-8.1.0
twisted-lore-8.1.0
twisted-mail-8.1.0
twisted-names-8.1.0
twisted-news-8.1.0
twisted-runner-8.0.0

And these packages should be removed from the tree:
twisted-xish
twisted-pair
twisted-flow

as well as twibber and old versions of pymsn-t which depend on twisted-xish.
Comment 13 Maurice van der Pot (RETIRED) gentoo-dev 2008-08-11 18:02:18 UTC
old pymsn-t removed
Comment 14 Ferris McCormick (RETIRED) gentoo-dev 2008-08-11 18:39:22 UTC
Sparc stable also for:
  twisted-runner-8.0.0
  twisted-names-8.1.0
  twisted-conch-8.1.0
  twisted-mail-8.1.0
  twisted-news-8.1.0
  twisted-conch-8.1.0
(All tests pass, although runner/names/news don't seem to have any tests.)

Keeping sparc on CC in case more requirements emerge.
Comment 15 Jesus Rivero (RETIRED) gentoo-dev 2008-08-12 03:38:07 UTC
Hello, 

dev-python/twisted-xish
dev-python/twisted-pair
dev-python/twisted-flow
dev-python/twibber

  Are now masked for removal in 30 days. as Coldwind pointed out, they are of no use now. 

  Please, go ahead with stabilization. 

  Thanks, 
Comment 16 Jesus Rivero (RETIRED) gentoo-dev 2008-08-12 05:02:38 UTC
Old versions of twisted-words (twisted-words-0.1.0-r1.ebuild and twisted-words-0.1.0-r2.ebuild) are removed from tree as they also depended on dev-python/twisted-xish

Regards, 
Comment 17 Santiago M. Mola (RETIRED) gentoo-dev 2008-08-13 09:03:33 UTC
amd64 stable.

repoman warnings:
   dev-python/twisted-web/twisted-web-8.1.0.ebuild: IUSE is not defined
   dev-python/twisted-names/twisted-names-8.1.0.ebuild: IUSE is not defined
   dev-python/twisted-conch/twisted-conch-8.1.0.ebuild: IUSE is not defined
   dev-python/twisted-mail/twisted-mail-8.1.0.ebuild: IUSE is not defined
   dev-python/twisted-lore/twisted-lore-8.1.0.ebuild: IUSE is not defined
   dev-python/twisted-news/twisted-news-8.1.0.ebuild: IUSE is not defined
   dev-python/twisted-runner/twisted-runner-8.0.0.ebuild: IUSE is not defined

IUSE is set in twisted.eclass, but you should define it in the ebuild too, even if it's empty.
Comment 18 Raúl Porcel (RETIRED) gentoo-dev 2008-08-13 11:17:10 UTC
alpha/ia64/x86 stable
Comment 19 Carsten Lohrke (RETIRED) gentoo-dev 2008-08-14 21:04:13 UTC
Marking something stable requires that all stable ebuilds work with the most recent stable common dependency you're stabilizing. This has been botched in this case, as comment 7 and bug 234765 highlight. cc'ing the QA team, since this should not happen in the stable tree.

I wonder what is so hard about to understand that this is not acceptable, given that I see such issues a lot more often nowadays.
Comment 20 Santiago M. Mola (RETIRED) gentoo-dev 2008-08-15 12:16:35 UTC
Please, hppa and ppc64, stabilize ASAP since you still have broken stable tree. The rest of arches are ok.
Comment 21 Jeroen Roovers (RETIRED) gentoo-dev 2008-08-15 13:55:31 UTC
(In reply to comment #20)
> Please, hppa and ppc64, stabilize ASAP since you still have broken stable tree.

Stabilise what?
Comment 22 Santiago M. Mola (RETIRED) gentoo-dev 2008-08-15 14:17:43 UTC
(In reply to comment #21)
> 
> Stabilise what?
> 

See comment #12. Anything in that list if you have previous stable versions.
Comment 23 Jeroen Roovers (RETIRED) gentoo-dev 2008-08-15 14:34:09 UTC
Nothing to do.
Comment 24 Markus Rothe (RETIRED) gentoo-dev 2008-08-24 11:29:46 UTC
ppc64 stable
Comment 25 nixnut (RETIRED) gentoo-dev 2008-12-20 18:39:42 UTC
ppc stable
Comment 26 Raúl Porcel (RETIRED) gentoo-dev 2009-02-20 18:12:12 UTC
All seems done